From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] [MXF] - Add jpeg2000 subdescriptor in MXF file.
Date: Tue, 19 Dec 2023 14:36:11 +0100
Message-ID: <6f69f808de8c7d6080e6a61b72575717252c3a45.camel@haerdin.se> (raw)
In-Reply-To: <7c1649cd-8b35-47fa-89d6-f7dfc11350e4@ektacom.com>
> + for ( comp = 0; comp < component_count; comp++ ) {
> + avio_write(pb, &sc->j2k_info.j2k_comp_desc[3*comp] , 3);
> + }
Looks like this could be simplified to just
avio_write(pb, sc->j2k_info.j2k_comp_desc, 3*component_count);
> + if (j2k_ncomponents != component_count) {
> + av_log(s, AV_LOG_ERROR, "Incoherence about components image
> number.\n");
> + }
I again feel this should be a hard error
> + for (comp = 0; comp < j2k_ncomponents; comp++) {
> + sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents] =
> bytestream2_get_byteu(&g); // Bitdepth for each component
> + sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents+1] =
> bytestream2_get_byteu(&g); // Horizontal sampling for each component
> + sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents+2] =
> bytestream2_get_byteu(&g); // Vertical sampling for each component
> + }
Could be simplified to a single avio_read()
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-19 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 16:25 Cédric Le Barz
2023-12-19 13:36 ` Tomas Härdin [this message]
2023-12-20 17:04 ` [FFmpeg-devel] [PATCH] [MXF] - Add jpeg2000 subdescriptor in MXF file (V2) Cédric Le Barz
2023-12-21 11:11 ` Tomas Härdin
2023-12-22 8:58 ` Cédric Le Barz
2023-12-31 13:16 ` Tomas Härdin
2023-12-31 14:45 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f69f808de8c7d6080e6a61b72575717252c3a45.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git