From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BD6C640A7C for ; Thu, 3 Feb 2022 11:53:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9311868AF45; Thu, 3 Feb 2022 13:53:29 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 55B4468AEB1 for ; Thu, 3 Feb 2022 13:53:23 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 213BrMKX012787-213BrMKY012787 for ; Thu, 3 Feb 2022 13:53:22 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id A83E2A1407 for ; Thu, 3 Feb 2022 13:53:22 +0200 (EET) Date: Thu, 3 Feb 2022 13:53:22 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <6f43c5bd-6ad-1f8c-d77-9b75bc552512@martin.st> References: <20220119203837.9047-1-martin@martin.st> <20220119203837.9047-2-martin@martin.st> <4cf21020-5cdf-6532-f6fb-3995ba1f3d78@martin.st> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 2/2] libfdk-aacdec: Flush delayed samples at the end X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 21 Jan 2022, Andreas Rheinhardt wrote: > Interesting: There is indeed a delay at the start (720 samples in a > quick test) compared to the native AAC decoder. > Furthermore, the current code is buggy, as it believes that > avcodec->time_base to be the time_base of the returned AVFrames (it is > in reality avcodec->pkt_timebase; just test with AAC-in-Matroska for this). > I haven't tested your patches, but I have now realized that there is > indeed an issue. And your patch should also fix the wrong timebase issue. Based on discussion on irc with Andreas and James, I think the conclusion was that this patch should be fine, so I'll go ahead and push it soon if there's no further comments on it. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".