From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D158047346 for ; Tue, 5 Sep 2023 13:19:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2E49168C7DF; Tue, 5 Sep 2023 16:19:26 +0300 (EEST) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 334A968C5B3 for ; Tue, 5 Sep 2023 16:19:20 +0300 (EEST) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-31768ce2e81so2075222f8f.1 for ; Tue, 05 Sep 2023 06:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693919959; x=1694524759; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=HhTaOQ9/hpCZL72Czpk2gfdh8kXCVXNDa+sM6DCJQJI=; b=AqKa/L0Lp2E/6uR72a6yZOVsSKwjJ0s9FEEtwCrga3wZjzw/5v+YgAbDmX3pnSOG6Y MsdkENXj5IyrTIsJ2cXkakQe1OzSATmuAsIEKKK2DLrA5VlyalyEYMA1RR0KkHFeQUxo JRSURrchc/EVnJ4+xPYkbQoWBvp8EtGUlJU0LdtSh6u/1TDeY391BZHp2fPc8Zf2IJ3u D4CTdbTtQplHV82n5IFhMqWEp1rOnFLrWVLjaGKmjDL0LufrRSWiVX5kyi60n6uOsV+V wYGjbE+et8O13v1NrUnW0glzyFwCPeClnKfTFoyU5uSrcAu1bi5QVN6+S4wDzMmP3Unm u3JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693919959; x=1694524759; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HhTaOQ9/hpCZL72Czpk2gfdh8kXCVXNDa+sM6DCJQJI=; b=ajuI+pb0vBkf8o5wRYd7TrknvcKm/me2NnlUJ8Qd7Jk576HKYeIVYcW1F4mbk3dzFw aOUhcBolvO4h2yXdIc97eMiODGYgJOzFWej10rkEmFjvyeEOyzzTVEF9yvMEkmjIC9Nd 479SvWUiNnXfEYephLctjGBqiMvyjLQZOvbYvSJi0gLfuKocVU8qDtQh//uwiF0lEQC7 zeG17ErlGoM+9UYt3p0fCLDCGdkjY1vOP0Z7M6yCnPfuGn5kHp5CAxWJ846HtmkFxaDn yfroCZySlzM9qWfXzgVmrFvpZH8csjdRQ6uLibVXsGiKZKkhNXNn4Z0NoRHxuODyUspF xWYQ== X-Gm-Message-State: AOJu0YyerKmX8g9SLyCBO25YbbhctC0js7V2L2BLmfqs6LG0W/DRzJhy ukhQ8EsNbCOrp2ApaB/Ez2NAZHD3NIo= X-Google-Smtp-Source: AGHT+IGjUdnPI0JfBbahd2PjKUTvBxdmMuB8Fi7vMQPSvcjSTubK8LauSFd2DhSEXkPHsyQEZGOFDA== X-Received: by 2002:a5d:5227:0:b0:31a:d4d0:6e98 with SMTP id i7-20020a5d5227000000b0031ad4d06e98mr9494868wra.8.1693919959123; Tue, 05 Sep 2023 06:19:19 -0700 (PDT) Received: from [192.168.1.106] (33bf2829.skybroadband.com. [51.191.40.41]) by smtp.googlemail.com with ESMTPSA id r5-20020adfe685000000b003143867d2ebsm17529314wrm.63.2023.09.05.06.19.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 06:19:18 -0700 (PDT) Message-ID: <6eee5a65-516e-f165-43ee-4c513c4a1376@gmail.com> Date: Tue, 5 Sep 2023 14:19:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 To: ffmpeg-devel@ffmpeg.org References: <20230904150411.56777-1-jamrial@gmail.com> <7d9e4055-c77c-38e5-6e92-58a0eaff5e46@gmail.com> From: Derek Buitenhuis In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/4/2023 5:10 PM, James Almer wrote: >> * Warn users they need to update their code to not use stream side data (?). >> Will my code just silently change behavior if it was using stream >> side data? I legitimately do not know due to the above. > > How so? This, like any other deprecated field, remains working as it > always did until it's removed. The downstream users will see the > deprecation warning during compilation, and the doxy for the field > mentions the direct replacement. It's standard procedure. I mean dowstream users who are relying on the current behavior of checking the first packet or stream side data - will it just cease to behave that way silently? That is, users relying on the *output/result* of the current behavior. > I'll add a @deprecated comment to the doxy of > av_format_inject_global_side_data() to mention the aforementioned objective. > >> * Any useful doxy for API users or any example aside from function args and >> very basic struct info. > > The helper functions are basically the same as the packet ones, and the > stream ones I'm deprecating. add(), new(), get(), etc. Example usage as > usual is in ffmpeg.c, but i think the doxy does a good job explaining > what they do. I think neither ffmpeg.c nor doxy are very good ways to explain to API users both what they should use and why. The doxy relies on the fact you alreay know they exist and you need to use them and for what purpose. ffmpeg.c is the worst example for API users in the known universe. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".