From: zozobreak <zozobreak@163.com>
To: "FFmpeg development discussions and patches" <ffmpeg-devel@ffmpeg.org>
Cc: Steven Liu <lq@chinaffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'
Date: Wed, 29 Dec 2021 17:40:23 +0800 (CST)
Message-ID: <6ec2e891.65e0.17e058fe44c.Coremail.zozobreak@163.com> (raw)
In-Reply-To: <5a7719ef.6282.17e057ef58d.Coremail.zozobreak@163.com>
[-- Attachment #1: Type: text/plain, Size: 5016 bytes --]
From 0da67d346a7901b572ac9ec5812634576b315d79 Mon Sep 17 00:00:00 2001
From: zourenyi <zozobreak@163.com>
Date: Wed, 29 Dec 2021 17:33:50 +0800
Subject: [PATCH v3] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'
since there is only debug log 'no picture ooo' when droping a picture,
I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps',
FFmpeg keeped silence about this error, so a warning log is much helpfull about this.
Signed-off-by: zourenyi <zozobreak@163.com>
---
libavcodec/h264_slice.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
index c21004df97..f347d8ee1a 100644
--- a/libavcodec/h264_slice.c
+++ b/libavcodec/h264_slice.c
@@ -1533,7 +1533,13 @@ static int h264_select_output_frame(H264Context *h)
}
}
} else {
- av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : "");
+ if (out_of_order) {
+ av_log(h->avctx, AV_LOG_WARNING,
+ "drop picture(%c, %d/%" PRId64 ") because out of order\n",
+ av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts);
+ } else {
+ av_log(h->avctx, AV_LOG_DEBUG, "no picture\n");
+ }
}
return 0;
--
2.32.0.windows.2
At 2021-12-29 17:21:53, "zozobreak" <zozobreak@163.com> wrote:
From 4e148d5d0247e4e4ad927b9782a60fbd979065d3 Mon Sep 17 00:00:00 2001
From: zourenyi <zozobreak@163.com>
Date: Wed, 29 Dec 2021 17:03:53 +0800
Subject: [PATCH v2] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'
since there is only debug log 'no picture ooo' when droping a picture,
I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps',
FFmpeg keeped silence about this error, so a warning log is much helpfull about this.
Signed-off-by: zourenyi <zozobreak@163.com>
---
libavcodec/h264_slice.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
index c21004df97..a98cb2a142 100644
--- a/libavcodec/h264_slice.c
+++ b/libavcodec/h264_slice.c
@@ -1533,7 +1533,13 @@ static int h264_select_output_frame(H264Context *h)
}
}
} else {
- av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : "");
+ if (out_of_order) {
+ av_log(h->avctx, AV_LOG_WARNING,
+ "drop picture(%c, %d/%" PRId64 ") because of ooo\n",
+ av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts);
+ } else {
+ av_log(h->avctx, AV_LOG_DEBUG, "no picture\n");
+ }
}
return 0;
--
2.32.0.windows.2
At 2021-12-29 15:21:42, "Steven Liu" <lq@chinaffmpeg.org> wrote:
>
>
>> 2021年12月29日 下午2:59，zozobreak <zozobreak@163.com> 写道：
>>
>> since there is only debug log 'no picture ooo' when droping a picture,
>> I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps',
>> FFmpeg keeped silence about this error, so a warning log is much helpfull about this.
>>
>>
>>
>>
>> Signed-off-by: zourenyi <zozobreak@163.com>
>> ---
>> libavcodec/h264_slice.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>>
>>
>>
>> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
>> index c21004df97..f8bf8fe36e 100644
>> --- a/libavcodec/h264_slice.c
>> +++ b/libavcodec/h264_slice.c
>> @@ -1533,7 +1533,14 @@ static int h264_select_output_frame(H264Context *h)
>> }
>> }
>> } else {
>> - av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : "");
>> + if (out_of_order) {
>> + av_log(h->avctx, AV_LOG_WARNING,
>> + "drop picture(%c, %d) because of ooo\n",
>> + av_get_picture_type_char(out->f->pict_type), out->poc);
>> + }
>> + else {
>You shoulf fix code style, otherwise is ok.
>> + av_log(h->avctx, AV_LOG_DEBUG, "no picture\n");
>> + }
>> }
>> return 0;
>> --
>> 2.32.0.windows.2
>>
>> <0001-avcodec-libx264-add-warning-log-when-droping-picture.patch>_______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
>Thanks
>
>Steven Liu
>
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel@ffmpeg.org
>https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>To unsubscribe, visit link above, or email
>ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
[-- Attachment #2: v3-0001-avcodec-libx264-add-warning-log-when-droping-picture.patch --]
[-- Type: application/octet-stream, Size: 1400 bytes --]
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2021-12-29 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 6:59 zozobreak
2021-12-29 7:21 ` Steven Liu
2021-12-29 9:21 ` zozobreak
2021-12-29 9:40 ` zozobreak [this message]
2021-12-30 2:54 ` zozobreak
2021-12-30 3:08 ` zozobreak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ec2e891.65e0.17e058fe44c.Coremail.zozobreak@163.com \
--to=zozobreak@163.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=lq@chinaffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git