From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 79FC44E900 for <ffmpegdev@gitmailbox.com>; Tue, 18 Mar 2025 09:57:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1117F687A8A; Tue, 18 Mar 2025 11:57:25 +0200 (EET) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F5AE687A1A for <ffmpeg-devel@ffmpeg.org>; Tue, 18 Mar 2025 11:57:18 +0200 (EET) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-548409cd2a8so6361826e87.3 for <ffmpeg-devel@ffmpeg.org>; Tue, 18 Mar 2025 02:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1742291837; x=1742896637; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=WIPUa0LjNd8WuZOpFf2fSRlq0ftoSnFlcaYlRV1KYok=; b=2lXEOaiuYWH8Sj6nRWLXUHd0iIAEfHVf29mCUltqpbjOq3G8nmI+pb9NWt9sj5o5yY g13tvTL4bwXcXbicxfBPYDtdsMwurSZP5g0yeYm9xiCg4LGgjP151MqJxgWOdXQbQYEK 4Ofp6yAFPRNeuEGtSgqNz/Mcx342vatS6DWOOHb8OzDCep3wKRdA5HIRntWhED0yD0xh 6kisG142sMpoEe5q9rPvaSSx5rMnJEk/eP0pncBDilsIPMDh3iU9DF6954P/bOXYxXsL nBiGTn30+exNexen2LB0Cfa19HnDz1gK+Mf0osfEUWUEZMB5YiVPt18ADA4mgeS7dgUr xvMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742291837; x=1742896637; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WIPUa0LjNd8WuZOpFf2fSRlq0ftoSnFlcaYlRV1KYok=; b=dcEMM1mmbGyKjnpuMQmsHXL9p9S0OJzGLssSHw+Ij3+hW8unxFXnLfEfCdjl1Q7Dwm Oo/WMWcAMi0zYUqg2Jiuypj17xmDNUOOcfnm3M/glVIoiSx/T0WRexXJDV54yxO/moHK g/enYajouxDkVCcLkbkyqhgCqKOdnMDIsSRHn9qXi6DCKxtK+B5U+xRWAzi8nhnUIf5h ML8//uHf/RZhmqOIR24lv4jJ4SrhNey0L4ptIKOFCk+BIvQ/1J4AQAriYJi2CkhmPZTf HLzRpKgrLOpfeRH/dS+sJIaHJeMQzHkiCx8pGE0Mnpa/YKlxfqgEPHPHeL0MfZYdFjkS ctcQ== X-Gm-Message-State: AOJu0YzGRcfXGIAStg55NeGvDMe2QBUoYBYiknkz9KOIU8JBxe8TxRFQ DLs8XTnsBHeaGYhcbXQgKKfdJVEqUKr8/1MKCM9rIP8chlX6FjdApAWgXslNzDjM8CHGxUW/le9 TRw== X-Gm-Gg: ASbGnct04BT5Th1x3WB5gc8ZW+j1xkUisXwuJAM+4Cl852jrD67cXliPC2+NeHD9QEe oIzzIy7n5PRZRZYeSeW/omOtw5yAAA4dgutHN5mpUWurxzWHWojCEgVlGJkuY/RH7gFgPYBzBw7 p4usXQ3Wn6WuI3CKKwkCxxGUPPJAjXTJqIjiJlOVedgmm0wUYFXrthxU5CPsQk73zyf2DWX4Y2R sdEXb1vX002JjbSOKD+guuWnsLzQsnLwZzpAwv0xVRD4G4nB0KDQcYVmcmFba40mtUcubZXsjnM oDpwLZ23JsSTLpApO8LfirX9T7WPYfIJdE0gac/aeX78NgKUZ4YxUi83Ot0Efrhlj3RkE0YWyPc zwthsOGJT3zDIEMkrzQdF88ha1FWjKePeX70P/OYB X-Google-Smtp-Source: AGHT+IELo76BN0JG9lDqnDYnd3DfDzx5K0himx0OjaDztPgWeiKSrkn1BTxv0LMyeU+7uY7EkBDtWg== X-Received: by 2002:a05:6512:238d:b0:549:7145:5d32 with SMTP id 2adb3069b0e04-549c396eefcmr9713082e87.33.1742291837076; Tue, 18 Mar 2025 02:57:17 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549ba8853bbsm1594516e87.204.2025.03.18.02.57.16 for <ffmpeg-devel@ffmpeg.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 02:57:16 -0700 (PDT) Date: Tue, 18 Mar 2025 11:57:15 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> In-Reply-To: <34ad06cb-4e8c-42bc-89bb-d3013d7e0cdd@gyani.pro> Message-ID: <6e8dd136-549a-d2fd-db67-7b11f93d6eb@martin.st> References: <20250317151914.19384-1-ffmpeg@gyani.pro> <tencent_0E1CE84713EE936335C82901CEBDC547D305@qq.com> <34ad06cb-4e8c-42bc-89bb-d3013d7e0cdd@gyani.pro> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] ffbuild: use response files only if ar accepts them X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/6e8dd136-549a-d2fd-db67-7b11f93d6eb@martin.st/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On Mon, 17 Mar 2025, Gyan Doshi wrote: > > > On 2025-03-17 09:44 pm, Zhao Zhili wrote: >> >>> On Mar 17, 2025, at 23:16, Gyan Doshi <ffmpeg@gyani.pro> wrote: >>> >>> This is to not break linking with toolchains that don't support reading >>> args from a 'response file'. >>> --- >>> I've assumed that ld on a system will have same support as ar. >>> >>> configure | 7 +++++++ >>> ffbuild/library.mak | 8 ++++++++ >>> 2 files changed, 15 insertions(+) >>> >>> diff --git a/configure b/configure >>> index f6964c4ee1..d84e32196d 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -5230,6 +5230,12 @@ else >>> ar_o='$@' >>> fi >>> >>> +if $ar 2>&1 | grep -qi "@.*file"; then >>> + ar_objs="true" >>> +else >>> + ar_objs="" >>> +fi >> Works for me. > > Good. Let's wait for another report. This unbreaks the build for me on macOS too. As this change did break a fairly major platform, I don't think we should wait too long to either revert the change, or push the fix. As for the fix - I generally find it more robust to actually _try_ doing the requested thing (use a response file), than to look for specific strings in help output. I see that the regex, "@.*file", should be matched by both GNU ar and llvm-ar, so that's good. But e.g. MS lib.exe also supports response files, and it doesn't include this pattern in the output. Also MS lib.exe would certainly be a case where we'd want to use response files to overcome the command line length limit. So TL;DR, please push this to unbreak platforms like macOS and BSD, or revert the original change. But I don't find the test entirely ideal. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".