From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3366748F85 for ; Fri, 1 Mar 2024 15:37:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7B44B68D282; Fri, 1 Mar 2024 17:37:14 +0200 (EET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 13D4A68D19B for ; Fri, 1 Mar 2024 17:37:08 +0200 (EET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6e56787e691so2233352b3a.0 for ; Fri, 01 Mar 2024 07:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709307425; x=1709912225; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MoIDcrAKLj6SeLAZkP2Tkhl2EhVPrLqwzacX+elrkhY=; b=m1Zm46SXiJnzX1SBVef2pHL2u6j7eC+8aM6+6hMauOUV//65wHhQdmy4lgerNO14nb 6zCWh3dSVUIIemucRlAtAynrG1xF6hHDZwXrkKGsKiMdKTrquryckbtwp3cpE5SCgogr ODbj7mQlBhE2sOdavsJ83kt2bPvrjqjebvUTvSGxG52LUECIVsHwDbC/6lRRJtXViNW2 Q9Opb7ocJTwNpEZqmVac30l27sryZ/C8q1A50DKPJC/T45Rem2TKGLt87T7SVLAP5r/C HILzxM8wDldqDVcM3aAAjJwwpoTR2gStPoSV6OCiZ53WmHYVAXitGIj/qQZcHWg8bjbj hXWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709307425; x=1709912225; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MoIDcrAKLj6SeLAZkP2Tkhl2EhVPrLqwzacX+elrkhY=; b=HHOb2PBvmsKmfPU/3aUlnHp1rcdXZqIzDTZUxTObNt3q2YsZstJ83A982tZTeJ9u14 IxTfJ2L3wR+zltb6ZAnSyL7889Ok0ckKwPO4z6JuF3BqjB7KP4PDajI6kRA0me0srF9J UAg/4rWRr9MflenKWgByp6WqLdauTX7MfR8lVnNBeKgpHKyS6J0MlDRGQHEVAmbhFrrj NqIfKpfX9IHbwVL1Dmyir1RYmuODp3ZBsR8ZE1ADbEJsCekvY4T4ZLYU8NXmcu3SvFAQ hUqHd7kORyW3Jez/rbTCX6nE8BhhLZ902iRmwzhNzYbLKYsGL+CvPqhPG31kZ7j+MAv3 cmGA== X-Gm-Message-State: AOJu0YwId9rwmYNaKzjnAVHR4dH5B7LqahYT8YZfHCabhMqkFiBnpoGA OahaQeseQUbDOVs+Uc3tGfEDD6ORll6qB7gZqabItc11ICMhRfJqjkzAOWRr X-Google-Smtp-Source: AGHT+IG+b3KfX2RL2r1sN/wvO46uqGY5AUrHc7WdXH1e17rxR/Ql2Do/K5UHUh5hEilj4/cWI4w8Kw== X-Received: by 2002:a05:6a21:394a:b0:1a1:440a:b6e8 with SMTP id ac10-20020a056a21394a00b001a1440ab6e8mr55741pzc.6.1709307425147; Fri, 01 Mar 2024 07:37:05 -0800 (PST) Received: from [192.168.0.11] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id q67-20020a634346000000b005dc49afed53sm3184172pga.55.2024.03.01.07.37.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 07:37:04 -0800 (PST) Message-ID: <6e6c61c8-5e20-4306-b273-40e696eeef91@gmail.com> Date: Fri, 1 Mar 2024 12:37:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240301123743.2332-1-jamrial@gmail.com> <170930694339.29002.6349037667431329064@lain.khirnov.net> From: James Almer In-Reply-To: <170930694339.29002.6349037667431329064@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/decode: give packet side data priority over global X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/1/2024 12:29 PM, Anton Khirnov wrote: > Quoting James Almer (2024-03-01 13:37:43) >> Restores the behavior prior to ae22271620df90567ba276832b33607d64e9ba9c, where >> global side data would be inserted first to the output frame, resulting in both >> two entries for the same type and having priority when fetched by the AVFrame >> helpers. >> >> This is a temporary fix for ticket #10857 until a proper method to select the >> source for side data is implemented. > > Does it actually fix the ticket? I think > ff_decode_frame_props_from_pkt() is called before the decoder adds > bitstream side data to the frame. Oh, bitstream side data. I was thinking about packet side data (so also coming from lavf). Right, this would not work then, so patch dropped. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".