From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/decode: give packet side data priority over global
Date: Fri, 1 Mar 2024 12:37:08 -0300
Message-ID: <6e6c61c8-5e20-4306-b273-40e696eeef91@gmail.com> (raw)
In-Reply-To: <170930694339.29002.6349037667431329064@lain.khirnov.net>
On 3/1/2024 12:29 PM, Anton Khirnov wrote:
> Quoting James Almer (2024-03-01 13:37:43)
>> Restores the behavior prior to ae22271620df90567ba276832b33607d64e9ba9c, where
>> global side data would be inserted first to the output frame, resulting in both
>> two entries for the same type and having priority when fetched by the AVFrame
>> helpers.
>>
>> This is a temporary fix for ticket #10857 until a proper method to select the
>> source for side data is implemented.
>
> Does it actually fix the ticket? I think
> ff_decode_frame_props_from_pkt() is called before the decoder adds
> bitstream side data to the frame.
Oh, bitstream side data. I was thinking about packet side data (so also
coming from lavf). Right, this would not work then, so patch dropped.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-01 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 12:37 James Almer
2024-03-01 15:29 ` Anton Khirnov
2024-03-01 15:37 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e6c61c8-5e20-4306-b273-40e696eeef91@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git