Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Leslie P. Polzer via ffmpeg-devel" <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Cc: Michael Niedermayer <michael@niedermayer.cc>,
	"Leslie P. Polzer" <polzer.google@fastmail.com>
Subject: [FFmpeg-devel] Re: [PATCH] tools: add new fuzzers for avutil, avfilter, mux, network and cli
Date: Mon, 22 Dec 2025 17:18:19 +0800
Message-ID: <6e0a8dcc-f982-4a2f-8ccc-257ecae3ea76@app.fastmail.com> (raw)
In-Reply-To: <aUiykkeO9Vrf7nmK@neo>

Hi Michael,

appreciate the prompt review and comments! I've made the changes
and put up a PR:

https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21261

Best,

Leslie

On Mon, Dec 22, 2025, at 10:53 AM, Michael Niedermayer via ffmpeg-devel wrote:
> Hi Leslie
> 
> On Fri, Dec 19, 2025 at 08:11:34AM +0800, LP via ffmpeg-devel wrote:
> >  Hello FFmpeg developers,
> > 
> > This patch adds several new fuzzer targets to the tools/ directory to
> > improve
> 
> can you split this in a patch per fuzzer ?
> 
> also you may want to submit it to forgejo: https://code.ffmpeg.org/
> 
> 
> > test coverage for various components, including libavutil (AVOptions),
> > libavfilter,
> > muxers, network protocols, and the CLI options parsing.
> > 
> > It also introduces tools/run_fuzzer_loop.c, a simple harness that allows
> > running
> > these fuzzers in a loop without requiring a full libFuzzer environment.
> > 
> > I have verified that the new targets compile and run successfully.
> > 
> > Please find the patch attached.
> > 
> > Best,
> > 
> > Leslie
> 
> [...]
> 
> > +    // Fill frame with fuzz data if available
> > +    if (size > 0) {
> > +        int copy_size = size;
> > +        // Naive fill, just copy into first plane
> > +        if (copy_size > frame->buf[0]->size) copy_size = frame->buf[0]->size;
> 
> FFMIN()
> 
> > +        memcpy(frame->data[0], data, copy_size);
> > +    }
> > +
> 
> > +    ret = av_buffersrc_add_frame(src_ctx, frame);
> > +    if (ret < 0) goto end;
> > +
> > +    // Receive output
> > +    while (1) {
> > +        AVFrame *out = av_frame_alloc();
> > +        ret = av_buffersink_get_frame(sink_ctx, out);
> > +        av_frame_free(&out);
> > +        if (ret < 0) break;
> > +    }
> 
> can be simplified with while(ret >= 0)
> 
> 
> 
> 
> > +
> > +end:
> 
> > +    if (options_str) av_free(options_str);
> 
> the if() is unneeded
> 
> 
> [...]
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
> 
> _______________________________________________
> ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
> To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
> 
> 
> *Attachments:*
>  • signature.asc
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

      reply	other threads:[~2025-12-24 16:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19  0:11 [FFmpeg-devel] " LP via ffmpeg-devel
2025-12-22  2:53 ` [FFmpeg-devel] " Michael Niedermayer via ffmpeg-devel
2025-12-22  9:18   ` Leslie P. Polzer via ffmpeg-devel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e0a8dcc-f982-4a2f-8ccc-257ecae3ea76@app.fastmail.com \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=michael@niedermayer.cc \
    --cc=polzer.google@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git