From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 127174F439 for ; Mon, 16 Jun 2025 23:05:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4672268C927; Tue, 17 Jun 2025 02:05:37 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0413168C58A for ; Tue, 17 Jun 2025 02:05:31 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 4A215EB5A6 for ; Tue, 17 Jun 2025 01:02:37 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vd6cjbFTjM3g for ; Tue, 17 Jun 2025 01:02:35 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id AB9A4EB58E for ; Tue, 17 Jun 2025 01:02:35 +0200 (CEST) Date: Tue, 17 Jun 2025 01:02:35 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <6df2a011-1b17-fe5d-b7b6-ef0ba796f16b@passwd.hu> References: <20250616224404.16142-1-cus@passwd.hu> <20250616224404.16142-4-cus@passwd.hu> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 4/7] avfilter/avfilter: simplify processing sinks without activate callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 17 Jun 2025, Andreas Rheinhardt wrote: > Marton Balint: >> Sinks without an activate callback (nullsink, anullsink) could cause >> AVERROR(EAGAIN)-s in avfilter_graph_request_oldest() even when all the filter >> graphs inputs were in EOF state. >> >> Fixes ticket #11624. >> Fixes ticket #10988. >> Fixes ticket #10990. >> >> Signed-off-by: Marton Balint >> --- >> libavfilter/avfiltergraph.c | 38 ++++++++++++++++++------------------- >> 1 file changed, 18 insertions(+), 20 deletions(-) >> >> diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c >> index 2d6036df74..6f9f46f1ea 100644 >> --- a/libavfilter/avfiltergraph.c >> +++ b/libavfilter/avfiltergraph.c >> @@ -1423,12 +1423,26 @@ void ff_avfilter_graph_update_heap(AVFilterGraph *graph, FilterLinkInternal *li) >> heap_bubble_down(graphi, li, li->age_index); >> } >> >> +static int process_legacy_sink_output(FilterLinkInternal *oldesti) > > Why is considered legacy (instead of being just a different API)? > The documentation calls it legacy: doc/filtering_design: "The design using filter_frame() and request_frame() is legacy, but it is suitable for filters that have a single input and process one frame at a time." avfilter/avfilter.c: "In order to activate a filter implementing the legacy filter_frame() and request_frame() methods, perform the first possible of the following actions:" But if you have another name in mind for this, I can change it. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".