[FFmpeg-devel] [PATCH] avformat/codec2: remove surplus include 'memory.h' statement

[FFmpeg-devel] [PATCH] avformat/codec2: remove surplus include 'memory.h' statement

[Peter Ross]

[-- Attachment #1.1: Type: text/plain, Size: 651 bytes --]

on glibc memory.h drags in string.h, but codec2 does not use any
str* or mem* functions. additionally, memory.h is not part of the
C99 or POSIX standards.
---
 libavformat/codec2.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavformat/codec2.c b/libavformat/codec2.c
index cd0521299c..400c5acbdb 100644
--- a/libavformat/codec2.c
+++ b/libavformat/codec2.c
@@ -21,7 +21,6 @@
 
 #include "config_components.h"
 
-#include <memory.h>
 #include "libavcodec/codec2utils.h"
 #include "libavutil/channel_layout.h"
 #include "libavutil/intreadwrite.h"
-- 
2.35.1

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/codec2: remove surplus include 'memory.h' statement

[Andreas Rheinhardt]

Peter Ross:
> on glibc memory.h drags in string.h, but codec2 does not use any
> str* or mem* functions. additionally, memory.h is not part of the
> C99 or POSIX standards.
> ---
>  libavformat/codec2.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libavformat/codec2.c b/libavformat/codec2.c
> index cd0521299c..400c5acbdb 100644
> --- a/libavformat/codec2.c
> +++ b/libavformat/codec2.c
> @@ -21,7 +21,6 @@
>  
>  #include "config_components.h"
>  
> -#include <memory.h>
>  #include "libavcodec/codec2utils.h"
>  #include "libavutil/channel_layout.h"
>  #include "libavutil/intreadwrite.h"
> 

LGTM.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/codec2: remove surplus include 'memory.h' statement

[Tomas Härdin]

ons 2022-03-23 klockan 16:26 +1100 skrev Peter Ross:
> on glibc memory.h drags in string.h, but codec2 does not use any
> str* or mem* functions. additionally, memory.h is not part of the
> C99 or POSIX standards.
> ---
>  libavformat/codec2.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libavformat/codec2.c b/libavformat/codec2.c
> index cd0521299c..400c5acbdb 100644
> --- a/libavformat/codec2.c
> +++ b/libavformat/codec2.c
> @@ -21,7 +21,6 @@
>  
>  #include "config_components.h"
>  
> -#include <memory.h>
>  #include "libavcodec/codec2utils.h"
>  #include "libavutil/channel_layout.h"
>  #include "libavutil/intreadwrite.h"

Looks fine

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/codec2: remove surplus include 'memory.h' statement

[Marton Balint]

On Thu, 24 Mar 2022, Tomas Härdin wrote:

> ons 2022-03-23 klockan 16:26 +1100 skrev Peter Ross:
>> on glibc memory.h drags in string.h, but codec2 does not use any
>> str* or mem* functions. additionally, memory.h is not part of the
>> C99 or POSIX standards.
>> ---
>>  libavformat/codec2.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/libavformat/codec2.c b/libavformat/codec2.c
>> index cd0521299c..400c5acbdb 100644
>> --- a/libavformat/codec2.c
>> +++ b/libavformat/codec2.c
>> @@ -21,7 +21,6 @@
>>  
>>  #include "config_components.h"
>>  
>> -#include <memory.h>
>>  #include "libavcodec/codec2utils.h"
>>  #include "libavutil/channel_layout.h"
>>  #include "libavutil/intreadwrite.h"
>
> Looks fine

Thanks, applied.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".