From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EF82148DAA for ; Fri, 26 Apr 2024 12:56:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D6FDA68D41A; Fri, 26 Apr 2024 15:56:53 +0300 (EEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 29DDE68D17F for ; Fri, 26 Apr 2024 15:56:47 +0300 (EEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6ed2170d89fso2224406b3a.1 for ; Fri, 26 Apr 2024 05:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714136204; x=1714741004; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=vVlTZUk0OolNr1r7r28gHaqDduZpAD7s7J0sBF50XzY=; b=Yf3XbA/mxFOh92FDT0ZprFUxytrZukb3k0LhMB7+DY7r6iHrJUpXe9l1TOcovfv+AZ R86SGgaNexvDSX7QV7pvbMU5BmzuKWdMkcjEdBTVAFzDwNgJ1It8xlN0Qq0VKMQSGJQ9 cW3LxZ69vjlO3RCRW+TPJZ/degXIXwAHMzRFGvpqh38mBB5bvDDo7Z5e/+/HEPUqy+LQ jywPzArgfrYfCE8qizs5xv0OHcOdX2DhFsCwoz1kTb5ozqR+pKkEf+HqPMrP7H9K1n5G ZrhctMI53QlpwQI7Q/Y3VOpd7qMnbANeQpW/g2VO+EeYTBFB+8Ionl1mVASKU4vGw0ar VVQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714136204; x=1714741004; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vVlTZUk0OolNr1r7r28gHaqDduZpAD7s7J0sBF50XzY=; b=JIzD6a5vMxTZD9U8wl7OkaX2B+eqnCA9JzdXdh1sSkWfANcFga0oRLkAubJjeYvexo YOLckmsGNHRg1pBlD70gqq3MMWZyfsqzZaEafyfS/HDYLphanths084feOXPeY8aXXsk yr6XSFnKWk+EEtuqPTPyYoK0xuQ3L4mmMFZtVRnDtmALfNnj5ClZiob7hJ5uR5rsqLgW DFZscVBbeI8YtUi/jnWaKs+X7A/TTqwZX7FGadXEloKxZepn2HLYIisWzwydwACrYf25 t4pLHrNbhAGk51X0lO4PcfFrZ+oVjlQbBnandxFXtLTDIO80xuI1ZqclkKW+meMrTrSl 1M/Q== X-Gm-Message-State: AOJu0YxAFOQu4zOEoDD7ILhW1WdojHbSJwFvObY21kO6obUrkORAfdN8 L97rYlVkr76uG7HpWinKBEsMTMpTn7iG6r795FLZ8tLb/+GMWxVdOxFHaw== X-Google-Smtp-Source: AGHT+IH2lWeae250slBvYMmHEnHvaYqEaxuIuDsjXDqnWJky6gWiB+Qctkzh+lHyRcmEtdLr6RD22A== X-Received: by 2002:a05:6a21:3a93:b0:1ad:7e68:570c with SMTP id zv19-20020a056a213a9300b001ad7e68570cmr4243644pzb.4.1714136203922; Fri, 26 Apr 2024 05:56:43 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id fn10-20020a056a002fca00b006e72c8ece23sm14737051pfb.191.2024.04.26.05.56.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 05:56:43 -0700 (PDT) Message-ID: <6dc7077f-709b-4e5f-bffe-8c7c5de60dd1@gmail.com> Date: Fri, 26 Apr 2024 09:56:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240426030839.3001504-1-michael@niedermayer.cc> <20240426030839.3001504-4-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20240426030839.3001504-4-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 4/6] avformat/iamfdec: Files without streams cannot have packets X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/26/2024 12:08 AM, Michael Niedermayer wrote: > Fixes: Assertion pkt->stream_index < (unsigned)s->nb_streams && "Invalid stream index.\n" failed at libavformat/demux.c:572 > Fixes: 67890/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-5166340789829632.fuzz > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/iamfdec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/iamfdec.c b/libavformat/iamfdec.c > index e34d13e74c5..67ff7e8f01a 100644 > --- a/libavformat/iamfdec.c > +++ b/libavformat/iamfdec.c > @@ -162,6 +162,9 @@ static int iamf_read_packet(AVFormatContext *s, AVPacket *pkt) > IAMFDemuxContext *const c = s->priv_data; > int ret; > > + if (!s->nb_streams) > + return AVERROR_EOF; > + > ret = ff_iamf_read_packet(s, c, s->pb, INT_MAX, pkt); > if (ret < 0) > return ret; This should be checked in iamf_read_header() instead, after the nb_audio_elements loop that would add streams, and return INVALIDDATA if there's none. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".