From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id E5DAB4C7CA
for <ffmpegdev@gitmailbox.com>; Wed, 9 Apr 2025 14:28:12 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE39C68B9E4;
Wed, 9 Apr 2025 17:28:07 +0300 (EEST)
Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7339468B672
for <ffmpeg-devel@ffmpeg.org>; Wed, 9 Apr 2025 17:28:01 +0300 (EEST)
Received: from smtp102.mailbox.org (smtp102.mailbox.org
[IPv6:2001:67c:2050:b231:465::102])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4ZXlfQ2hx1z9sW7
for <ffmpeg-devel@ffmpeg.org>; Wed, 9 Apr 2025 16:27:58 +0200 (CEST)
Message-ID: <6d9414cc-bee2-45c4-a2a9-56ad9453dbea@gyani.pro>
Date: Wed, 9 Apr 2025 19:58:06 +0530
MIME-Version: 1.0
To: ffmpeg-devel@ffmpeg.org
References: <pull.59.v7.ffstaging.FFmpeg.1744178102.ffmpegagent@gmail.com>
<pull.59.v8.ffstaging.FFmpeg.1744190716.ffmpegagent@gmail.com>
<527cf5fa56e1bbb4d01ad40096851491e1cdcd5f.1744190716.git.ffmpegagent@gmail.com>
Content-Language: en-US
From: Gyan Doshi <ffmpeg@gyani.pro>
In-Reply-To: <527cf5fa56e1bbb4d01ad40096851491e1cdcd5f.1744190716.git.ffmpegagent@gmail.com>
X-Rspamd-Queue-Id: 4ZXlfQ2hx1z9sW7
Subject: Re: [FFmpeg-devel] [PATCH v8 2/3] fftools: add memaddress log flag
and disable printing addresses by default
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/6d9414cc-bee2-45c4-a2a9-56ad9453dbea@gyani.pro/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On 2025-04-09 02:55 pm, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
>
> This commit adds the memaddress log flag.
> When specifying this flag at the command line, context prefixes will
> be printed with memory addresses like in earlier ffmpeg versions.
>
> Example with memaddresses flag:
>
> [hevc @ 0000018e72a89cc0] .....
>
> without (new behavior):
>
> [hevc] .....
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
> fftools/ffmpeg.c | 2 +-
> fftools/ffplay.c | 2 +-
> fftools/ffprobe.c | 2 +-
> fftools/opt_common.c | 6 ++++++
> 4 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index dc321fb4a2..72887d6c5e 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -954,7 +954,7 @@ int main(int argc, char **argv)
>
> setvbuf(stderr,NULL,_IONBF,0); /* win32 runtime needs this */
>
> - av_log_set_flags(AV_LOG_SKIP_REPEATED);
> + av_log_set_flags(AV_LOG_SKIP_REPEATED | AV_LOG_NO_PRINT_MEMADDRESS);
> parse_loglevel(argc, argv, options);
>
> #if CONFIG_AVDEVICE
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index 2a572fc3aa..9bd1fc2f22 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -3761,7 +3761,7 @@ int main(int argc, char **argv)
>
> init_dynload();
>
> - av_log_set_flags(AV_LOG_SKIP_REPEATED);
> + av_log_set_flags(AV_LOG_SKIP_REPEATED | AV_LOG_NO_PRINT_MEMADDRESS);
> parse_loglevel(argc, argv, options);
>
> /* register all codecs, demux and protocols */
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index abbd1dcf36..106435b827 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -4672,7 +4672,7 @@ int main(int argc, char **argv)
>
> init_dynload();
>
> - av_log_set_flags(AV_LOG_SKIP_REPEATED);
> + av_log_set_flags(AV_LOG_SKIP_REPEATED | AV_LOG_NO_PRINT_MEMADDRESS);
>
> options = real_options;
> parse_loglevel(argc, argv, options);
> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> index 2ac3fd4fb3..73a591acd8 100644
> --- a/fftools/opt_common.c
> +++ b/fftools/opt_common.c
> @@ -1304,6 +1304,12 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg)
> } else {
> flags |= AV_LOG_PRINT_DATETIME;
> }
> + } else if (av_strstart(token, "memaddress", &arg)) {
Too verbose a label. How about just 'mem'?
Regards,
Gyan
> + if (cmd == '-') {
> + flags |= AV_LOG_NO_PRINT_MEMADDRESS;
> + } else {
> + flags &= ~AV_LOG_NO_PRINT_MEMADDRESS;
> + }
> } else {
> break;
> }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".