From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8DAF14C3E9 for ; Fri, 26 Jul 2024 12:20:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EF8ED68D6C8; Fri, 26 Jul 2024 15:20:51 +0300 (EEST) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0487468D45D for ; Fri, 26 Jul 2024 15:20:46 +0300 (EEST) Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7093efbade6so37445a34.2 for ; Fri, 26 Jul 2024 05:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721996444; x=1722601244; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=5tal22n0RqYSUapCNfZcWssCHIleCdnvNKtVrqgzu5Y=; b=jjp+KQUxzpQdb5tEDlNyC7xcxEUvpxph1gqPs+efApyEg7EfjsLr6Gg8GyteFndA4J G8AliYODZb61LmcD3DBH3B0RV3XFx9sFnaQt0IYydn6XUGFMiejAYGLQJlIzuOgOKfOl RpxvpGu8fvJi6v2qSczvsrQssboVhOXvoGIdfJjVuDMPlc2z8/JK/D+A7E9VWSAiegET wbXaLwFkN3NRDr7x2c5vgy4BObD7fU3WdV0vj5Ln2bxAy7B5yDstZs+W6bi0YxnbQH30 +qbeDgN4eioSMzlaqDRCC1OlHRbYxBPNU1HAMdY2cMRByaDpeZZrtonRzZPtqio2wQR3 UpuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721996444; x=1722601244; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5tal22n0RqYSUapCNfZcWssCHIleCdnvNKtVrqgzu5Y=; b=Wu/JXqrWkquTQ2ZfYqbn7zclmpnJ6XHjTBqFxx8oyJqZmY3kuByudHuZ4horMRx/nd McuTys/a9YIqcKBlw6SGzLd1YE0sjm0gApPqnsbbt7qsJCdTp3UI+M3gnsc2kJECiz5h KCCS5Nr80BM3vq1zledDUcm4105/T8V/vRrFSbhlX7qr1jKPSjaq5PY7+1S3NHBVlQIR t0wTA34LffqwOvr+e3xoAXTi8iX8g3v9feIq7h6qM/cQcTmVn4bgrW6yaaoNICpH8Axe tx6klio9GAM42MZtA3wwz9QQH5mi7VG7HdkFQrWYThfDZN9IVeiq52t7F7sAlOns/wdh zjwg== X-Gm-Message-State: AOJu0YxciNgdCzyGGIQDjfqUMIhSoO5vW0J7NRi1v/6AC235k8/8aUxj NmTrYpAjAKDLIjUBmE2VGubs1g60WwMj0EInZ+FqDM4CIv5kYOEikav+5A== X-Google-Smtp-Source: AGHT+IHaJG+ugK0yZrWr6SpYFxwkK9RKroPnLA+4nEBzCvKd3173keSDgi+kl/629WXJkDplWVPbLA== X-Received: by 2002:a05:6871:3311:b0:260:f495:5492 with SMTP id 586e51a60fabf-264a1041641mr6391886fac.39.1721996443614; Fri, 26 Jul 2024 05:20:43 -0700 (PDT) Received: from [192.168.0.12] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead712101sm2581570b3a.69.2024.07.26.05.20.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 05:20:43 -0700 (PDT) Message-ID: <6d919c4c-d89f-4c62-ab29-4a3e15066d3c@gmail.com> Date: Fri, 26 Jul 2024 09:21:21 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240721225350.298-1-jamrial@gmail.com> <20240721225350.298-4-jamrial@gmail.com> <172198051442.21344.13086861882221487165@lain.khirnov.net> <835ecedf-129b-4600-a1b9-66083e969a1c@gmail.com> <172199637808.21344.1103797707765183066@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <172199637808.21344.1103797707765183066@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 4/4 v2] avcodec/h264dec: add support for LCEVC enhancement X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/26/2024 9:19 AM, Anton Khirnov wrote: > Quoting James Almer (2024-07-26 14:10:46) >> On 7/26/2024 4:55 AM, Anton Khirnov wrote: >>> Quoting James Almer (2024-07-22 00:53:50) >>>> Signed-off-by: James Almer >>>> --- >>>> configure | 2 +- >>>> libavcodec/avcodec.h | 5 +++++ >>>> libavcodec/h264_picture.c | 1 + >>>> libavcodec/h264_slice.c | 15 ++++++++++++++ >>>> libavcodec/h264dec.c | 41 ++++++++++++++++++++++++++++++++++++--- >>>> libavcodec/h264dec.h | 3 +++ >>>> 6 files changed, 63 insertions(+), 4 deletions(-) >>> >>> Does this need to be integrated into individual decoders? Can't the >>> generic path apply it based on the presence of AV_FRAME_DATA_LCEVC sdide >>> data and AV_CODEC_EXPORT_DATA_ENHANCEMENTS being set? >> >> Individual decoders still need to be aware of lcevc metadata being >> present to do things like allocating the output frame, because afaik i >> can't call get_buffer2() from the main/user thread. So is it worth >> moving things to the generic code when DR1 decoders will still need >> extra considerations? > > Can it not be handled in ff_get_buffer()? And even if not - there'd > still be a lot less code that needs to be duplicated across every > decoder supporting this. I'll try that. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".