Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenccenc: add support for CENC AV1 encryption

[James Almer <jamrial@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1005 bytes --]

On 3/21/2025 12:52 AM, Andreas Rheinhardt wrote:
> James Almer:
>> On 3/20/2025 11:55 PM, Andreas Rheinhardt wrote:
>>> Duplicating .o files is meant for small stuff, not for gigantic things
>>> like cbs_av1.o (whose .text is 86519B here).
>>
>> This feature requires complete frame and tile group parsing, which in
>> turn requires complete sequence header parsing. The amount of work to
>> get that much parsing code in lavf will be huge for little (if any) gain
>> in total object size.
>>
> 
> a) Completely wrong: Approximately half of cbs_av1.o is code for writing
> which lavf doesn't use.
> b) Even the reading code is littered with CBS's tracing stuff which lavf
> won't use.
> c) There is also parsing stuff that won't be used.

I could make it so i selectively enable portions of the module.

> d) Btw: Your patch shouldn't even compile in shared builds if the other
> CBS modules are enabled as your lavf/cbs.o will try to pull in the other
> ff_cbs_type_*.

Ditto.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".