From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BE0E34A8FD for ; Thu, 23 May 2024 11:55:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5657668D392; Thu, 23 May 2024 14:55:11 +0300 (EEST) Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACE9468D261 for ; Thu, 23 May 2024 14:55:04 +0300 (EEST) Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5b296194ac1so4390794eaf.2 for ; Thu, 23 May 2024 04:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716465301; x=1717070101; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=I6TpzkP7qCn9Sl+LL6mMfHeBW6Z/UR1ZIgjIG0oShHw=; b=Fb0kPkUKjW0J2ngi8YxYKfHd6wzPUGrSKzAIQ8yK0FOia0uPX4wePWHIHFNIppdD1x F3imHVCcMPh6jQAMM8g0Pwpme+uTew1hedHrD4B0acsWj5eb1VzvXzaJjgRbzXXQES7S kO0IQ97EQbs5RnVPnXNbamAE9vY64tHqO/VV36X4x7FoAkqx17Rxeaiw3Lbc9+oPrlmU kZn2Oku6sAuan3Kh7u6rUgsZPzWC0/agug9f0rO5SUZpqzBiDdC7/Q5mFLdH2FIF+Cxz o3MCurCtWHmcN1WK16za0baPYvmwN2/+/093rBc5gPPv3ov/qgcpZcJnnwj5vjX29tW1 q4uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716465301; x=1717070101; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I6TpzkP7qCn9Sl+LL6mMfHeBW6Z/UR1ZIgjIG0oShHw=; b=DgP6iBsyAoUW0igwnlL9C5Ie+rrxxj7Q+90tGORxMhhlrWtaro41+pCb8yO7feeU2T o+wU82Y3aFp/0XhR+djk6pgI3qjkD0Xt79Gh++K5/I3P4bEPFCOa/he+3hjJyByDJ/RC hYl/X99BhJsnXWXOnZV/9eBCabGpIoSkEjz2yCPVs0LGsPP+HlKncSUfNmurKbIEWTB7 jpV+aKU1Zeau9Xaxbo92g7Pk1mY9K01OSrL1CMxfmO6e2kIMTl8I98W+vVyZLnKoxot3 y+9OF2OjI172ExR80WL9BeqyzFYD+R5IYABFqExx3Ylq77BOcZfOoZ8LzI+iGPArYV3l soAA== X-Gm-Message-State: AOJu0YxAbEvYGjDYLuortT3t2zV/xNRMCm/WKku3CDehPVjibSVK9U9C h836vQSoNc7q+AU6C3ftI2mpoCg/+YtUJ9WTVp8LOCg2w3lt4rbzmrsBxg== X-Google-Smtp-Source: AGHT+IESCCb7Z83yEWIYUW2MH9orXtsM4+UFsvH/250fLn2UK5GAzHeYwsybnBPeOu1FP1kP0jko8A== X-Received: by 2002:a05:6358:c697:b0:18e:b11b:e770 with SMTP id e5c5f4694b2df-197915c6fbcmr327242855d.0.1716465301128; Thu, 23 May 2024 04:55:01 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-634103f80absm23900960a12.65.2024.05.23.04.54.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 May 2024 04:55:00 -0700 (PDT) Message-ID: <6d40cc5b-be22-4f20-a1d4-80fa169dc96e@gmail.com> Date: Thu, 23 May 2024 08:55:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240515010829.2667-1-jamrial@gmail.com> <171644831506.22242.11088844724944878786@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <171644831506.22242.11088844724944878786@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: add a helper function to get the ambisonic order of a layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/23/2024 4:11 AM, Anton Khirnov wrote: > Quoting James Almer (2024-05-15 03:08:28) >> Signed-off-by: James Almer >> --- >> libavutil/channel_layout.c | 17 ++++++++--------- >> libavutil/channel_layout.h | 10 ++++++++++ >> 2 files changed, 18 insertions(+), 9 deletions(-) >> >> diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c >> index fd6718e0e7..e213f68666 100644 >> --- a/libavutil/channel_layout.c >> +++ b/libavutil/channel_layout.c >> @@ -473,15 +473,14 @@ static int has_channel_names(const AVChannelLayout *channel_layout) >> return 0; >> } >> >> -/** >> - * If the layout is n-th order standard-order ambisonic, with optional >> - * extra non-diegetic channels at the end, return the order. >> - * Return a negative error code otherwise. >> - */ >> -static int ambisonic_order(const AVChannelLayout *channel_layout) >> +int av_channel_layout_get_ambisonic_order(const AVChannelLayout *channel_layout) > > IMO the _get_ in the name is just making it unnecessarily longer. Ok, will remove it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".