Re: [FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: add a helper function to get the ambisonic order of a layout

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: add a helper function to get the ambisonic order of a layout
Date: Thu, 23 May 2024 08:55:03 -0300
Message-ID: <6d40cc5b-be22-4f20-a1d4-80fa169dc96e@gmail.com> (raw)
In-Reply-To: <171644831506.22242.11088844724944878786@lain.khirnov.net>

On 5/23/2024 4:11 AM, Anton Khirnov wrote:
> Quoting James Almer (2024-05-15 03:08:28)
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>   libavutil/channel_layout.c | 17 ++++++++---------
>>   libavutil/channel_layout.h | 10 ++++++++++
>>   2 files changed, 18 insertions(+), 9 deletions(-)
>>
>> diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c
>> index fd6718e0e7..e213f68666 100644
>> --- a/libavutil/channel_layout.c
>> +++ b/libavutil/channel_layout.c
>> @@ -473,15 +473,14 @@ static int has_channel_names(const AVChannelLayout *channel_layout)
>>       return 0;
>>   }
>>   
>> -/**
>> - * If the layout is n-th order standard-order ambisonic, with optional
>> - * extra non-diegetic channels at the end, return the order.
>> - * Return a negative error code otherwise.
>> - */
>> -static int ambisonic_order(const AVChannelLayout *channel_layout)
>> +int av_channel_layout_get_ambisonic_order(const AVChannelLayout *channel_layout)
> 
> IMO the _get_ in the name is just making it unnecessarily longer.

Ok, will remove it.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".