From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BAC1A42580 for ; Wed, 5 Jan 2022 03:38:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 29279680090; Wed, 5 Jan 2022 05:38:22 +0200 (EET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 719526880FA for ; Wed, 5 Jan 2022 05:38:15 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641353900; x=1672889900; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Xz5uYgHxv3m2ZkZsgU+8VKTp1dbP1soApc8t7eX5M88=; b=j9GqWIQnCtR2LByasBtdAeWuOdakkuDdrU7MPP/M06EgiMjPtnxW/ZpM RbzI718sXNQw/AF4btrcaqNwZJ2PNp7LXWSJ8BUxLKCjYzgmrMpiy8SDU soOYK01MEQqK4rSsRzrsO2JqE5plqA8ieHQ97nTH3iXSfA9wOdIfNDc1r oKHZlghVhZwR2JdSLM9PUtgZ4oyv1iqrshmGCRXYb4ksTytkGmdpYpRft sibS+ET0clOHJPzX4nqIgUDJihQtV7TDqSkTFGTc0xzcnGIl+VR0Crjnv JsfbkWYxQpvl0PjLVULvc7ttJXAYYzfrcZkWGIEkmdD4VB6fbf+lvUJtQ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10217"; a="239900029" X-IronPort-AV: E=Sophos;i="5.88,262,1635231600"; d="scan'208";a="239900029" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2022 19:38:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,262,1635231600"; d="scan'208";a="667950154" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 04 Jan 2022 19:38:13 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 4 Jan 2022 19:38:13 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 4 Jan 2022 19:38:13 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 4 Jan 2022 19:38:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GTWLCKQG6N70Y61P68+JtcA2defi0fZbsz3eIRb7k6pw5DRDDomV6zPe+nUCQ1jCQVz343rBSNGrnuWD0fAT5qbPHmNdAUXuyJxAmQfViao8RM5MIoIu17pTn8xs+IdoXHzmuuwzboVHXaDVp1jX48G5Z09NzxqGNpZvciuQsXLc+pzaWEB6fx0GOQh+Bo3jBNB3ysNMc4uddJTWgL7YZHKGgqkCQV/LcStpWwSEjZxacrS4TA6aEi0ZUPMCvqtWIZQS5+4sKu/YSU7UE8juyWJivlHXxRhGApkBP435o91EXn29sRw67Drwu0WLa9SuokOMoDSpdqE33ld3xP5fnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xz5uYgHxv3m2ZkZsgU+8VKTp1dbP1soApc8t7eX5M88=; b=TPQraTcpngroKflpZKW+4TK4PMsabI8Lw1PZEwFQBkO+nj9hK72Drs80UZwpJbrUy1cxfbod2TxafqHR8z6OX/xoKlKGbifAr/5VJXdYgEZP3QWWDyZABWRxZ+ONAeLkdC1HdljvDfOCCvEdRKk3pcYO2YQdcT1TNQDYivO7CT6R0VC/n25jHpi156XcEAtjV3kh/lsTsbcHfidlS3r49R8ltvx0BGzWuzZvjQWT8BsrtaGREN8V5Uqy/ClBuTwyYG6IM0XkCo/aKuAO9QQFJJMhFt2urYJlLgakD98dKLtv/MlNzdCbb15bAiMHnd9ywORKMAth/glEXr3tmKghHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN6PR11MB1299.namprd11.prod.outlook.com (2603:10b6:404:49::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Wed, 5 Jan 2022 03:38:07 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%4]) with mapi id 15.20.4844.016; Wed, 5 Jan 2022 03:38:07 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions Thread-Index: AQHX4hsioJyM1GLeREaoFRgSTTytDawV/YDXgAAxacqAAASjAIAqE1oAgAWS44CADigVgIAABTeA Date: Wed, 5 Jan 2022 03:38:06 +0000 Message-ID: <6cc00dffb915619af857283b9fb503e7aaeeb603.camel@intel.com> References: <163785839519.25323.16303122737288435026@lain.red.khirnov.net> <163794332023.25323.7446601680884381987@lain.red.khirnov.net> <163795393240.7822.9483345286843818669@lain.red.khirnov.net> <50841f8a73c902d3fca896b1eda923d082b27383.camel@intel.com> <6c1f517dad96d2d6075cb69a30e1a50aefd3feb9.camel@intel.com> <1379ae9c-d8f9-7e32-260f-eff79ac1cfd7@gmail.com> In-Reply-To: <1379ae9c-d8f9-7e32-260f-eff79ac1cfd7@gmail.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4fbb3e67-c0f7-4e09-d6a2-08d9cffcc998 x-ms-traffictypediagnostic: BN6PR11MB1299:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QStUQkdBNEvTEKV93wHiPAXV5vPsvvCQYCLU4X3xL2IMujBJ8zqHG5oQp2NUp01SReIgRUhXt3gbeWIv/tBx3AoO4iooQEQ2Vn9vii7RukS0+k+bZBqsv06IYthKUMaURo81XnMG/jNZ5STArE5v9wgubf+H8zoQ1H/X4jLwj9Us34g87TuAbXaakSO79BoHQB7LAkOH8US6P+ZZfgn4I1IrhtHjycGLo1KcVOKzfDIv3u7aAbEFZyn/qJ/yGAmzrKTC6FGlwdpPRzuTFyc2yK7AioV4Wn788Y2OCJlbTz42fFdKXwKS03aLuDd8yiaHBEm1cIFQi2M9lSbmiJHlxPEkWWMl4K3jYEdzn3cAVa3+JCZxQazikGuzsSGRIHF13/B4dmJOsmtTmrbiMnbJkO+dMY9MKj45T8Y9T0KpptHfi8yixpg2nc8BwImkdGC5UguMh568qi9WwK7JIdy8i8s/daPwWWFz63/7KtyZ2+bktCN+qVPK5AX7mbJCqanUD5CRwB9EP5uWZgYEm/HFX0hp9weFJ5I6iF+YWXNhwzPSPHsfcckX/bA1YMBLShfx4EvbLrUqeD4Md2mL4EFZfd88l90EXMDDZoIe+3J+gAPqf8KXqqYS6Qd743dY/ywc/g6gdUk5Tnd2BFTodTVHWNEz4MUus1siumIgQdToImEYXDr3R80TdIfifWYsCwK9vSthYeS54wvwMns4J2IxQp6NIPUG2OoUgk5cNJ0S+/EdMbSh7VMAHcy3A8iTKaQBZPxhCwwnE4itLXXOne4eHPtohZhBdNy3Ip3bMCDltPfBpyci+vxCWWlXPpswD7yF x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(8676002)(53546011)(966005)(6506007)(508600001)(66476007)(2906002)(66556008)(86362001)(76116006)(66946007)(66446008)(64756008)(83380400001)(82960400001)(91956017)(38070700005)(122000001)(2616005)(71200400001)(6486002)(316002)(6916009)(36756003)(6512007)(5660300002)(186003)(38100700002)(26005)(4001150100001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aVBPWGFUZ0JHMnR3WjNham5TbGJIb2psMksyWlB6bUFPZkZjLzNqOHNSSUlX?= =?utf-8?B?cit0aGdQUUNwdHpXL2RNU0pXR0VpdGVpUVkwN0psNjRIcHFHTXN6UXJTRnVD?= =?utf-8?B?YVJOYk1kODNESy9JcHhnSGZZeDNTZ2I3YVBsZTEzMkdqZjdKNko4TWlvem9L?= =?utf-8?B?V2FCNWpuQ29ZWHR0ZE5ETGNVTFNwZjlYbkdITzh3aHpSbkp6UkZrTlBiR2Fk?= =?utf-8?B?amtML25TSmlqV3FEL2FPVndnVWZaYkhOVFFaZkVDbEhiOU8reVhZOVBRelp3?= =?utf-8?B?TWdWMVppaElobjMySk9uaTJnMkY2aDVIVHU3VVZ1TzR1cmpVVnE1aUg1TSt5?= =?utf-8?B?Tnc2T0NHWTViYXFJcHFoYkxyeWJoNEtzaDZHVlZZaFNVZlFSUUdybzdrYnVl?= =?utf-8?B?a1JRTEJnM0p6Wkpxd0JVMnc5cVlhNS8xQkhHWmRXWWc1T0hDN3U1a2RsVXBl?= =?utf-8?B?dzlwcnMwMjVHS1V1SlRlNm9yUlBXajVqUDhvZkxDL0NiSml1c3ZNRmlwQndG?= =?utf-8?B?QkxpREpBRUV3YytORWNPMmUvVjJTOHUvYmtBQlN6SEVVd3FJOFRCSFpub1g0?= =?utf-8?B?QVBhbVVCOWJVbVlBeHV0MGxxWkdLbWZZd3dyNFNIMEU3cmdTMGRsb01NWjE1?= =?utf-8?B?ZzFhTFhsQnZNOFhvUEYvTVhGWGRFbk1ENWcxeDJhYnlSRTdLZFAwQkJ5dGhR?= =?utf-8?B?SUhkeVJSY09vMzJuTnRCUzlpODB6OWlOV2ZzMHByeTVJVmJ3UFBZaDI3dXhX?= =?utf-8?B?d1BJQ0taVTdqUVh0NWRVZFpPemtnaWVRMXBXS0hPYjlDOTYraWFJUE5TUFBF?= =?utf-8?B?am85TGZzeUl2bTNDdTdMRmRCNUNCS08xVnZRekNxWmcrQzNUTHo5Rys4bHMx?= =?utf-8?B?dVptMkRoNjQ3ZzdEdW1xVXhGeFpXOFFYZFM5dFdIMmp3bzdtTFE5NDlZSkhV?= =?utf-8?B?bzVJb29kNldOTElaSXhzSWVTVENxL09DaW9IWGRNQ1U2QW9PY25abHAzSG9q?= =?utf-8?B?bHZtQ0laTVBvVmEraHlVV0RVY1NlaS9GODlaNEN4eUs0RFFoQi80cnJqaG5w?= =?utf-8?B?Y0cyb2EwNHdJZmR0aGNJVlgvQ084cExYWG5qZWxJcFRPTEtzaFl3ZUNTVzNU?= =?utf-8?B?RVY5RWhtcFZjaTFXdlRiam1BM0E3U0JSTVdiRkFER0VvQ3VXeGM1dTRSVk94?= =?utf-8?B?ZGVScUZYQUNzU0lpVHNQWUVOaUVod2Q2WWhIS2xLM0MwR3RGSUZ5NndjbTdM?= =?utf-8?B?eFlUVEExUHNtNHNPZ3JkQzhXVDVVcFFCWC9QNXROTC9IZTlrK3FDdTIvdW5J?= =?utf-8?B?b3FyWVN5aDdyRXprOTM4VG1vWGRVT0N0VjJHS1Y3MWR6ZU9nNWltaE93S3h3?= =?utf-8?B?b2xGTzlzUjU5KzN5Y1YySDhZUXRjK2p2SkhZa3pPWHhoK3QrUzhiL1l3OS8w?= =?utf-8?B?UUljKzY2MTIzV051eEQ5RXVvYnkyUkVrY0loQVFtd1BCUEtRSDdFekx5bDlR?= =?utf-8?B?U0tCK2d3S3A3MGk2My9nVktBTmYzRThtS1hiVEFLeEMzTGIwQlN4d0dkbzZ6?= =?utf-8?B?M2wzZFMxd21pWnhJcDNSUkM1YjE4MFRsdE5EdEVnTlB1b0Y5QjFUTkJnOTll?= =?utf-8?B?Y3FxTXFVYitBQ1YyQTJSZkI3czNjQWN2dVA0THN3Ky9ML0x6WVFyOUFBOVEv?= =?utf-8?B?M0dINjZKWDd4Y0RmM2dNSEsyS2hSTVkvc0U0RmlOOUtHczBzeFJxaUNtdGtW?= =?utf-8?B?UUdHdXFLQ1NZSGtoNXZleTY0TElQVVJkRlVXYjhLTDhycnliOHd1RHptLy8x?= =?utf-8?B?MUViZUNsV3lrdVAyMDRFVnRESEZhZ3ZWQUNwK2dnNFhYRU9PNGxuUDZOeDRX?= =?utf-8?B?MHRwdXlQNUVmSkpsMTIyb3hjR0lraEdNKy9jWkNWMmwyZDVYTW1kR1BxejZP?= =?utf-8?B?MDIxRlVQY0l3R1FDVjk3OUlwcFBTTUVveXdLWm9jYlVFRXcxM2JWakdnMEZ5?= =?utf-8?B?R1FZbmlXSzIrb0NESHRWZzF6TGZSWUJaMnRJdE04QTY2bUZYRW1oaHZXZG5w?= =?utf-8?B?djhtS3NKZGpFd2thRDlzNng5b00ydDUzYVdDLzROVkZEQjgzTCtsS2x2aU85?= =?utf-8?B?M0JocWpmdjZnckpkVzNBamRGem5aaEJBMzJvS0ZFeUh3ZEZoNGxIdXNJRHI2?= =?utf-8?Q?59RFdDwLVJ/NgeYCswtopYk=3D?= Content-ID: <49A1DE6A8B6A2C4898F795EB4AF9F5B5@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fbb3e67-c0f7-4e09-d6a2-08d9cffcc998 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2022 03:38:06.9643 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZSvVcz7EhACCMGXFxrpd35LWBB4H6rfC4Bh35oZ7UedLkMK95AvjPNvyVOQviP27VD/VZeI/ZgAuLpdGEErRpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1299 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-01-05 at 00:19 -0300, James Almer wrote: > > On 12/27/2021 12:08 AM, Xiang, Haihao wrote: > > On Thu, 2021-12-23 at 14:01 +0000, Xiang, Haihao wrote: > > > On Fri, 2021-11-26 at 19:29 +0000, Soft Works wrote: > > > > > -----Original Message----- > > > > > From: ffmpeg-devel On Behalf Of > > > > > Anton > > > > > Khirnov > > > > > Sent: Friday, November 26, 2021 8:12 PM > > > > > To: FFmpeg development discussions and patches < > > > > > ffmpeg-devel@ffmpeg.org> > > > > > Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When > > > > > deriving > > > > > a > > > > > hwdevice, search for existing device in both directions > > > > > > > > > > Quoting Soft Works (2021-11-26 19:43:58) > > > > > > Maybe I'm missing something, but hw device contexts are refcounted. > > > > > > What happens in hwdevice_ctx_free() is this: > > > > > > > > > > > > av_buffer_unref(&ctx->internal->source_device); > > > > > > > > > > IIUC this only happens after the parent device is freed. My concern is > > > > > the following situation: > > > > > - the caller creates a parent hwdevice > > > > > - the caller derives a child from it, which may acquire some > > > > > additional > > > > > resources beyond what the parent holds > > > > > - the caller unrefs all his references to the child, but the child > > > > > does > > > > > not get freed because the parent still holds a reference to it > > > > > > > > > > Since av_hwdevice_ctx_create_derived() has a flags parameter, we might > > > > > want to introduce a flag to control this behavior. > > > > > > > > I understand what you mean. I'm just not sure whether a practical case > > > > with such a requirement exists. Should that turn out to be required, > > > > such flag can be added at any time, IMO. > > > > > > > > > I agree we may add such flag later if required. May we merge this patch to > > > fix > > > the annoying derivation limitation if no other concern ? > > > > Any other comment for this patch version? I'll add the note pointed out by > > Lynne > > and push this patch if no objection. > > > > Thanks > > Haihao > > Why was this pushed? There were objections. I apologize that I missed the new discussion on ML, thought no objection since my email, so I pushed Softworks' patch as this patch really fixed some issues for me and others. I'll revert it and check the ML more carefully. Thanks Haihao > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".