From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: Re: [FFmpeg-devel] [DON'T MERGE PATCH 1/2] checkasm/sw_rgb: test rgb24 to yuv
Date: Mon, 3 Jun 2024 11:00:21 +0300 (EEST)
Message-ID: <6cba2db7-e0b1-9189-d9a2-4141cc2cb65d@martin.st> (raw)
In-Reply-To: <tencent_90E6136AF5D6E919AEA9254393048855B305@qq.com>
On Mon, 3 Jun 2024, Zhao Zhili wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
> I need help on the test. It succeed with the following patch on ARM64,
> but failed with x86. I'm not sure whether the issue is in the test, or
> hidden in x86 asm, and I don't know x86 asm.
Note that by default, the output of swscale can differ in rounding from
the reference C code. If the SWS_ACCURATE_RND flag is set, it shouldn't
differ, though.
So it makes sense to test twice, once with SWS_ACCURATE_RND set, doing a
bitexact test of the output, and once without it, allowing the values to
be off by one (or a few?).
See the existing test in checkasm/sw_scale.c for one example on doing
this.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-03 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 7:17 Zhao Zhili
2024-06-03 8:00 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cba2db7-e0b1-9189-d9a2-4141cc2cb65d@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=zhilizhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git