From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9A82B468F5 for ; Sat, 24 Jun 2023 12:26:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 20D3F68C049; Sat, 24 Jun 2023 15:26:23 +0300 (EEST) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 89AED68BFCE for ; Sat, 24 Jun 2023 15:26:17 +0300 (EEST) Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6b6da72d5e2so1435754a34.1 for ; Sat, 24 Jun 2023 05:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687609576; x=1690201576; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IWcf9exQCAdac8oHJhD2dDml16P5isC9eT75s3yK8Fk=; b=QrSD6a6H0WbeNadDTmXhHJ2iUddGaUDtlRNYYcJTBSDTxMQ505OCDZ8904GhVkivnm jCoemfCTExwQMz4LousnpA/WXE7ix29MS4y8i/swT5tv6fOcONUmH778fldqjfp49HVF DhFKGPX5i1aMgVbO+0JJsV5dyg6vvAF3708a2I+gRugGuGY5iP+m5N1B0E8wgwx9zJdy JJW1Ge3i/hjkfECuHtnauSKuObJO7jAOgGZvgy/S5D/M4LDMlOcenn+EamwCXNwPdMGN 4fMZtRybPBqLsnOoUNNN7ZKa6ZbahTlsgQOQ9e6YW4y4nXQv2ie0cWjbJkl3RV7dVr7m pZMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687609576; x=1690201576; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IWcf9exQCAdac8oHJhD2dDml16P5isC9eT75s3yK8Fk=; b=BVu6wPmXc9YEifMgDRb73i3gdpP1lfL0PJW+5dsQ/f1nZR8AuV8/P+q3wIH92n4l3d ANihKHGOtkbr20C4T2Za8wE6IXRDz7QWtTZ+Pf7BYoh7QMqcEY0lKESlyTu+x/OgXDnJ zI8XGsgYyo+izFnQ/HiVb2cAbZIak0y5g6D3k9cHke4WQ35hIbZ117MSR2vMPQhMN5ga hs7kGKtTYoZAYPaNdjKScZ0Xo+b0gzxgxdvDzwag6HnrrSAAbniy+a9120PkrPmdMFcF dOvK09H88ORwm6lUu8w2hB6tvjMSLjnynSeOd6lRurFIiqsSTRLzAKtXfI0YF2naBzua 5NNg== X-Gm-Message-State: AC+VfDx34N2lH5VYYVrA70edERrmuHfCpXHYFwzIYSIDnuM9dBKjQX9c 7JGZG+wv1SB0HgUnKen+wwud9AckM+4= X-Google-Smtp-Source: ACHHUZ6NBjSK0HBb6l+PvCTmB5tPzX7cwUtdFIPikiaG97NA3sI9PHy1qUvlvWeHuOEhqzGMnVAEuA== X-Received: by 2002:a05:6830:1e65:b0:6b7:2905:d702 with SMTP id m5-20020a0568301e6500b006b72905d702mr3877263otr.10.1687609575490; Sat, 24 Jun 2023 05:26:15 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id a23-20020a05683012d700b006aafe381a12sm791212otq.48.2023.06.24.05.26.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jun 2023 05:26:15 -0700 (PDT) Message-ID: <6c7beca3-db4b-be70-3073-01f6ed624c35@gmail.com> Date: Sat, 24 Jun 2023 09:26:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230624043853.12237-1-leo.izen@gmail.com> <20230624043853.12237-5-leo.izen@gmail.com> From: James Almer In-Reply-To: <20230624043853.12237-5-leo.izen@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v3 4/4] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/24/2023 1:38 AM, Leo Izen wrote: > Adds a fate test for the jpegxl_anim demuxer, that should allow testing > for true positives and false positives for animated jpegxl files. Note > that two of the test cases are not animated, in order to help sort out > false positives. > > Signed-off-by: > --- > tests/Makefile | 1 + > tests/fate/jxl.mak | 16 ++++++++++++++++ > tests/ref/fate/jxl-anim-demux-belgium | 6 ++++++ > tests/ref/fate/jxl-anim-demux-icos4d | 6 ++++++ > tests/ref/fate/jxl-anim-demux-lenna256 | 7 +++++++ > tests/ref/fate/jxl-anim-demux-newton | 6 ++++++ > 6 files changed, 42 insertions(+) > create mode 100644 tests/fate/jxl.mak > create mode 100644 tests/ref/fate/jxl-anim-demux-belgium > create mode 100644 tests/ref/fate/jxl-anim-demux-icos4d > create mode 100644 tests/ref/fate/jxl-anim-demux-lenna256 > create mode 100644 tests/ref/fate/jxl-anim-demux-newton > > diff --git a/tests/Makefile b/tests/Makefile > index e09f30a0fc..7b80762e81 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -201,6 +201,7 @@ include $(SRC_PATH)/tests/fate/image.mak > include $(SRC_PATH)/tests/fate/imf.mak > include $(SRC_PATH)/tests/fate/indeo.mak > include $(SRC_PATH)/tests/fate/jpeg2000.mak > +include $(SRC_PATH)/tests/fate/jxl.mak > include $(SRC_PATH)/tests/fate/libavcodec.mak > include $(SRC_PATH)/tests/fate/libavdevice.mak > include $(SRC_PATH)/tests/fate/libavformat.mak > diff --git a/tests/fate/jxl.mak b/tests/fate/jxl.mak > new file mode 100644 > index 0000000000..057d3be0e1 > --- /dev/null > +++ b/tests/fate/jxl.mak > @@ -0,0 +1,16 @@ > +# These two are animated JXL files > +FATE_JPEGXL_ANIM_DEMUX += fate-jxl-anim-demux-newton > +fate-jxl-anim-demux-newton: CMD = framecrc -i $(TARGET_SAMPLES)/jxl/newton.jxl -c copy > +FATE_JPEGXL_ANIM_DEMUX += fate-jxl-anim-demux-icos4d > +fate-jxl-anim-demux-icos4d: CMD = framecrc -i $(TARGET_SAMPLES)/jxl/icos4d.jxl -c copy > + > +# These two are not animated JXL. They are here to check false positives. > +FATE_JPEGXL_ANIM_DEMUX += fate-jxl-anim-demux-belgium > +fate-jxl-anim-demux-belgium: CMD = framecrc -i $(TARGET_SAMPLES)/jxl/belgium.jxl -c copy > +FATE_JPEGXL_ANIM_DEMUX += fate-jxl-anim-demux-lenna256 > +fate-jxl-anim-demux-lenna256: CMD = framecrc -i $(TARGET_SAMPLES)/jxl/lenna-256.jxl -c copy > + > +FATE_JPEGXL_ANIM_DEMUX += $(FATE_JPEGXL_ANIM_DEMUX-yes) > + > +FATE_SAMPLES_FFMPEG-$(call FRAMECRC, JPEGXL_ANIM) += $(FATE_JPEGXL_ANIM_DEMUX) > +fate-jxl-anim-demux: $(FATE_JPEGXL_ANIM_DEMUX) > diff --git a/tests/ref/fate/jxl-anim-demux-belgium b/tests/ref/fate/jxl-anim-demux-belgium > new file mode 100644 > index 0000000000..b2fe5035ac > --- /dev/null > +++ b/tests/ref/fate/jxl-anim-demux-belgium > @@ -0,0 +1,6 @@ > +#tb 0: 1/25 > +#media_type 0: video > +#codec_id 0: jpegxl > +#dimensions 0: 768x512 > +#sar 0: 0/1 > +0, 0, 0, 1, 32, 0xa2930a20 > diff --git a/tests/ref/fate/jxl-anim-demux-icos4d b/tests/ref/fate/jxl-anim-demux-icos4d > new file mode 100644 > index 0000000000..eff6ff1f1b > --- /dev/null > +++ b/tests/ref/fate/jxl-anim-demux-icos4d > @@ -0,0 +1,6 @@ > +#tb 0: 1/1000 > +#media_type 0: video > +#codec_id 0: jpegxl > +#dimensions 0: 48x48 > +#sar 0: 0/1 > +0, 0, 0, 0, 67898, 0x53b6516b > diff --git a/tests/ref/fate/jxl-anim-demux-lenna256 b/tests/ref/fate/jxl-anim-demux-lenna256 > new file mode 100644 > index 0000000000..0bd286a451 > --- /dev/null > +++ b/tests/ref/fate/jxl-anim-demux-lenna256 > @@ -0,0 +1,7 @@ > +#tb 0: 1/25 > +#media_type 0: video > +#codec_id 0: jpegxl > +#dimensions 0: 256x256 > +#sar 0: 0/1 > +0, 0, 0, 1, 4096, 0x2409e9e3 > +0, 1, 1, 1, 3992, 0x966dbfcb Why is this returning two frames when it's not an animation? And why the two animated files are returning only one frame? Do the latter have the animation bits in the header but still are a single frame? > diff --git a/tests/ref/fate/jxl-anim-demux-newton b/tests/ref/fate/jxl-anim-demux-newton > new file mode 100644 > index 0000000000..6fcb85c41e > --- /dev/null > +++ b/tests/ref/fate/jxl-anim-demux-newton > @@ -0,0 +1,6 @@ > +#tb 0: 1/1000 > +#media_type 0: video > +#codec_id 0: jpegxl > +#dimensions 0: 128x96 > +#sar 0: 0/1 > +0, 0, 0, 0, 43376, 0xb2296182 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".