From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1EAF540AEE for ; Mon, 27 Dec 2021 03:08:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 164CA68B06C; Mon, 27 Dec 2021 05:08:34 +0200 (EET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 10C6868AE47 for ; Mon, 27 Dec 2021 05:08:26 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640574512; x=1672110512; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=UMcPL6G+2vidWp5HxM9em7LBc1F/FCrN2kkIGM6oC/I=; b=IaEx5ID73m8KjtpbUANVPNQrb0T5Cgs7vk63//N69Fiocb0ocQ5k1AXR ZWtOoiHcf9KmWlR9+NVllNxnAEaDf1fnUWPOp71M5HM1mP7rKtjJnINby hTCJwNd7kNpXX4VMyW1uj3tGFr2UKLoPOayeiqRMwhmpVYfSI7GbXmh0Q Ey0drLASwyPv90GoT7JWeTeetqUIMU5IQRTDN8lYrs3tMBc88RiSMyxhY bUaTj0vVx4qzoDEdQLvSBMxSkWGGyFFUBrERiEAbU3X+kwuEKGVXMZmnS eiNmcC1AlTmNXMwCTC6boQclv6dWVpruvC40vEtL6aRILjnYawClRyWwv A==; X-IronPort-AV: E=McAfee;i="6200,9189,10209"; a="265375525" X-IronPort-AV: E=Sophos;i="5.88,238,1635231600"; d="scan'208";a="265375525" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Dec 2021 19:08:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,238,1635231600"; d="scan'208";a="760625753" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 26 Dec 2021 19:08:23 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 26 Dec 2021 19:08:23 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 26 Dec 2021 19:08:23 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 26 Dec 2021 19:08:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/vNECZ3QF8eSZadaWd5ijjZRioNWl1XGbWhdR/2SFyz6rjIUC0GjvDplPEcvjPkOIcBooP8b8YoG9JtCtaL7Qzmb4bYJHg/x0IGGReuj32hjkGnFQ/979VsATmHP+v+7GgHGIqRQ70E0hHTyEOdByfTznTdefTOX0BwSO3JsRW8pMyIQ5+QtVy47/n51iWWfzKbdudFzyXNG0pQssXYcmX4Nk3zTK8VUzTnpe+Pn60VUS4GAJ1iuCuz8s58YeSIedbxTu2an2qpVmYc2G6bfzrnqTmFMLw3O7SQBGU46frTy4ErbGSo4tXne+s87LKG9z8bc/rAY9mwW5kf7gSIVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UMcPL6G+2vidWp5HxM9em7LBc1F/FCrN2kkIGM6oC/I=; b=ZOuCJaHYWlcDA1WHN0aC31kwtCc56zs/T/w68g7gnnobDcDoPloGfLBj40rLkAP7UNmMbQKNdxpNtaJ2C8D10UiyQ4nQabWzVn5vCSg/xxZwML6ZmeFA0KXVqn/AXAmKQ2bqwa+sQjlHtBSQO22eIH4qvqqXqensjW+DPTJu7TcC4QCOVRtTp9sQWp7Xi1ZxsRm2pR5YhOhdMQZX5f9k/x5GIsEHs0+sDoxN+nRDbov3oQTv03J9BxMPo9/Vu3rNmvMiSm687AdZrfJBrQ4P1dNJOVAyxXU7C3uVDQw1LAIPBJe8xjijXoGAEiF38Sady1w0TNlCF+iKLJDh2HPqCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN6PR1101MB2180.namprd11.prod.outlook.com (2603:10b6:405:58::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.16; Mon, 27 Dec 2021 03:08:21 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16%3]) with mapi id 15.20.4823.022; Mon, 27 Dec 2021 03:08:21 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions Thread-Index: AQHX4hsioJyM1GLeREaoFRgSTTytDawV/YDXgAAxacqAAASjAIAqE1oAgAWS44A= Date: Mon, 27 Dec 2021 03:08:21 +0000 Message-ID: <6c1f517dad96d2d6075cb69a30e1a50aefd3feb9.camel@intel.com> References: =?utf-8?q?=3CDM8P22?= =?utf-8?q?3MB036578CDD5AEA447DD2DE424BA629=40DM8P223MB0365=2ENAMP223=2EPROD?= =?utf-8?q?=2EOUTLOOK=2ECOM=3E?= <163785839519.25323.16303122737288435026@lain.red.khirnov.net> =?utf-8?q??= =?utf-8?q?=3CDM8P223MB03658AA2F5F59B9859CFCACBBA629=40DM8P223MB0365=2ENAMP2?= =?utf-8?q?23=2EPROD=2EOUTLOOK=2ECOM=3E?= <163794332023.25323.7446601680884381987@lain.red.khirnov.net> =?utf-8?q?=3C?= =?utf-8?q?DM8P223MB0365F038A547211DE98A156EBA639=40DM8P223MB0365=2ENAMP223?= =?utf-8?q?=2EPROD=2EOUTLOOK=2ECOM=3E?= <163795393240.7822.9483345286843818669@lain.red.khirnov.net> <50841f8a73c902d3fca896b1eda923d082b27383.camel@intel.com> In-Reply-To: <50841f8a73c902d3fca896b1eda923d082b27383.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d8244f5-9690-4799-ec4d-08d9c8e623a2 x-ms-traffictypediagnostic: BN6PR1101MB2180:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S55iDW+IF/ensuzpldBnslOcx7HhOvocYJIOFp1eN5yve/BSm4wLDq3SyqVELgul7FOtFXwFacTpqmn7sg6sUzOV3mjGeE+0vX3PZNzIwK4N06B5+MZmSzvdiGl4KoP59nPIgtfcYMDbIIdhjfg5PaGpBDXP7HOBrW2g7WNJhGiiyPXgMwVRuFQH8aM2AO33o8IVzqYTvp9PIYAPPTTAqun8AK8Ts0u7gv+nFDA95MPI0CoP2+2hh4v32I/5ikpPzQi9FVGnCKiySi8rBTthRp4IUOezUAJ/d75AInWBJMUjohcolPNz0ih9fmB6zjK96fUMHlxAgdCYmxrFF7EWkCKzVsZorBARMDIj34fQoNj9IlSmaAChDx5JEd4ayYadXGzYwrScBi3WVQuVAFvXDFIiC5kxSFYb4eaV/5zplegucBlp3PXSpRT+8XrCRO5hob4Ms/RNVfL0AOIp37acoKDiE3vUxJWsHUEbaJ4Vv4HQ/qR83T/QuQFF9zraFGdXzvrWkvsCoPEy37pXCyZHxEiEvJ5QqmgEUqXfH5951/LQhfZNYCDSE6jUOeRsAT9ufmgiBFlIJw4gtdJ221f1VT/BMJaPY1Qr3q8GKpTM1s01XQeR27/0z6t5PxkFKYS9drzlz2G1E6O1HRwc42LhzmWTDZCpKmN+AQGzltc4ReXZx6V/0HYs//Q5p+rVlAw/i1dbX25F5aRhnKIs5qVR2cxrSqsG8lBA0LoxAdWKo6o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(2616005)(8936002)(6512007)(38100700002)(8676002)(316002)(66556008)(66476007)(122000001)(66446008)(64756008)(66946007)(82960400001)(36756003)(6916009)(86362001)(76116006)(5660300002)(91956017)(2906002)(53546011)(186003)(26005)(6506007)(71200400001)(6486002)(4001150100001)(83380400001)(38070700005)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L3lIVXJMdjJUcGRxaVV0OW84U05ORFUrWkxxeUhnUEErQUU2eExnRWREWFJO?= =?utf-8?B?ZWdlWHBFaTg2K1g5Q3hwWitIeHhEcE5IRzFkc1ovVmR2SUVMejBzeDdqUncr?= =?utf-8?B?V1N5bklqL0c1cFduNXl1Wml5T05lc0xPdzBaVkpaQWVqUXFscHhueEFmN2Jq?= =?utf-8?B?T0xLQnFYRzRFMmtmeGVsSXhLbEgybHZMZWhrRE1VNmZ6YndyZ0NBa0NKeU91?= =?utf-8?B?bndKZGdQSktQQUt0S2N0QW9tRENVeWhwUG5tQ2lObzl6WVNjQm85MnVqRjE0?= =?utf-8?B?Wkt4S0hHMWxNb3JoaW5qYXQ1cll2dzB0eG4xM3E5MlJibDZPMk1yb0FLc0Nj?= =?utf-8?B?MmUwcVJEenBnQUNpbHp0N0NEWk9qSG5heEdzWHc5clk0RTJDMWo2dTZrcENU?= =?utf-8?B?V2Y2ZFU2NXdRZUxQc0lxU1FDWlVNV1JaUGJRMlgwRmJQK0gxUm5hR043Tlc4?= =?utf-8?B?YUlFY25mTndhZ29OZHF1OGY5R1hQYXVWVXJaamFyK3FJMnFNbmE0SlZpSkRL?= =?utf-8?B?NHBkTWRwb0ZUaVk3aTlKalkxVXZSY213QkJXYytEdHBrWVk1SFhOZ05RWHdt?= =?utf-8?B?ampIcEhUQ2tGN09OVlpRMW1idldXWUVkWHRWT2pWcUFCSHBGckU1L1NxN1Mr?= =?utf-8?B?OHhseE1jZkpiQXl5UlhtS2R1M3NIcVVZWEY1U1d3ZjM5NGF5V0JkRU1UOFFs?= =?utf-8?B?SlBMd1NzNTRsTDFscDZzbUZzQ0pPRFhobzZjNFR6NUh6Um05MEQ3RS95STQ2?= =?utf-8?B?TDQ1OXVVWkpRZTBIcndRRFhWVkNabVFrWmJuTnJJdXRTNk5LWXlRMEt6OFNu?= =?utf-8?B?UWdvY0RuRk42MTZWUXoydWRFVWVxSDQwUjEvdVFoSkp2RzRvVEZIZ3I3MzFy?= =?utf-8?B?ak9vVlo3UTNVMWpMemZ0cmVpaExBa2ZDU1E3anpQazJuc1hiLzl3WlRmR2xL?= =?utf-8?B?dHpqbFdtM2h2VjRUK1l4b2xKSSs3ZS9jRzF5eW1ORG9LSmo3UEFkblJJYmtr?= =?utf-8?B?dHY4MGRuZ2pNR2MveVpYKzVLVnd6VkFaNFg5bzVHRHVpeFh1a3B4RXVEdTdm?= =?utf-8?B?R0dMSllLdnZsbEJqaGRyckk5dE1FbTdFaVhla3MzQWRiTFFWU0ZsUk5FcERV?= =?utf-8?B?SDZaQVZTR2FIQXNXTTRJZjgrN0JjaVZrcUozT3NuQkxaOHRxcUNrc2g4cFIx?= =?utf-8?B?TlZ1eW1QeHluZGIydDVoRFo5UlBNWmJnVDZ2cmt6WEVSb3c5aFRxck96dExF?= =?utf-8?B?cThveExlcXdNTFpXaHQ5c2R4L1M5b1NsT3VnTjFuY25Dd0piSmN6U1E1WklW?= =?utf-8?B?UklNaWdEREl2b2MwMW5NOUVab3R1aE5nWmZ0NkFXYzJBaHV0S0VCQTROUXd2?= =?utf-8?B?TDQ0bGJHMmp3bmpVMXpPSVk5RTQwMkxUd2gzb3dNemdvZUhuSUtHZmJIeExM?= =?utf-8?B?WkdwQ09kRUljVHZnTXdtWU5Pd3BxNWRDSGw3UGNzQWRzcW9ZSnpvby9UWmFM?= =?utf-8?B?QlRRcDJoK1R0S01Ic3dubTlMb1NwTzRVbmNjUkxxa09hSFc0QWFvTTArVENo?= =?utf-8?B?Ly9abUIrSXZoNFl1dTJBNjc1VUZvQ0JYcGN6bkhlUWdtOHRvY2ZyU1lFQmlm?= =?utf-8?B?dnh0UU9vSTlmQm5iWDdlcktUZ0FUWUZLR0tLSlJaNkhCVEpaSk4xN1VlN1M5?= =?utf-8?B?L3A0RXBDRE15S0EyRlZBbDFsSFRIWjhiZnJRcG9xK09lOFFaR3hlMUs5S1lI?= =?utf-8?B?SlRIKzNBbTdMNUV0Q2xWVXNtNVlpRnBMWkZOMVJxSG41S0NKK1pjWEFzUkZJ?= =?utf-8?B?dktsZVBXdnkyNkQvTG5tWkZVWlJjVmVVL2U2MWwyaDBIOE41aHd2TnFZTEZN?= =?utf-8?B?dWlZT0VUaDczRHNmNHJsSGZpYkhEYUhhZFlGWGQzdDFXSGd2UVp0Q0FIeVMw?= =?utf-8?B?UC81VUo1a1NBZlFaRnYwTEl5SUlSM2JPMXVEY2tib0h0QnZHQ3J0TVg1bUdV?= =?utf-8?B?V3FoYlRNeWk3U2dmM0dOZjM1YWhBQm5JYkM0dUJhVmUwMG9yNG9xd1FJeE1W?= =?utf-8?B?aGVYakZINmh6ZjlkeEh3TmVnY2hiZkZoQWxrYWRQbkhMQnh6bk9iYmdROGo2?= =?utf-8?B?ZzJYREozckVaZUJLQTlyWEVPcUZIbUlZM0s3bm9rR3N5MnVFNlNObXRpbmg4?= =?utf-8?Q?yxWfsimICJZF8TceuV+pZds=3D?= Content-ID: <84CA500CEFA16A4699A9F61763A81EA0@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d8244f5-9690-4799-ec4d-08d9c8e623a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2021 03:08:21.4298 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k6rI80M+XLsnqB666plaqL+cTByyt+rcqlZIlCffo0h8Yxph1YFznkRaKKWPx3Xs+rB0omBgNkrLQeJwbxk/mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2180 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2021-12-23 at 14:01 +0000, Xiang, Haihao wrote: > On Fri, 2021-11-26 at 19:29 +0000, Soft Works wrote: > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of Anton > > > Khirnov > > > Sent: Friday, November 26, 2021 8:12 PM > > > To: FFmpeg development discussions and patches > > > Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When > > > deriving > > > a > > > hwdevice, search for existing device in both directions > > > > > > Quoting Soft Works (2021-11-26 19:43:58) > > > > Maybe I'm missing something, but hw device contexts are refcounted. > > > > What happens in hwdevice_ctx_free() is this: > > > > > > > > av_buffer_unref(&ctx->internal->source_device); > > > > > > IIUC this only happens after the parent device is freed. My concern is > > > the following situation: > > > - the caller creates a parent hwdevice > > > - the caller derives a child from it, which may acquire some additional > > > resources beyond what the parent holds > > > - the caller unrefs all his references to the child, but the child does > > > not get freed because the parent still holds a reference to it > > > > > > Since av_hwdevice_ctx_create_derived() has a flags parameter, we might > > > want to introduce a flag to control this behavior. > > > > I understand what you mean. I'm just not sure whether a practical case > > with such a requirement exists. Should that turn out to be required, > > such flag can be added at any time, IMO. > > > I agree we may add such flag later if required. May we merge this patch to fix > the annoying derivation limitation if no other concern ? Any other comment for this patch version? I'll add the note pointed out by Lynne and push this patch if no objection. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".