Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Check sample_sizes before using it

[James Almer <jamrial@gmail.com>]

On 7/26/2024 6:08 PM, Michael Niedermayer wrote:
> Fixes: NULL pointer dereference
> Fixes: 70569/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5247918563459072
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   libavformat/mov.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index b74e43e2140..63db7d59a58 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -10060,6 +10060,10 @@ static int mov_read_header(AVFormatContext *s)
>   
>               st = item->st;
>               sc = st->priv_data;
> +
> +            if (!sc->sample_sizes || !sc->sample_count)
> +                return AVERROR_INVALIDDATA;

Deja vu. Didn't you send something like this before?

Also, can i get the sample? As with other issues, we shouldn't reach 
this point if these were not allocated.

> +
>               st->codecpar->width  = item->width;
>               st->codecpar->height = item->height;
>   
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".