Re: [FFmpeg-devel] [PATCH v4 1/7] avcodec/la: add LSX optimization for h264 idct.

From: Hao Chen <chenhao@loongson.cn>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v4 1/7] avcodec/la: add LSX optimization for h264 idct.
Date: Thu, 25 May 2023 10:43:44 +0800
Message-ID: <6b1ddb58-d79e-90ac-afb3-e69d722eaf46@loongson.cn> (raw)
In-Reply-To: <20230524212809.GM1391451@pb2>

在 2023/5/25 上午5:28, Michael Niedermayer 写道:
> On Wed, May 24, 2023 at 03:48:27PM +0800, Hao Chen wrote:
>> From: Shiyou Yin <yinshiyou-hf@loongson.cn>
>>
>> loongson_asm.S is LoongArch asm optimization helper.
>> Add functions:
>>    ff_h264_idct_add_8_lsx
>>    ff_h264_idct8_add_8_lsx
>>    ff_h264_idct_dc_add_8_lsx
>>    ff_h264_idct8_dc_add_8_lsx
>>    ff_h264_idct_add16_8_lsx
>>    ff_h264_idct8_add4_8_lsx
>>    ff_h264_idct_add8_8_lsx
>>    ff_h264_idct_add8_422_8_lsx
>>    ff_h264_idct_add16_intra_8_lsx
>>    ff_h264_luma_dc_dequant_idct_8_lsx
>> Replaced function(LSX is sufficient for these functions):
>>    ff_h264_idct_add_lasx
>>    ff_h264_idct4x4_addblk_dc_lasx
>>    ff_h264_idct_add16_lasx
>>    ff_h264_idct8_add4_lasx
>>    ff_h264_idct_add8_lasx
>>    ff_h264_idct_add8_422_lasx
>>    ff_h264_idct_add16_intra_lasx
>>    ff_h264_deq_idct_luma_dc_lasx
>> Renamed functions:
>>    ff_h264_idct8_addblk_lasx ==> ff_h264_idct8_add_8_lasx
>>    ff_h264_idct8_dc_addblk_lasx ==> ff_h264_idct8_dc_add_8_lasx
>>
>> ./configure --disable-lasx
>> ffmpeg -i 1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -y /dev/null -an
>> before: 155fps
>> after:  161fps
>> ---
>>   libavcodec/loongarch/Makefile                 |   3 +-
>>   libavcodec/loongarch/h264_deblock_lasx.c      |   2 +-
>>   libavcodec/loongarch/h264dsp_init_loongarch.c |  39 +-
>>   libavcodec/loongarch/h264dsp_lasx.c           |   2 +-
>>   .../{h264dsp_lasx.h => h264dsp_loongarch.h}   |  60 +-
>>   libavcodec/loongarch/h264idct.S               | 658 ++++++++++++
>>   libavcodec/loongarch/h264idct_lasx.c          | 498 ---------
>>   libavcodec/loongarch/h264idct_loongarch.c     | 184 ++++
>>   libavcodec/loongarch/loongson_asm.S           | 945 ++++++++++++++++++
>>   9 files changed, 1848 insertions(+), 543 deletions(-)
>>   rename libavcodec/loongarch/{h264dsp_lasx.h => h264dsp_loongarch.h} (68%)
>>   create mode 100644 libavcodec/loongarch/h264idct.S
>>   delete mode 100644 libavcodec/loongarch/h264idct_lasx.c
>>   create mode 100644 libavcodec/loongarch/h264idct_loongarch.c
>>   create mode 100644 libavcodec/loongarch/loongson_asm.S
> Applying: avcodec/la: add LSX optimization for h264 idct.
> .git/rebase-apply/patch:1431: tab in indent.
> 	} else if (nnz) {
> warning: 1 line adds whitespace errors.
>
> [...]
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Thank you for your feedback. My local git does not have the 
core.whitespace option set, causing this problem to not be detected. I 
will retest all patches and try to avoid similar problems from happening 
again.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".