From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C81DE4AB6A for <ffmpegdev@gitmailbox.com>; Mon, 13 May 2024 23:08:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 47A5268D611; Tue, 14 May 2024 02:08:22 +0300 (EEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 92EE068D4D2 for <ffmpeg-devel@ffmpeg.org>; Tue, 14 May 2024 02:08:15 +0300 (EEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6f44881ad9eso3925043b3a.3 for <ffmpeg-devel@ffmpeg.org>; Mon, 13 May 2024 16:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715641692; x=1716246492; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=pn1HaeNCmLZD0as69yCCGRFnlL3M5pEkiXvVrFrYXi4=; b=NNs2NsA3eUFBa+N7LU81N4VX9Yvq0G2Qsa18/EcZ5omHk4rNmH5DIS50KF18upJv2e 0QPV4+kwiyRQqE0BJPru9MkYPhl6Ot3/ru9pxDjL4y0oLiQjMEEqwbmZlQhI1AcrHUsP PcG53qQi8etLaQ9A8yEeWUuRpg8aS9Uy/pJHT8RSkJD6scqKfT4GFzUhuAyGMf59LPGo YYAeYKOFM4MrDaeSmrJn+ePAcImxx/5QSyl1pL40OTJZ8B8NDLuSqhZT4iezQ+tSsN0P yNZrVIzp+VMgEbEtFq4/T82hJogRZbNo6AC8mBq8gPOkmLNrtuKP8Cy7W+pHCcVJ9qpN DlgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715641692; x=1716246492; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pn1HaeNCmLZD0as69yCCGRFnlL3M5pEkiXvVrFrYXi4=; b=wazQ8y9pd7hzBwGoiGdXpulzpdvkq1scwbYKx6DbkyszAy6gj1FpBDY2/mtON+RsS7 C0R7EMsH2rQ4z8ecnUtCY16PCaPqTNRt4I112XplMSocTUOalC8G0NeMoiqzEnuvNLnu mWaDgdTxvPXn+zy2LixZhNU2Ti2GczGnK0ZvZUfKE1zGGxPhJrltmo8m0bcxQGYGFPaf /0doCvrbUoB8XuHBaLVxgogKFOpXAXgVH6zO+sjyEYALTldGYTTCQYpkWUE5L08JMo87 bhEmirggh2Ws4ypgRbRM4fWWdnjSS+Du41NoiKlkQ+V3O4ORsct+Qfb51dG1pzasvHVl 5H4w== X-Gm-Message-State: AOJu0YwqqotmA4tk0r/aoUvwNz0V9n2Sy2Z6i3Zu3sjJYL875LVfbzRL nCzBfIEnbU4TxoWQrSp3oz0Jd2O2w9p9U2hXSuNn1d+ghia3M8Y/FRgMPA== X-Google-Smtp-Source: AGHT+IG565lT7FWA6rK8U0dP5VYqSWlLDBSHNOBajUOMBmFa+FQ//c255Po6PZAXkTeomj2b6PHopw== X-Received: by 2002:a05:6a00:b53:b0:6ea:d7b6:f4b4 with SMTP id d2e1a72fcca58-6f4e0355510mr14012523b3a.21.1715641692374; Mon, 13 May 2024 16:08:12 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-634105e0762sm8274976a12.63.2024.05.13.16.08.11 for <ffmpeg-devel@ffmpeg.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 16:08:11 -0700 (PDT) Message-ID: <6aec9636-54cd-42ea-ad15-9322428af46c@gmail.com> Date: Mon, 13 May 2024 20:08:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240506012307.807589-1-michael@niedermayer.cc> <20240513013154.GZ6420@pb2> <CAK+ULv5J-FE1OpBy0MD=TYftq4A+rjezfv65XvwR_R501iqosw@mail.gmail.com> <20240513224932.GJ6420@pb2> Content-Language: en-US From: James Almer <jamrial@gmail.com> In-Reply-To: <20240513224932.GJ6420@pb2> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/6aec9636-54cd-42ea-ad15-9322428af46c@gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On 5/13/2024 7:49 PM, Michael Niedermayer wrote: > On Mon, May 13, 2024 at 06:15:16AM +0100, Kieran Kunhya wrote: >> On Mon, 13 May 2024, 02:32 Michael Niedermayer, <michael@niedermayer.cc> >> wrote: >> >>> On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote: >>>> Fixes: CID1439574 Dereference after null check >>>> >>>> Sponsored-by: Sovereign Tech Fund >>>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> >>>> --- >>>> libavcodec/h264_slice.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> will apply >>> >> >> I don't understand what this fixes > > it is not possible for sps to be NULL in this function (see line 1424) It's also passed to ff_h264_init_poc(), which expects it to not be NULL. In any case, when the coverity issues are about something that's not a bug but just noise like superfluous checks, might as well use something like "closes" rather than "fixes". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".