[FFmpeg-devel] [PATCH] configure: Fix iamfdec dependencies

[FFmpeg-devel] [PATCH] configure: Fix iamfdec dependencies

[Andreas Rheinhardt]

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 71386c3920..a393f6ea65 100755
--- a/configure
+++ b/configure
@@ -2854,6 +2854,7 @@ hevcparse_select="golomb"
 hevc_sei_select="atsc_a53 golomb"
 frame_thread_encoder_deps="encoders threads"
 iamfdec_deps="iamf"
+iamfdec_select="iso_media mpeg4audio"
 iamfenc_deps="iamf"
 inflate_wrapper_deps="zlib"
 intrax8_select="blockdsp wmv2dsp"
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] configure: Only enable iamfdec, iamfenc when needed

[Andreas Rheinhardt]

Since 591e27d1e7b21b66f81c53f381356c5e6f1f0451 they would
always be compiled even when nothing uses them; for shared
builds the default linker behaviour is to include them
even when not needed.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 configure | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index a393f6ea65..29cc8773fd 100755
--- a/configure
+++ b/configure
@@ -3595,8 +3595,8 @@ gxf_muxer_select="pcm_rechunk_bsf"
 hds_muxer_select="flv_muxer"
 hls_demuxer_select="aac_demuxer ac3_demuxer adts_header ac3_parser eac3_demuxer mov_demuxer mpegts_demuxer"
 hls_muxer_select="mov_muxer mpegts_muxer"
-iamf_demuxer_deps="iamfdec"
-iamf_muxer_deps="iamfenc"
+iamf_demuxer_select="iamfdec"
+iamf_muxer_select="iamfenc"
 image2_alias_pix_demuxer_select="image2_demuxer"
 image2_brender_pix_demuxer_select="image2_demuxer"
 imf_demuxer_deps="libxml2"
@@ -3612,8 +3612,9 @@ matroska_muxer_select="mpeg4audio riffenc aac_adtstoasc_bsf pgs_frame_merge_bsf
 mlp_demuxer_select="mlp_parser"
 mmf_muxer_select="riffenc"
 mov_demuxer_select="iso_media riffdec"
-mov_demuxer_suggest="zlib"
+mov_demuxer_suggest="iamfdec zlib"
 mov_muxer_select="iso_media riffenc rtpenc_chain vp9_superframe_bsf aac_adtstoasc_bsf ac3_parser"
+mov_muxer_suggest="iamfenc"
 mp3_demuxer_select="mpegaudio_parser"
 mp3_muxer_select="mpegaudioheader"
 mp4_muxer_select="mov_muxer"
@@ -4084,7 +4085,7 @@ enable asm
 enable debug
 enable doc
 enable faan faandct faanidct
-enable iamf iamfdec iamfenc
+enable iamf
 enable large_tests
 enable optimizations
 enable ptx_compression
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: Fix iamfdec dependencies

[James Almer]

On 4/3/2024 4:35 PM, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   configure | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index 71386c3920..a393f6ea65 100755
> --- a/configure
> +++ b/configure
> @@ -2854,6 +2854,7 @@ hevcparse_select="golomb"
>   hevc_sei_select="atsc_a53 golomb"
>   frame_thread_encoder_deps="encoders threads"
>   iamfdec_deps="iamf"
> +iamfdec_select="iso_media mpeg4audio"
>   iamfenc_deps="iamf"
>   inflate_wrapper_deps="zlib"
>   intrax8_select="blockdsp wmv2dsp"

LGTM. Please backport it too.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] configure: Only enable iamfdec, iamfenc when needed

[James Almer]

On 4/3/2024 4:46 PM, Andreas Rheinhardt wrote:
> Since 591e27d1e7b21b66f81c53f381356c5e6f1f0451 they would
> always be compiled even when nothing uses them; for shared
> builds the default linker behaviour is to include them
> even when not needed.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   configure | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/configure b/configure
> index a393f6ea65..29cc8773fd 100755
> --- a/configure
> +++ b/configure
> @@ -3595,8 +3595,8 @@ gxf_muxer_select="pcm_rechunk_bsf"
>   hds_muxer_select="flv_muxer"
>   hls_demuxer_select="aac_demuxer ac3_demuxer adts_header ac3_parser eac3_demuxer mov_demuxer mpegts_demuxer"
>   hls_muxer_select="mov_muxer mpegts_muxer"
> -iamf_demuxer_deps="iamfdec"
> -iamf_muxer_deps="iamfenc"
> +iamf_demuxer_select="iamfdec"
> +iamf_muxer_select="iamfenc"
>   image2_alias_pix_demuxer_select="image2_demuxer"
>   image2_brender_pix_demuxer_select="image2_demuxer"
>   imf_demuxer_deps="libxml2"
> @@ -3612,8 +3612,9 @@ matroska_muxer_select="mpeg4audio riffenc aac_adtstoasc_bsf pgs_frame_merge_bsf
>   mlp_demuxer_select="mlp_parser"
>   mmf_muxer_select="riffenc"
>   mov_demuxer_select="iso_media riffdec"
> -mov_demuxer_suggest="zlib"
> +mov_demuxer_suggest="iamfdec zlib"
>   mov_muxer_select="iso_media riffenc rtpenc_chain vp9_superframe_bsf aac_adtstoasc_bsf ac3_parser"
> +mov_muxer_suggest="iamfenc"
>   mp3_demuxer_select="mpegaudio_parser"
>   mp3_muxer_select="mpegaudioheader"
>   mp4_muxer_select="mov_muxer"
> @@ -4084,7 +4085,7 @@ enable asm
>   enable debug
>   enable doc
>   enable faan faandct faanidct
> -enable iamf iamfdec iamfenc
> +enable iamf
>   enable large_tests
>   enable optimizations
>   enable ptx_compression

LGTM. Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".