From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 9C49E48436
	for <ffmpegdev@gitmailbox.com>; Wed,  3 Jan 2024 12:58:26 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C92668CC39;
	Wed,  3 Jan 2024 14:58:23 +0200 (EET)
Received: from btbn.de (btbn.de [136.243.74.85])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EA25868AC25
 for <ffmpeg-devel@ffmpeg.org>; Wed,  3 Jan 2024 14:58:16 +0200 (EET)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id ECFED2F716; 
 Wed,  3 Jan 2024 13:58:15 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1704286696;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=ZTD0AT21Ss6hmnSFRBzL2tezR28PigM7sPcQfgNW8v8=;
 b=paYpuTnpkX/QGaOhdgewYzwLsY1gJO9Crom7SZ7k/50QIMxut9Pi6n4d4atZyw7zlmTIJk
 e9vHJElPMiSoQau8Y0xb2UY9gwqVNJmSsKcV2F0oUeWGR6tSDs+aWONzG9RHR3i+6ZCqYt
 T6s/roqgIgQTCwP+aal1XyyDj4sV6ynyWD0lDzRoHQ946bHUkyJ5uER5ZuU6+4y2c1zm8x
 IM+uk7RxS5YzMf7TFn5fYsiSZ8ZaUXsF4+TTHygIhWXTHmVB0e9qWhY4Ebl4G9t6CqGWzT
 COns5iBOgoSrkjO9LlMXgTDn1lgv8ZdYto2A4qPuQwFPPRTTspqx75FkqzY0eg==
Message-ID: <6a41f45e-3c64-45ca-b4f4-d5da10de7047@rothenpieler.org>
Date: Wed, 3 Jan 2024 13:58:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org, Stefano Sabatini <stefasab@gmail.com>
References: <20231130004914.329717-1-stefasab@gmail.com>
 <20231130004914.329717-2-stefasab@gmail.com> <ZWyZRAPL1vpx4Gu9@mariano>
 <ZXSuDZBkEkAjK2tW@mariano> <ZX3DyMOXgCNmegho@mariano>
Content-Language: en-US
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <ZX3DyMOXgCNmegho@mariano>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavfi: introduce textutils
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/6a41f45e-3c64-45ca-b4f4-d5da10de7047@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 16.12.2023 16:35, Stefano Sabatini wrote:
> Ping, if there are no objections or comments I plan to push this in a
> week or something.

This broke the build:

> libavfilter/vf_drawtext.c: In function 'shape_text':
> libavfilter/vf_drawtext.c:687:13: error: implicit declaration of function 'is_newline'; did you mean 'ff_is_newline'? [-Werror=implicit-function-declaration]
>   687 |         if (is_newline(unicodestr[line_end]) || line_end == len - 1) {
>       |             ^~~~~~~~~~
>       |             ff_is_newline

Looks like one instance of is_newline was forgotten?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".