From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E0194481D4 for ; Sun, 12 Nov 2023 15:17:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 37BDE68CC45; Sun, 12 Nov 2023 17:17:05 +0200 (EET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3B5CC68CBF5 for ; Sun, 12 Nov 2023 17:16:59 +0200 (EET) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6c10f098a27so2690949b3a.2 for ; Sun, 12 Nov 2023 07:16:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699802216; x=1700407016; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q1Za4wmQe2Zzh5yeIR47n+RbPB8p+iAu2pXaRusMFnQ=; b=bC1J3wruczWO9vWqsvNhaWbi1kkYFPn/01CKJU+wrydQFOLWVSHePb02f0MdHVrD3e yvkULvtWYiHZi7eNE1QcH/A8nlT7i1IAAw7z9J4RXLJ/VJMzX8XoMQUOil1SX+ofVYO0 /5IqiqpWzriaHBJtxDcBBcBRtwJO59Thy64NsMTsdu52UjmMFc1ngsOXBcFxvXid6Kyf cWCyMI8iTlTjEdV2XlvqsAmQQPgdWFzei0jiE6AP6nj0VvzF9vr0vaLMsPPcajoDh2RT hk1X5gmespy/Pac0NzECztz1hVGZ0tBQjb0GEbdxQJACv/KDSza72ZCVzhMpLx2gIqCm 3+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699802216; x=1700407016; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q1Za4wmQe2Zzh5yeIR47n+RbPB8p+iAu2pXaRusMFnQ=; b=LY6mXXNTGQ2c0lhOz6R3hVJTsfnfYN7OUiW/ZXdK9Gq3b1GjeZmLPCNCzpSji1Zxgq OjfQH8z8h9p5SyQ9FAdxz7VK0D9smh2GLiX/QsWBLvSXvbrl0yMA8ME2fDLlhoV4vTxd isapKo7xrmOxBgsGGCKVu2HAn509XMcyOlmNVK+bTs9zyFOlo+jOc6Q1tEC9I1cBe7zu tBW7A3tWpbyUdjvES9ScpXH7vP906ynetfwkEHqbpe7Z/s6G8FfExHon7sLbz/M2viSI wwdw8++bIoAN6qYghYAayFfkmIxaWHqC18G4MDqGRn0LX/YVlNmAm/79YtNVYLa+ZuwF iSMA== X-Gm-Message-State: AOJu0Yx1M0FOftimRdf6KyJf3XLiJsRv9B6cSoZFBGBPTk4X/HutqEXH pBxGhLoP6TmGqytBzx/EbpD0Kkai8YM= X-Google-Smtp-Source: AGHT+IGWyWy6cxDeo1MRCFgZ5W+yFUILSVv7Br0uW8Pt0fV2Ob2P9wX6uq/wfdNqlyceVHmYS5j7Qg== X-Received: by 2002:a05:6a21:718a:b0:181:3adf:6309 with SMTP id wq10-20020a056a21718a00b001813adf6309mr3251278pzb.18.1699802216549; Sun, 12 Nov 2023 07:16:56 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id g9-20020a170902934900b001cc50c5699asm2652173plp.301.2023.11.12.07.16.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Nov 2023 07:16:56 -0800 (PST) Message-ID: <69746715-a65d-4f37-8a29-8e626cd52401@gmail.com> Date: Sun, 12 Nov 2023 12:17:19 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231112151144.2307049-1-sramacher@debian.org> <20231112151144.2307049-3-sramacher@debian.org> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20231112151144.2307049-3-sramacher@debian.org> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fft: Set potentially unused wrapper variables to avoid invalid free/uninit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/12/2023 12:11 PM, Sebastian Ramacher wrote: > --- > libavcodec/avfft.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/avfft.c b/libavcodec/avfft.c > index 93203228c2..813b6d61a1 100644 > --- a/libavcodec/avfft.c > +++ b/libavcodec/avfft.c > @@ -102,7 +102,8 @@ FFTContext *av_mdct_init(int nbits, int inverse, double scale) > av_free(s); > return NULL; > } > - } > + } else > + s->ctx2 = NULL; > > return (FFTContext *)s; > } > @@ -220,7 +221,8 @@ DCTContext *av_dct_init(int nbits, enum DCTTransformType inverse) > av_free(s); > return NULL; > } > - } > + } else > + s->tmp = NULL; > > return (DCTContext *)s; > } IMO just allocate the AVTXWrapper with av_mallocz() instead. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".