From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id F204243762
	for <ffmpegdev@gitmailbox.com>; Mon, 27 Jun 2022 21:55:28 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 492AE68B8ED;
	Tue, 28 Jun 2022 00:55:26 +0300 (EEST)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 706AF68B7E6
 for <ffmpeg-devel@ffmpeg.org>; Tue, 28 Jun 2022 00:55:19 +0300 (EEST)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 25RLt742019755-25RLt743019755;
 Tue, 28 Jun 2022 00:55:07 +0300
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id CDC34A142E;
 Tue, 28 Jun 2022 00:55:06 +0300 (EEST)
Date: Tue, 28 Jun 2022 00:55:04 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: "Swinney, Jonathan" <jswinney@amazon.com>
In-Reply-To: <82e0929f4af04100872873ce7dc41683@EX13D07UWB004.ant.amazon.com>
Message-ID: <696216d4-1915-8196-a8e5-7c86e7ee654f@martin.st>
References: <82e0929f4af04100872873ce7dc41683@EX13D07UWB004.ant.amazon.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] lavc/aarch64: motion estimation
 functions in neon
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Michael Niedermayer <michael@niedermayer.cc>,
 Grzegorz Bernacki <gjb@semihalf.com>, "J. Dekker" <jdek@itanimul.li>,
 Hubert Mazur <hum@semihalf.com>,
 "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>, "Pop,
 Sebastian" <spop@amazon.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/696216d4-1915-8196-a8e5-7c86e7ee654f@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Sun, 26 Jun 2022, Swinney, Jonathan wrote:

> - ff_pix_abs16_neon
> - ff_pix_abs16_xy2_neon
>
> In direct micro benchmarks of these ff functions verses their C implementations,
> these functions performed as follows on AWS Graviton 3.
>
> ff_pix_abs16_neon:
> pix_abs_0_0_c: 141.1
> pix_abs_0_0_neon: 19.6
>
> ff_pix_abs16_xy2_neon:
> pix_abs_0_3_c: 269.1
> pix_abs_0_3_neon: 39.3
>
> Tested with:
> ./tests/checkasm/checkasm --test=motion --bench --disable-linux-perf
>
> Signed-off-by: Jonathan Swinney <jswinney@amazon.com>

Thanks! This looked great to me, and you seem to have applied all my 
feedback!

(There was one last case of "ldur" missing that I fixed up locally.)

With that fixed, I pushed this one now. Thanks!

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".