[FFmpeg-devel] [PATCH 1/2] fftools: set process code page to UTF-8 on Windows

[FFmpeg-devel] [PATCH 1/2] fftools: set process code page to UTF-8 on Windows

[rcombs]

This causes char-based filesystem and other API calls
to accept and produce UTF-8 strings instead of locale-dependent
legacy code page strings, when running on Win10 or newer.

By and large, ffmpeg uses the wide-character equivalents of these APIs,
so this shouldn't have any effect on most usage.
---
 fftools/fftools.manifest | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fftools/fftools.manifest b/fftools/fftools.manifest
index f2708ecb13..eaef6cacf1 100644
--- a/fftools/fftools.manifest
+++ b/fftools/fftools.manifest
@@ -4,6 +4,7 @@
     <asmv3:windowsSettings>
       <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
       <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2</dpiAwareness>
+      <activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">UTF-8</activeCodePage>
     </asmv3:windowsSettings>
   </asmv3:application>
 </assembly>
-- 
2.39.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] fftools: enable long path support on Windows

[rcombs]

This allows use of filesystem paths longer than MAX_PATH (260 characters)
on Windows 10 version 1607 and later.

This _may_ be a no-op if a "LongPathsEnabled" isn't set in the registry.
---
 fftools/fftools.manifest | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fftools/fftools.manifest b/fftools/fftools.manifest
index eaef6cacf1..34124c8298 100644
--- a/fftools/fftools.manifest
+++ b/fftools/fftools.manifest
@@ -5,6 +5,7 @@
       <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
       <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2</dpiAwareness>
       <activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">UTF-8</activeCodePage>
+      <longPathAware xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">true</longPathAware>
     </asmv3:windowsSettings>
   </asmv3:application>
 </assembly>
-- 
2.39.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] fftools: enable long path support on Windows

[Martin Storsjö]

On Wed, 8 Mar 2023, rcombs wrote:

> This allows use of filesystem paths longer than MAX_PATH (260 characters)
> on Windows 10 version 1607 and later.
>
> This _may_ be a no-op if a "LongPathsEnabled" isn't set in the registry.
> ---
> fftools/fftools.manifest | 1 +
> 1 file changed, 1 insertion(+)

Are you aware of the changes in c5aba39a041fdaac267fc8c6a2ef745a94a2b0da 
last year? That was supposed to make this change redundant, and make long 
paths usable even on versions of Windows older than that.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] fftools: enable long path support on Windows

[Ridley Combs]

> On Mar 8, 2023, at 15:35, Martin Storsjö <martin@martin.st> wrote:
> 
> On Wed, 8 Mar 2023, rcombs wrote:
> 
>> This allows use of filesystem paths longer than MAX_PATH (260 characters)
>> on Windows 10 version 1607 and later.
>> 
>> This _may_ be a no-op if a "LongPathsEnabled" isn't set in the registry.
>> ---
>> fftools/fftools.manifest | 1 +
>> 1 file changed, 1 insertion(+)
> 
> Are you aware of the changes in c5aba39a041fdaac267fc8c6a2ef745a94a2b0da last year? That was supposed to make this change redundant, and make long paths usable even on versions of Windows older than that.
> 
> // Martin

I hadn't seen that change, but I do think it's still worth signaling our support for long paths explicitly.

> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".