Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000dec: Check image offset

From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000dec: Check image offset
Date: Wed, 25 Oct 2023 21:20:09 +0200
Message-ID: <68f28bbf1c99382c3015efe8eb09b416f2b8ed8d.camel@haerdin.se> (raw)
In-Reply-To: <20231004225921.30287-1-michael@niedermayer.cc>

On Thu, 2023-10-05 at 00:59 +0200, Michael Niedermayer wrote:
> Fixes: left shift of negative value -538967841
> Fixes: 62447/clusterfuzz-testcase-minimized-
> ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6427134337613824
> 
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/jpeg2000dec.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c
> index eda959e558d..691cfbd8915 100644
> --- a/libavcodec/jpeg2000dec.c
> +++ b/libavcodec/jpeg2000dec.c
> @@ -238,6 +238,11 @@ static int get_siz(Jpeg2000DecoderContext *s)
>          return AVERROR_INVALIDDATA;
>      }
>  
> +    if (s->image_offset_x >= s->width || s->image_offset_y >= s-
> >height) {
> +        av_log(s->avctx, AV_LOG_ERROR, "image offsets outside
> image");
> +        return AVERROR_INVALIDDATA;
> +    }

Probably OK

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".