From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5F52F4AAC6 for ; Sun, 12 May 2024 16:44:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6456268D6B4; Sun, 12 May 2024 19:44:20 +0300 (EEST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D6E9468D48C for ; Sun, 12 May 2024 19:44:13 +0300 (EEST) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-602801ea164so2500025a12.0 for ; Sun, 12 May 2024 09:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715532251; x=1716137051; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=OIIJwq7Z8HnbqXRG9oW3tJZ+h5mjGXoVdujL4/kt6AU=; b=nOWojY5hSy2LHlwXW+YKw5QwScSyX/tbR81dIjcbIcR//szJ877jYWLB0XTiOjLtm7 oNsvXR9rrxkMtgpn0RTjB1HXYYZof9iKIf/wb6OxjradEMRjZTSNbhofmYb09ONAyiZi ujosduyB4Pli8118qpKAZu2rsyCA+OFX5a4jSuaDm1k+M/Dpo43GC2dYNgLIVQP2H2jw IRg9QkXdg5tf8ZoOOCP3vnEXNc2Gb4zF5uvSMszkF2/bWJXFAEGxrx17QwdQK5UguP9/ aXHgOnJrUU3kARZ0YHB0YuJUJVxE6yS0zZG2DR8mBVtTImkY41oLInrf7R+CHTt1o5wH ZZiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715532251; x=1716137051; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OIIJwq7Z8HnbqXRG9oW3tJZ+h5mjGXoVdujL4/kt6AU=; b=Lo8tsKVHHT1ptjRFit8378zrnSHvSSeEGVL65wjoY8RFWcKYdIXDQNLNcvypczsD5Z ALw7u1g7rnb7YUtbxe/2yJpPHzhkFW8g3XbvYB0NqnFAaXvuCr/9pnlFGAW3PQqUOpAC TWZX7OKztd0OYx93jxnu9hQQkTFDgtSUaGt8ykKV89qxAuKu22nzTmr6BX+HB1mHNzQd epQtfxGjkhAhD/jSqOIdglIw9iq8xqMUpz2JatxctpzPZuNcmgTI0W9KXfk3krqx1Xx6 yx4ZtTJ8LjqkvZejxL3Uv2TpZw+H6XKidbDPvwV7ktraO9IYMPYYskWuGk7Qwf1qugFT WMjg== X-Gm-Message-State: AOJu0YxKZURL9A22h0pebKJlfax6Wa2oXDyPlBIJJQyfqEMblD2EbLu7 pvdmsi6oaCOo0rVOgpZcl4O/ZDKdjHlx/tG6tTUAQiVg3dR/GKxzKnOleg== X-Google-Smtp-Source: AGHT+IEC98sZSpCqUMt8XEJ/ktMY0CbL1h1iRtaRXuAW/XWGRwEb8OMjR3XxlFgF9lOovb+De6zWZg== X-Received: by 2002:a05:6a00:4b0e:b0:6ec:fe38:d94 with SMTP id d2e1a72fcca58-6f4e0385e80mr8896190b3a.33.1715532250804; Sun, 12 May 2024 09:44:10 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2af2bafsm5871832b3a.162.2024.05.12.09.44.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 May 2024 09:44:10 -0700 (PDT) Message-ID: <68eedfe5-bb24-4b00-9465-1467f7eda3e0@gmail.com> Date: Sun, 12 May 2024 13:44:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240511194656.1576-1-jamrial@gmail.com> <20240512160657.2733-2-jamrial@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 4/8] avcodec/flacdsp: split off wasted bit handling into dsp functions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/12/2024 1:15 PM, Andreas Rheinhardt wrote: > James Almer: >> Signed-off-by: James Almer >> --- >> libavcodec/flacdec.c | 8 ++------ >> libavcodec/flacdsp.c | 20 ++++++++++++++++++++ >> libavcodec/flacdsp.h | 3 +++ >> 3 files changed, 25 insertions(+), 6 deletions(-) >> >> diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c >> index 91bbdc657d..6e6a2896b4 100644 >> --- a/libavcodec/flacdec.c >> +++ b/libavcodec/flacdec.c >> @@ -602,13 +602,9 @@ static inline int decode_subframe(FLACContext *s, int channel) >> >> if (wasted) { >> if (wasted+bps == 33) { >> - int i; >> - for (i = 0; i < s->blocksize; i++) >> - s->decoded_33bps[i] = (uint64_t)decoded[i] << wasted; >> + s->dsp.wasted33(s->decoded_33bps, decoded, wasted, s->blocksize); >> } else if (wasted < 32) { >> - int i; >> - for (i = 0; i < s->blocksize; i++) >> - decoded[i] = (unsigned)decoded[i] << wasted; >> + s->dsp.wasted32(decoded, wasted, s->blocksize); >> } >> } >> >> diff --git a/libavcodec/flacdsp.c b/libavcodec/flacdsp.c >> index 71b4ac44aa..610831348a 100644 >> --- a/libavcodec/flacdsp.c >> +++ b/libavcodec/flacdsp.c >> @@ -84,11 +84,31 @@ static void flac_lpc_32_c(int32_t *decoded, const int coeffs[32], >> >> } >> >> +static void flac_wasted_32_c(int32_t *decoded, int wasted, int len) >> +{ >> + int i; >> + >> + for (i = 0; i < len; i++) >> + decoded[i] = (unsigned)decoded[i] << wasted; >> +} >> + >> +static void flac_wasted_33_c(int64_t *decoded, const int32_t *residual, >> + int wasted, int len) >> +{ >> + int i; >> + >> + for (i = 0; i < len; i++) > > for (int i = 0 Fixed locally. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".