From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D40B346421 for ; Tue, 13 Feb 2024 17:25:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2387468D142; Tue, 13 Feb 2024 19:25:43 +0200 (EET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F87468CC87 for ; Tue, 13 Feb 2024 19:25:36 +0200 (EET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d51ba18e1bso45058345ad.0 for ; Tue, 13 Feb 2024 09:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707845133; x=1708449933; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gArDxk+Wz8tQPwZQDlHHlU6Pvo42cYhIsmq/HeXzpkQ=; b=XSvFOKIaWIVsf1JLfEuR5yRVs4ji4RQwJQ5WGh9Fgou6EIpMxJ2ZkSCIwToWtYN1re O6ZglNNNgWhGNbIN8AGD/P5sYs+gLGj7/t+/2Mt/yn6aApArtb7DEfnm3hyQnHsxBhi6 UyMIqLo8FVKS4lOVTGbWDMyu1bB/vncodDY5dE0WdY++2NCtVE2mSdPaOA6tJIAG+RTW 30ms+s4odCD1RTabOYTEBJNBy7bXBEdeb0WvkS6YW+ZTrlyM87Tm1e4jtemD9AR6wuGr n3u3LXVA87ZrJyczHxOaCmnEXP0qLpqTpVmrjkKKPxFkxen1x3DmP9qVbDvDrRcfUFvg CBUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707845133; x=1708449933; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gArDxk+Wz8tQPwZQDlHHlU6Pvo42cYhIsmq/HeXzpkQ=; b=wOeqRWERIcwmu58fqL0zu8oLmfBhT90hXiwMC5j4uPSinDCSnDiayuFNw3+K0+Jo5/ sCKtr0c4FbTvvgOUGyex1+J92qDKNYR9Jm3Fkhrr+7ZSXt8ftARjrtdRwPXLhU37t9zd ASbpSDnI8o7Nu63Q+cB7hh6aCUP11DrZTmICxrKBv6WautOZ/RZq1N+/bVPbUpQDru+Q AY4iz8sqPZeVgamCFNF0dGcpDHTDhlzT5ZGA4Ns/8kS6IfVHXHpEfh7Rf/UqX8cnsQpL bEgIFKDF5SEJGzoCP9rBJO+U44xXkyNw0c3lCYo8cRy9xysfCIHUNBayGNJ+6DliUJwT BPXA== X-Gm-Message-State: AOJu0YzkQLzB5I0Wd0gTGvzIQIRZCS7k7XaK5PyVZglPL1PDBU9rBxIG Vf+Z1SxeLg1PPs28rdQkgZPypmZVadVuq0fc+xeAsRx/1tzox8++XCZ9zH1f X-Google-Smtp-Source: AGHT+IEWs8xs1CdtuPMEG9c7DCgZGGtcltAtPzUwOqZ10XzCkAudLy5L/95XSbPCMjr38YM1iHT7mQ== X-Received: by 2002:a17:902:e889:b0:1db:29a7:65c3 with SMTP id w9-20020a170902e88900b001db29a765c3mr152792plg.64.1707845133204; Tue, 13 Feb 2024 09:25:33 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id e6-20020a170902b78600b001db3a0c52b1sm1390466pls.88.2024.02.13.09.25.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Feb 2024 09:25:32 -0800 (PST) Message-ID: <68db378c-53a5-4288-a94e-627588d02baa@gmail.com> Date: Tue, 13 Feb 2024 14:25:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240212211537.18468-1-cus@passwd.hu> <20240212211537.18468-2-cus@passwd.hu> From: James Almer In-Reply-To: <20240212211537.18468-2-cus@passwd.hu> Subject: Re: [FFmpeg-devel] [PATCH 2/5] avutil/channel_layout: add AV_CHANNEL_ORDER_NB X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/12/2024 6:15 PM, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/channel_layout.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h > index b8bff6f365..db0c005e87 100644 > --- a/libavutil/channel_layout.h > +++ b/libavutil/channel_layout.h > @@ -146,6 +146,10 @@ enum AVChannelOrder { > * as defined in AmbiX format $ 2.1. > */ > AV_CHANNEL_ORDER_AMBISONIC, > + /** > + * Number of channel orders, not part of ABI/API > + */ > + AV_CHANNEL_ORDER_NB > }; Is it worth adding this to a public header just to limit a loop in a test? A loop that fwiw still depends on an array that needs to be updated with more names if you add new orders. IMO, just do FF_ARRAY_ELEMS(channel_order_names) in the test. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".