Re: [FFmpeg-devel] [PATCH 2/5] avutil/channel_layout: add AV_CHANNEL_ORDER_NB

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/5] avutil/channel_layout: add AV_CHANNEL_ORDER_NB
Date: Tue, 13 Feb 2024 14:25:35 -0300
Message-ID: <68db378c-53a5-4288-a94e-627588d02baa@gmail.com> (raw)
In-Reply-To: <20240212211537.18468-2-cus@passwd.hu>

On 2/12/2024 6:15 PM, Marton Balint wrote:
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>   libavutil/channel_layout.h | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h
> index b8bff6f365..db0c005e87 100644
> --- a/libavutil/channel_layout.h
> +++ b/libavutil/channel_layout.h
> @@ -146,6 +146,10 @@ enum AVChannelOrder {
>        * as defined in AmbiX format $ 2.1.
>        */
>       AV_CHANNEL_ORDER_AMBISONIC,
> +    /**
> +     * Number of channel orders, not part of ABI/API
> +     */
> +    AV_CHANNEL_ORDER_NB
>   };

Is it worth adding this to a public header just to limit a loop in a 
test? A loop that fwiw still depends on an array that needs to be 
updated with more names if you add new orders.

IMO, just do FF_ARRAY_ELEMS(channel_order_names) in the test.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".