* [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior @ 2024-03-12 22:36 Stone Chen 2024-03-13 8:26 ` Marton Balint 0 siblings, 1 reply; 6+ messages in thread From: Stone Chen @ 2024-03-12 22:36 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Stone Chen The documentation correctly states that the rdiv is a multiplier but incorrectly states the default behavior is to multiply by the sum of all matrix elements - it multiplies by 1/sum. This changes the documentation to match the code. --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index e0436a5755..913365671d 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -10497,7 +10497,7 @@ and from 1 to 49 odd number of signed integers in @var{row} mode. @item 2rdiv @item 3rdiv Set multiplier for calculated value for each plane. -If unset or 0, it will be sum of all matrix elements. +If unset or 0, it will be 1/sum of all matrix elements. @item 0bias @item 1bias -- 2.44.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior 2024-03-12 22:36 [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior Stone Chen @ 2024-03-13 8:26 ` Marton Balint 2024-03-13 16:03 ` Stone Chen 0 siblings, 1 reply; 6+ messages in thread From: Marton Balint @ 2024-03-13 8:26 UTC (permalink / raw) To: FFmpeg development discussions and patches On Tue, 12 Mar 2024, Stone Chen wrote: > The documentation correctly states that the rdiv is a multiplier but incorrectly states the default behavior is to multiply by the sum of all matrix elements - it multiplies by 1/sum. > > This changes the documentation to match the code. Please mention in the commit message the ticket number this patch fixes. Thanks, Marton > --- > doc/filters.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index e0436a5755..913365671d 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -10497,7 +10497,7 @@ and from 1 to 49 odd number of signed integers in @var{row} mode. > @item 2rdiv > @item 3rdiv > Set multiplier for calculated value for each plane. > -If unset or 0, it will be sum of all matrix elements. > +If unset or 0, it will be 1/sum of all matrix elements. > > @item 0bias > @item 1bias > -- > 2.44.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior 2024-03-13 8:26 ` Marton Balint @ 2024-03-13 16:03 ` Stone Chen 2024-03-13 19:23 ` Marton Balint 0 siblings, 1 reply; 6+ messages in thread From: Stone Chen @ 2024-03-13 16:03 UTC (permalink / raw) To: FFmpeg development discussions and patches On Wed, Mar 13, 2024 at 4:26 AM Marton Balint <cus@passwd.hu> wrote: > > > On Tue, 12 Mar 2024, Stone Chen wrote: > > > The documentation correctly states that the rdiv is a multiplier but > incorrectly states the default behavior is to multiply by the sum of all > matrix elements - it multiplies by 1/sum. > > > > This changes the documentation to match the code. > > Please mention in the commit message the ticket number this patch fixes. > > Thanks, > Marton > Hi Marton, I just noticed that the ticket was closed https://trac.ffmpeg.org/ticket/10294 (Michael Koch's comment re: docs). Should I open a new ticket? Cheers Stone > > --- > > doc/filters.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/doc/filters.texi b/doc/filters.texi > > index e0436a5755..913365671d 100644 > > --- a/doc/filters.texi > > +++ b/doc/filters.texi > > @@ -10497,7 +10497,7 @@ and from 1 to 49 odd number of signed integers > in @var{row} mode. > > @item 2rdiv > > @item 3rdiv > > Set multiplier for calculated value for each plane. > > -If unset or 0, it will be sum of all matrix elements. > > +If unset or 0, it will be 1/sum of all matrix elements. > > > > @item 0bias > > @item 1bias > > -- > > 2.44.0 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior 2024-03-13 16:03 ` Stone Chen @ 2024-03-13 19:23 ` Marton Balint 2024-03-14 16:47 ` [FFmpeg-devel] [PATCH] doc/filters: " Stone Chen 0 siblings, 1 reply; 6+ messages in thread From: Marton Balint @ 2024-03-13 19:23 UTC (permalink / raw) To: FFmpeg development discussions and patches On Wed, 13 Mar 2024, Stone Chen wrote: > On Wed, Mar 13, 2024 at 4:26 AM Marton Balint <cus@passwd.hu> wrote: > >> >> >> On Tue, 12 Mar 2024, Stone Chen wrote: >> >> > The documentation correctly states that the rdiv is a multiplier but >> incorrectly states the default behavior is to multiply by the sum of all >> matrix elements - it multiplies by 1/sum. >> > >> > This changes the documentation to match the code. >> >> Please mention in the commit message the ticket number this patch fixes. >> >> Thanks, >> Marton >> > > Hi Marton, > > I just noticed that the ticket was closed > https://trac.ffmpeg.org/ticket/10294 (Michael Koch's comment re: docs). There is a new ticket for the documentation issue, ticket #10889. Please mention that in the message. Thanks, Marton > > Should I open a new ticket? > > Cheers > Stone > > >> > --- >> > doc/filters.texi | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/doc/filters.texi b/doc/filters.texi >> > index e0436a5755..913365671d 100644 >> > --- a/doc/filters.texi >> > +++ b/doc/filters.texi >> > @@ -10497,7 +10497,7 @@ and from 1 to 49 odd number of signed integers >> in @var{row} mode. >> > @item 2rdiv >> > @item 3rdiv >> > Set multiplier for calculated value for each plane. >> > -If unset or 0, it will be sum of all matrix elements. >> > +If unset or 0, it will be 1/sum of all matrix elements. >> > >> > @item 0bias >> > @item 1bias >> > -- >> > 2.44.0 >> > >> > _______________________________________________ >> > ffmpeg-devel mailing list >> > ffmpeg-devel@ffmpeg.org >> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > >> > To unsubscribe, visit link above, or email >> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH] doc/filters: Change rdiv (vf_convolution) documentation to reflect actual behavior 2024-03-13 19:23 ` Marton Balint @ 2024-03-14 16:47 ` Stone Chen 2024-03-16 21:05 ` Marton Balint 0 siblings, 1 reply; 6+ messages in thread From: Stone Chen @ 2024-03-14 16:47 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Stone Chen The documentation correctly states that the rdiv is a multiplier but incorrectly states the default behavior is to multiply by the sum of all matrix elements - it multiplies by 1/sum. This changes the documentation to match the code. Address trac #10889 --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index e0436a5755..913365671d 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -10497,7 +10497,7 @@ and from 1 to 49 odd number of signed integers in @var{row} mode. @item 2rdiv @item 3rdiv Set multiplier for calculated value for each plane. -If unset or 0, it will be sum of all matrix elements. +If unset or 0, it will be 1/sum of all matrix elements. @item 0bias @item 1bias -- 2.44.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] doc/filters: Change rdiv (vf_convolution) documentation to reflect actual behavior 2024-03-14 16:47 ` [FFmpeg-devel] [PATCH] doc/filters: " Stone Chen @ 2024-03-16 21:05 ` Marton Balint 0 siblings, 0 replies; 6+ messages in thread From: Marton Balint @ 2024-03-16 21:05 UTC (permalink / raw) To: FFmpeg development discussions and patches On Thu, 14 Mar 2024, Stone Chen wrote: > The documentation correctly states that the rdiv is a multiplier but incorrectly states the default behavior is to multiply by the sum of all matrix elements - it multiplies by 1/sum. > > This changes the documentation to match the code. > > Address trac #10889 > --- > doc/filters.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index e0436a5755..913365671d 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -10497,7 +10497,7 @@ and from 1 to 49 odd number of signed integers in @var{row} mode. > @item 2rdiv > @item 3rdiv > Set multiplier for calculated value for each plane. > -If unset or 0, it will be sum of all matrix elements. > +If unset or 0, it will be 1/sum of all matrix elements. > > @item 0bias > @item 1bias > -- > 2.44.0 > Will apply. Thanks, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-16 21:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-03-12 22:36 [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior Stone Chen 2024-03-13 8:26 ` Marton Balint 2024-03-13 16:03 ` Stone Chen 2024-03-13 19:23 ` Marton Balint 2024-03-14 16:47 ` [FFmpeg-devel] [PATCH] doc/filters: " Stone Chen 2024-03-16 21:05 ` Marton Balint
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git