From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/1] librtmp: use AVBPrint instead of char *
Date: Wed, 13 Apr 2022 21:39:57 +0200 (CEST)
Message-ID: <6864afc-a8db-bb8-863a-e13d89a67751@passwd.hu> (raw)
In-Reply-To: <1f46ce37-ff15-3065-4f99-244915d4aefc@martin.st>
On Wed, 13 Apr 2022, Martin Storsjö wrote:
> On Mon, 11 Apr 2022, Tristan Matthews wrote:
>
>> This avoids having to do one pass to calculate the full length to allocate
>> followed by a second pass to actually append values.
>> ---
>> libavformat/librtmp.c | 123 +++++++++++-------------------------------
>> 1 file changed, 32 insertions(+), 91 deletions(-)
>
> Thanks, this patch looks good to me. I'll wait for a little while still if
> Marton wants to comment on it, before I go ahead and push it.
According to commit 865461099e062de5a3a109c2a5be98004c11d8bd the buffer
passed to RTMP_SetupURL has to be kept as long as the RTMP context is
alive.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-04-13 19:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 5:11 [FFmpeg-devel] [PATCH 1/1] librtmp: make flashVer case consistent Tristan Matthews
2022-04-09 18:45 ` Marton Balint
2022-04-11 15:48 ` Tristan Matthews
2022-04-11 15:49 ` [FFmpeg-devel] [PATCH 1/1] librtmp: use AVBPrint instead of char * Tristan Matthews
2022-04-13 8:52 ` Martin Storsjö
2022-04-13 19:39 ` Marton Balint [this message]
2022-04-13 20:02 ` Martin Storsjö
2022-04-15 11:51 ` Tristan Matthews
2022-04-15 11:53 ` Tristan Matthews
2022-04-16 20:06 ` Martin Storsjö
2022-04-18 22:06 ` Marton Balint
2022-04-19 20:22 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6864afc-a8db-bb8-863a-e13d89a67751@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git