From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7E430403A8 for ; Sat, 23 Apr 2022 20:52:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4B82268B383; Sat, 23 Apr 2022 23:52:01 +0300 (EEST) Received: from relay.yourmailgateway.de (relay.yourmailgateway.de [188.68.63.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5C11868B15E for ; Sat, 23 Apr 2022 23:51:54 +0300 (EEST) Received: from mors-relay8204.netcup.net (localhost [127.0.0.1]) by mors-relay8204.netcup.net (Postfix) with ESMTPS id 4Km3Nn3XCmz8Xrw for ; Sat, 23 Apr 2022 20:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lisanet.de; s=key2; t=1650747113; bh=41Tg4TRiCxhN1LGTG52JkDmquE27dM1Q104E7F+6jiw=; h=From:Subject:Date:References:To:In-Reply-To:From; b=dQvwvkURSBsDprdqUGW8ur2+pi4Pqm+B3GBPT2cIyVcySAbC83Wbug7SWzxNrlnHI x4eR3B1Ka9t30gwSGmZArzTxZayBbCCJkjBqUpqsRdOZroCYMVOSjMMMvJWFM/B2Fk fCH/fYIhRMpB7Fbw1gt/TXqAdvfdyyLyV7aOK+LMSQPtPGv0rAl9iBlJzfHEN4Ijvu g2Vc6OZJgK+UhKBf20PuE8PzJCuy9MjaydsmgTf9oQku3DPobY5yJrUUPuJeAMJAa2 LunyXV1yo52KwA3zABzymp7C5F6icNmqVBGlDBkrdmPZh0+0EbpUY0AkhsG1nSxTB1 YdMe/qp5vVzeA== Received: from policy02-mors.netcup.net (unknown [46.38.225.53]) by mors-relay8204.netcup.net (Postfix) with ESMTPS id 4Km3Nn37zTz8Xrv for ; Sat, 23 Apr 2022 20:51:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net X-Spam-Flag: NO X-Spam-Score: -2.9 X-Spam-Level: X-Spam-Status: No, score=-2.9 required=6.31 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx2f68.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4Km3Nm56Rzz8sZD for ; Sat, 23 Apr 2022 22:51:52 +0200 (CEST) Received: from smtpclient.apple (ip-046-005-115-148.um12.pools.vodafone-ip.de [46.5.115.148]) by mx2f68.netcup.net (Postfix) with ESMTPSA id D820BA0BD5 for ; Sat, 23 Apr 2022 22:51:51 +0200 (CEST) Authentication-Results: mx2f68; spf=pass (sender IP is 46.5.115.148) smtp.mailfrom=simone@lisanet.de smtp.helo=smtpclient.apple Received-SPF: pass (mx2f68: connection is authenticated) From: Simone Karin Lehmann Content-Type: multipart/mixed; boundary="Apple-Mail=_030C269C-5AD2-4EC1-A99D-2B8B0188852F" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Date: Sat, 23 Apr 2022 22:51:51 +0200 References: <80886934-2099-4FE0-A95D-F9B6658F777F@lisanet.de> <5D3ED34A-A9B8-4870-B6C1-D462B086BC37@lisanet.de> <95e8daf2-9011-6622-a48f-cd1c89dea6c0@mail.de> <33796369-1344-4A5D-B429-0719D1DF2601@lisanet.de> <3A858537-49E7-41C0-84EF-618E77C7A17E@lisanet.de> <450ff0e8-2535-cbf9-892f-57272d511ef4@mail.de> <230DADFB-2E38-4FF6-942D-5F8DC6B1DD2D@lisanet.de> To: FFmpeg development discussions and patches In-Reply-To: Message-Id: <6827C764-5D9B-4A7E-9CBA-20C87873D29A@lisanet.de> X-Mailer: Apple Mail (2.3696.80.82.1.1) X-PPP-Message-ID: <165074711221.9952.12018226951550615719@mx2f68.netcup.net> X-PPP-Vhost: lisanet.de X-NC-CID: RrkFlo4m2fWB65er767zrI3YHahrT00UxNINcX9Zsyda Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --Apple-Mail=_030C269C-5AD2-4EC1-A99D-2B8B0188852F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Am 23.04.2022 um 21:56 schrieb Thilo Borgmann = : >=20 > Am 23.04.22 um 17:42 schrieb Simone Karin Lehmann: >>> Am 23.04.2022 um 17:07 schrieb Thilo Borgmann = : >>>=20 >>>=20 >>> If that works I'd be happy. Does not apply for me anymore (on HEAD), = though? >>>=20 >>>=20 >> hhmm, the patch applies for me on current HEAD. I=E2=80=99ve tested = it a few moments ago on a fresh downloaded git snapshot. >> Maybe a former patch from me still there in your source tree? >=20 > Also cloned into a new one, but corrupt @75: >=20 Weird. Apple Mail seems to somehow change the encoding of the mail and I = couldn=E2=80=99t get the *.eml to apply correctly too. Never encountered = that before.=20 I've attached the patch as a file. Hope that=E2=80=99s ok on this = mailing list. Sorry for the inconvenience. Simone --Apple-Mail=_030C269C-5AD2-4EC1-A99D-2B8B0188852F Content-Disposition: attachment; filename=0001-add-options-to-h264-hevc-and-prores-encoders-to-prio.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-add-options-to-h264-hevc-and-prores-encoders-to-prio.patch" Content-Transfer-Encoding: quoted-printable =46rom=203d99b738e1a398a2ada437897083392bbc475f78=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Simone=20Karin=20Lehmann=20=0A= Date:=20Sat,=2023=20Apr=202022=2014:12:53=20+0200=0ASubject:=20[PATCH]=20= add=20options=20to=20h264,=20hevc=20and=20prores=20encoders=20to=20= prioritize=0A=20speed.=20Speeds=20up=20encoding=20by=2050%=20-=2070%=0A=0A= Signed-off-by:=20Simone=20Karin=20Lehmann=20=0A---=0A=20= libavcodec/videotoolboxenc.c=20|=2018=20++++++++++++++++++=0A=201=20file=20= changed,=2018=20insertions(+)=0A=0Adiff=20--git=20= a/libavcodec/videotoolboxenc.c=20b/libavcodec/videotoolboxenc.c=0Aindex=20= 270496b7a7..462d2a8fb6=20100644=0A---=20a/libavcodec/videotoolboxenc.c=0A= +++=20b/libavcodec/videotoolboxenc.c=0A@@=20-100,6=20+100,7=20@@=20= static=20struct{=0A=20=0A=20=20=20=20=20CFStringRef=20= kVTCompressionPropertyKey_RealTime;=0A=20=20=20=20=20CFStringRef=20= kVTCompressionPropertyKey_TargetQualityForAlpha;=0A+=20=20=20=20= CFStringRef=20= kVTCompressionPropertyKey_PrioritizeEncodingSpeedOverQuality;=0A=20=0A=20= =20=20=20=20CFStringRef=20= kVTVideoEncoderSpecification_EnableHardwareAcceleratedVideoEncoder;=0A=20= =20=20=20=20CFStringRef=20= kVTVideoEncoderSpecification_RequireHardwareAcceleratedVideoEncoder;=0A= @@=20-161,6=20+162,8=20@@=20static=20void=20loadVTEncSymbols(){=0A=20=20=20= =20=20GET_SYM(kVTCompressionPropertyKey_RealTime,=20"RealTime");=0A=20=20= =20=20=20GET_SYM(kVTCompressionPropertyKey_TargetQualityForAlpha,=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20"TargetQualityForAlpha");=0A+=20=20=20=20= GET_SYM(kVTCompressionPropertyKey_PrioritizeEncodingSpeedOverQuality,=0A= +=20=20=20=20=20=20=20=20=20=20=20=20= "PrioritizeEncodingSpeedOverQuality");=0A=20=0A=20=20=20=20=20= GET_SYM(kVTVideoEncoderSpecification_EnableHardwareAcceleratedVideoEncoder= ,=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= "EnableHardwareAcceleratedVideoEncoder");=0A@@=20-237,6=20+240,7=20@@=20= typedef=20struct=20VTEncContext=20{=0A=20=20=20=20=20int=20allow_sw;=0A=20= =20=20=20=20int=20require_sw;=0A=20=20=20=20=20double=20alpha_quality;=0A= +=20=20=20=20int=20prio_speed;=0A=20=0A=20=20=20=20=20bool=20flushing;=0A= =20=20=20=20=20int=20has_b_frames;=0A@@=20-1146,6=20+1150,16=20@@=20= static=20int=20vtenc_create_encoder(AVCodecContext=20=20=20*avctx,=0A=20=20= =20=20=20=20=20=20=20return=20AVERROR_EXTERNAL;=0A=20=20=20=20=20}=0A=20=0A= +=20=20=20=20//=20prioritize=20speed=20over=20quality=0A+=20=20=20=20if=20= (vtctx->prio_speed)=20{=0A+=20=20=20=20=20=20=20=20status=20=3D=20= VTSessionSetProperty(vtctx->session,=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20= compat_keys.kVTCompressionPropertyKey_PrioritizeEncodingSpeedOverQuality,=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20kCFBooleanTrue);=0A+=20=20=20=20= =20=20=20=20if=20(status)=20{=0A+=20=20=20=20=20=20=20=20=20=20=20=20= av_log(avctx,=20AV_LOG_WARNING,=20"PrioritizeEncodingSpeedOverQuality=20= property=20is=20not=20supported=20on=20this=20device.=20Ignoring.\n");=0A= +=20=20=20=20=20=20=20=20}=0A+=20=20=20=20}=0A+=0A=20=20=20=20=20if=20= ((vtctx->codec_id=20=3D=3D=20AV_CODEC_ID_H264=20||=20vtctx->codec_id=20= =3D=3D=20AV_CODEC_ID_HEVC)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20&&=20= max_rate=20>=200)=20{=0A=20=20=20=20=20=20=20=20=20= bytes_per_second_value=20=3D=20max_rate=20>>=203;=0A@@=20-2711,6=20= +2725,7=20@@=20static=20const=20AVOption=20h264_options[]=20=3D=20{=0A=20= =20=20=20=20{=20"ac",=20=20=20=20"CABAC=20entropy=20coding",=200,=20= AV_OPT_TYPE_CONST,=20{=20.i64=20=3D=20VT_CABAC=20},=20INT_MIN,=20= INT_MAX,=20VE,=20"coder"=20},=0A=20=0A=20=20=20=20=20{=20"a53cc",=20"Use=20= A53=20Closed=20Captions=20(if=20available)",=20OFFSET(a53_cc),=20= AV_OPT_TYPE_BOOL,=20{.i64=20=3D=201},=200,=201,=20VE=20},=0A+=20=20=20=20= {=20"prio_speed",=20"prioritize=20encoding=20speed",=20= OFFSET(prio_speed),=20AV_OPT_TYPE_BOOL,=20{=20.i64=20=3D=200=20},=200,=20= 1,=20VE=20},=0A=20=0A=20=20=20=20=20COMMON_OPTIONS=0A=20=20=20=20=20{=20= NULL=20},=0A@@=20-2745,6=20+2760,7=20@@=20static=20const=20AVOption=20= hevc_options[]=20=3D=20{=0A=20=20=20=20=20{=20"main10",=20=20=20"Main10=20= Profile",=20=20=200,=20AV_OPT_TYPE_CONST,=20{=20.i64=20=3D=20= HEVC_PROF_MAIN10=20},=20INT_MIN,=20INT_MAX,=20VE,=20"profile"=20},=0A=20=0A= =20=20=20=20=20{=20"alpha_quality",=20"Compression=20quality=20for=20the=20= alpha=20channel",=20OFFSET(alpha_quality),=20AV_OPT_TYPE_DOUBLE,=20{=20= .dbl=20=3D=200.0=20},=200.0,=201.0,=20VE=20},=0A+=20=20=20=20{=20= "prio_speed",=20"prioritize=20encoding=20speed",=20OFFSET(prio_speed),=20= AV_OPT_TYPE_BOOL,=20{=20.i64=20=3D=200=20},=200,=201,=20VE=20},=0A=20=0A=20= =20=20=20=20COMMON_OPTIONS=0A=20=20=20=20=20{=20NULL=20},=0A@@=20-2785,6=20= +2801,8=20@@=20static=20const=20AVOption=20prores_options[]=20=3D=20{=0A=20= =20=20=20=20{=20"4444",=20=20=20=20=20"ProRes=204444",=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=200,=20AV_OPT_TYPE_CONST,=20{=20.i64=20=3D=20= FF_PROFILE_PRORES_4444=20},=20=20=20=20=20=20=20=20INT_MIN,=20INT_MAX,=20= VE,=20"profile"=20},=0A=20=20=20=20=20{=20"xq",=20=20=20=20=20=20=20= "ProRes=204444=20XQ",=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=200,=20AV_OPT_TYPE_CONST,=20{=20= .i64=20=3D=20FF_PROFILE_PRORES_XQ=20},=20=20=20=20=20=20=20=20=20=20= INT_MIN,=20INT_MAX,=20VE,=20"profile"=20},=0A=20=0A+=20=20{=20= "prio_speed",=20"prioritize=20encoding=20speed",=20OFFSET(prio_speed),=20= AV_OPT_TYPE_BOOL,=20{=20.i64=20=3D=201=20},=200,=201,=20VE=20},=0A+=0A=20= =20=20=20=20COMMON_OPTIONS=0A=20=20=20=20=20{=20NULL=20},=0A=20};=0A--=20= =0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_030C269C-5AD2-4EC1-A99D-2B8B0188852F Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --Apple-Mail=_030C269C-5AD2-4EC1-A99D-2B8B0188852F--