From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B2EEF40EE7 for ; Sat, 12 Mar 2022 15:12:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ABD5C68B1EB; Sat, 12 Mar 2022 17:12:07 +0200 (EET) Received: from server172-4.web-hosting.com (unknown [68.65.122.112]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9970A680CB2 for ; Sat, 12 Mar 2022 17:12:01 +0200 (EET) Received: from pool-71-105-192-158.nycmny.fios.verizon.net ([71.105.192.158]:59059 helo=smtpclient.apple) by server172.web-hosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nT3PN-004Bfb-RE for ffmpeg-devel@ffmpeg.org; Sat, 12 Mar 2022 10:11:58 -0500 From: Dave Rice Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Date: Sat, 12 Mar 2022 10:11:52 -0500 References: <20220309181819.22709-1-michael@niedermayer.cc> <9f977790-8d18-c4e7-18b9-b4ae2604e318@noa-archive.com> To: FFmpeg development discussions and patches In-Reply-To: <9f977790-8d18-c4e7-18b9-b4ae2604e318@noa-archive.com> Message-Id: <68221FD8-0816-4971-808D-D54BCBDD35EC@dericed.com> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-OutGoing-Spam-Status: No, score=-0.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server172.web-hosting.com X-AntiAbuse: Original Domain - ffmpeg.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - dericed.com X-Get-Message-Sender-Via: server172.web-hosting.com: authenticated_id: dave@dericed.com X-Authenticated-Sender: server172.web-hosting.com: dave@dericed.com X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec: Add dv marker bsf X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Mar 10, 2022, at 4:41 AM, Tobias Rapp wrote: > > On 09/03/2022 19:18, Michael Niedermayer wrote: >> Signed-off-by: Michael Niedermayer >> --- >> doc/bitstream_filters.texi | 30 ++++++++ >> libavcodec/Makefile | 1 + >> libavcodec/bitstream_filters.c | 1 + >> libavcodec/dv_error_marker_bsf.c | 127 +++++++++++++++++++++++++++++++ >> 4 files changed, 159 insertions(+) >> create mode 100644 libavcodec/dv_error_marker_bsf.c >> diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi >> index a0092878c8..8c5d84dceb 100644 >> --- a/doc/bitstream_filters.texi >> +++ b/doc/bitstream_filters.texi >> @@ -132,6 +132,36 @@ the header stored in extradata to the key packets: >> ffmpeg -i INPUT -map 0 -flags:v +global_header -c:v libx264 -bsf:v dump_extra out.ts >> @end example >> +@section dv_error_marker >> + >> +Blocks in DV which are marked as damaged are replaced by blocks of the specified color. >> + >> +@table @option >> +@item color >> +The color to replace damaged blocks by >> +@item sta >> +A 16 bit mask which specifies which of the 16 possible error status values are >> +to be replaced by colored blocks. 0xFFFE is the default which replaces all non 0 >> +error status values. >> +@table @samp >> +@item ok >> +No error, no concealment >> +@item err >> +Error, No concealment >> +@item res >> +Reserved >> +@item notok >> +Error or concealment >> +@item notres >> +Not reserved >> +@item Aa, Ba, Ca, Ab, Bb, Cb, A, B, C, a, b, erri, erru >> +The specific error status code >> +@end table >> +see page 44-46 or section 5.5 of >> +@url{http://web.archive.org/web/20060927044735/http://www.smpte.org/smpte_store/standards/pdf/s314m.pdf} >> + >> +@end table >> + >> @section eac3_core >> [...] > The filter options look nice to me now. Have not actually tested the bitstream filter on DV files, though. I tested this and this works well for me. Here's a few samples that demonstrate the filter: ./ffmpeg -i https://samples.ffmpeg.org/archive/audio/pcm_s16le/dv+dvvideo+pcm_s16le++dropout.dv -bsf dv_error_marker=sta=b -f rawvideo -c:v copy - | ffplay - ./ffmpeg -i https://archive.org/download/DvAnalyzerSampleDvVideoErrorConcealment/DV_Analyzer_Sample_Video_Error_Concealment_original.dv -bsf dv_error_marker=sta=b -f rawvideo -c:v copy - | ffplay - Dave Rice _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".