From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 44B1A42255 for ; Tue, 1 Mar 2022 11:18:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4053B68B221; Tue, 1 Mar 2022 13:18:17 +0200 (EET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E20768AFE1 for ; Tue, 1 Mar 2022 13:18:10 +0200 (EET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B5BED5C0150 for ; Tue, 1 Mar 2022 06:18:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 01 Mar 2022 06:18:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itanimul.li; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=gI2x3ldWDxAYMO NiFB8Lm0WOZthovezKeQ8/3XJnVjA=; b=l5vEdKpWw960Icaa8ettx+TB70S2BH ivJuQ1JySitObIUV/OiN7NtzJSkod7kgevsa8TO/cpuU74jIuSsFn5mitAz8JUr4 scCbJJT/hxw8AqFulfF+Es//l9aaQ3wV1uggVLdyxL+zz/Mei1LtdMYIc8iyZHAb q702atwJ4pX5DGJL8BlnATifXD+Qn0MiIpAiN5WtdJVu7ERGir8VvCZ1Tq1wdbGl XUw+NCXYKACmZ5fPlALsvIJKsDpvNyKrl0SVenSguZ1j5KsI5EqOLbeGcy0HLuWf aFRus4ilwG+nX/FH+LjckAOyJiTvPvNFTK2R/cyzTXC6uVTxrVmvo7zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=gI2x3ldWDxAYMONiFB8Lm0WOZthovezKeQ8/3XJnVjA=; b=BrebBfuU BaZUfsCnn2KT4qgF1fVQ3J0E/P/YR8HMSGlMDNMrxix1X+yc02RpLolF0elsP+jm YRmVn0zP3mQt80i4xb+BbxL2PEjD5M5wpNuJF+jhbSgzyIfTUwt3KIRiKnD5ssnV 0UE+zda/JYviOQZVph6Urjm3EQym7H33pG3czevoZKFSNQUxORvSfCLIAtXXk1lt bTlVJ/U26ssSokEEEzycYKOPzMBUOaXxBFLdgwZlccW34DK9RNEaJxG2h0caBu1s 9eCmRKOVv8MAHF23Bbo7c6C0RQPXK70X6fBbEEsfxyI+QCKwbOKSfzwiIKyJuHZz R/7SjZyTD+zzjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddtvddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffoffkjghfgggtgfesthhqmhdtredttdenucfhrhhomhepfdflrdcu ffgvkhhkvghrfdcuoehjuggvkhesihhtrghnihhmuhhlrdhliheqnecuggftrfgrthhtvg hrnhepvdegieevtedvtddthfeggfduieetvdfhuddvteevteegudegveeliefhiedtleej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhguvg hksehithgrnhhimhhulhdrlhhi X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 1 Mar 2022 06:18:07 -0500 (EST) From: "J. Dekker" To: FFmpeg development discussions and patches Date: Tue, 01 Mar 2022 12:17:55 +0100 X-Mailer: MailMate Trial (1.14r5852) Message-ID: <681602CB-C6AD-441B-BF96-20FD8939BF12@itanimul.li> In-Reply-To: References: <20220216014930.21629-1-jdek@itanimul.li> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 24 Feb 2022, at 14:46, Nicolas George wrote: > Thilo Borgman (12022-02-24): >> Both LGTM. > > Does it? An earlier reply would have been helpful here, i.e. before an ACK rather than after. > The way I remember it, this condition was for the initial assembly, as a > temporary measure. I might have missed some steps, but I do not remember > we adopted this as a constant rule. > > I see several flaws with it: > > - Documentation patches were not counted, now they are. > > - Cosmetic patches are counted. > > - It does not take the size of the changes. > > Using an imperfect solution for bootstrap is one thing, using it > permanently is another. > It is only supposed to match the documentation. Of course, nothing says it can't be changed later when the 'bootstrap' process is completed (and let's consider that the last time this was actually discussed was in Tokyo, not sure what good delaying it further helps). You are welcome to send a patch to our documentation to clarify the rules if you think they are not correct. However, I personally think that any contribution to the project is useful and documentation & cosmetic improvements should not be penalized needlessly. -- J. Dekker _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".