[FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

[FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

[Carl Eugen Hoyos]

Hi!

Attached patch fixes ticket #9909 for me, regression since 4618f36a

Please comment, Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

[Carl Eugen Hoyos]

Am So., 11. Sept. 2022 um 16:17 Uhr schrieb Carl Eugen Hoyos
<ceffmpeg@gmail.com>:
>
> Attached patch fixes ticket #9909 for me, regression since 4618f36a

Sorry, it was bfb28b5ce89f3e950214b67ea95b45e3355c2caf

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

[Carl Eugen Hoyos]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

Am So., 11. Sept. 2022 um 16:26 Uhr schrieb James Almer <jamrial@gmail.com>:
>
> On 9/11/2022 11:17 AM, Carl Eugen Hoyos wrote:
> > Hi!
> >
> > Attached patch fixes ticket #9909 for me, regression since 4618f36a
> >
> > Please comment, Carl Eugen
>
> It would help if the patch was attached :p

Good point!

Carl Eugen

[-- Attachment #2: 0001-lavc-x86-simple_idct-Fix-linking-shared-libavcodec-w.patch --]
[-- Type: application/octet-stream, Size: 756 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

[James Almer]

On 9/11/2022 11:17 AM, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes ticket #9909 for me, regression since 4618f36a
> 
> Please comment, Carl Eugen

It would help if the patch was attached :p
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

[Andreas Rheinhardt]

Carl Eugen Hoyos:
> From 421041e7cd1bce8952756e60a0dd428f1618d75a Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ce.hoyos@grassfish.com>
> Date: Sun, 11 Sep 2022 16:02:09 +0200
> Subject: [PATCH] lavc/x86/simple_idct: Fix linking shared libavcodec with MS
>  link.exe
> 
> link.exe hangs on empty simple_idct.o
> 
> Fixes ticket #9909.
> ---
>  libavcodec/x86/simple_idct.asm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/x86/simple_idct.asm b/libavcodec/x86/simple_idct.asm
> index dcf0da6df1..982b2f0bbb 100644
> --- a/libavcodec/x86/simple_idct.asm
> +++ b/libavcodec/x86/simple_idct.asm
> @@ -25,9 +25,9 @@
>  
>  %include "libavutil/x86/x86util.asm"
>  
> -%if ARCH_X86_32
>  SECTION_RODATA
>  
> +%if ARCH_X86_32
>  cextern pb_80
>  
>  wm1010: dw 0, 0xffff, 0, 0xffff

Thanks for bisecting this. (I don't have a MSVC setup myself to do it.)
Looking at the patch makes me feel that the very same issue might happen
with simple_idct10.asm when one tries to link a 32bit build. IMO
modifying the Makefile to no longer build these files if they are empty
would be better.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

[Carl Eugen Hoyos]

Am So., 11. Sept. 2022 um 17:29 Uhr schrieb Andreas Rheinhardt
<andreas.rheinhardt@outlook.com>:
>
> Carl Eugen Hoyos:
> > From 421041e7cd1bce8952756e60a0dd428f1618d75a Mon Sep 17 00:00:00 2001
> > From: Carl Eugen Hoyos <ce.hoyos@grassfish.com>
> > Date: Sun, 11 Sep 2022 16:02:09 +0200
> > Subject: [PATCH] lavc/x86/simple_idct: Fix linking shared libavcodec with MS
> >  link.exe
> >
> > link.exe hangs on empty simple_idct.o
> >
> > Fixes ticket #9909.
> > ---
> >  libavcodec/x86/simple_idct.asm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/x86/simple_idct.asm b/libavcodec/x86/simple_idct.asm
> > index dcf0da6df1..982b2f0bbb 100644
> > --- a/libavcodec/x86/simple_idct.asm
> > +++ b/libavcodec/x86/simple_idct.asm
> > @@ -25,9 +25,9 @@
> >
> >  %include "libavutil/x86/x86util.asm"
> >
> > -%if ARCH_X86_32
> >  SECTION_RODATA
> >
> > +%if ARCH_X86_32
> >  cextern pb_80
> >
> >  wm1010: dw 0, 0xffff, 0, 0xffff
>
> Thanks for bisecting this. (I don't have a MSVC setup myself to do it.)

> Looking at the patch makes me feel that the very same issue might
> happen with simple_idct10.asm when one tries to link a 32bit build.

No, that works fine (32bit creates a symbol in the empty object files iiuc).

I will not look into another solution, I am happy if you find one.

Thank you, Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files

[Andreas Rheinhardt]

Should fix ticket #9909, fixing a regression since
bfb28b5ce89f3e950214b67ea95b45e3355c2caf.

Thanks to Carl Eugen Hoyos for analyzing the issue.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
This would be my solution. What do you think of it?

 libavcodec/x86/Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile
index 4e448623af..41ca864849 100644
--- a/libavcodec/x86/Makefile
+++ b/libavcodec/x86/Makefile
@@ -140,8 +140,11 @@ X86ASM-OBJS-$(CONFIG_QPELDSP)          += x86/qpeldsp.o                 \
 X86ASM-OBJS-$(CONFIG_RV34DSP)          += x86/rv34dsp.o
 X86ASM-OBJS-$(CONFIG_VC1DSP)           += x86/vc1dsp_loopfilter.o       \
                                           x86/vc1dsp_mc.o
-X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o           \
-                                          x86/simple_idct.o
+ifdef ARCH_X86_64
+X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o
+else
+X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct.o
+endif
 X86ASM-OBJS-$(CONFIG_VIDEODSP)         += x86/videodsp.o
 X86ASM-OBJS-$(CONFIG_VP3DSP)           += x86/vp3dsp.o
 X86ASM-OBJS-$(CONFIG_VP8DSP)           += x86/vp8dsp.o                  \
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files

[Carl Eugen Hoyos]

Am Mo., 12. Sept. 2022 um 17:04 Uhr schrieb Andreas Rheinhardt
<andreas.rheinhardt@outlook.com>:
>
> Should fix ticket #9909, fixing a regression since
> bfb28b5ce89f3e950214b67ea95b45e3355c2caf.
>
> Thanks to Carl Eugen Hoyos for analyzing the issue.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> This would be my solution. What do you think of it?

No objection but I do not consider this patch cleaner.

Thank you, Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files

[Andreas Rheinhardt]

Carl Eugen Hoyos:
> Am Mo., 12. Sept. 2022 um 17:04 Uhr schrieb Andreas Rheinhardt
> <andreas.rheinhardt@outlook.com>:
>>
>> Should fix ticket #9909, fixing a regression since
>> bfb28b5ce89f3e950214b67ea95b45e3355c2caf.
>>
>> Thanks to Carl Eugen Hoyos for analyzing the issue.
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>> This would be my solution. What do you think of it?
> 
> No objection but I do not consider this patch cleaner.
> 
> Thank you, Carl Eugen

Then please apply yours.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe

[Andreas Rheinhardt]

Carl Eugen Hoyos:
> From 421041e7cd1bce8952756e60a0dd428f1618d75a Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ce.hoyos@grassfish.com>
> Date: Sun, 11 Sep 2022 16:02:09 +0200
> Subject: [PATCH] lavc/x86/simple_idct: Fix linking shared libavcodec with MS
>  link.exe
> 
> link.exe hangs on empty simple_idct.o
> 
> Fixes ticket #9909.
> ---
>  libavcodec/x86/simple_idct.asm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/x86/simple_idct.asm b/libavcodec/x86/simple_idct.asm
> index dcf0da6df1..982b2f0bbb 100644
> --- a/libavcodec/x86/simple_idct.asm
> +++ b/libavcodec/x86/simple_idct.asm
> @@ -25,9 +25,9 @@
>  
>  %include "libavutil/x86/x86util.asm"
>  
> -%if ARCH_X86_32
>  SECTION_RODATA
>  
> +%if ARCH_X86_32
>  cextern pb_80
>  
>  wm1010: dw 0, 0xffff, 0, 0xffff

Will backport this to 5.1 tomorrow to fix issue #9980 unless there are
objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files

[Andreas Rheinhardt]

Andreas Rheinhardt:
> Should fix ticket #9909, fixing a regression since
> bfb28b5ce89f3e950214b67ea95b45e3355c2caf.
> 
> Thanks to Carl Eugen Hoyos for analyzing the issue.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> This would be my solution. What do you think of it?
> 
>  libavcodec/x86/Makefile | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile
> index 4e448623af..41ca864849 100644
> --- a/libavcodec/x86/Makefile
> +++ b/libavcodec/x86/Makefile
> @@ -140,8 +140,11 @@ X86ASM-OBJS-$(CONFIG_QPELDSP)          += x86/qpeldsp.o                 \
>  X86ASM-OBJS-$(CONFIG_RV34DSP)          += x86/rv34dsp.o
>  X86ASM-OBJS-$(CONFIG_VC1DSP)           += x86/vc1dsp_loopfilter.o       \
>                                            x86/vc1dsp_mc.o
> -X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o           \
> -                                          x86/simple_idct.o
> +ifdef ARCH_X86_64
> +X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o
> +else
> +X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct.o
> +endif
>  X86ASM-OBJS-$(CONFIG_VIDEODSP)         += x86/videodsp.o
>  X86ASM-OBJS-$(CONFIG_VP3DSP)           += x86/vp3dsp.o
>  X86ASM-OBJS-$(CONFIG_VP8DSP)           += x86/vp8dsp.o                  \

It seems like that there are linkers out there that complain about empty
object files like x86/simple_idct.o ("ranlib: file:
libavcodec/libavcodec.a(simple_idct.o) has no symbols" as reported by
BBB); the above patch is still needed to fix this. I will therefore
apply it tonight (with an updated commit message) unless there are
objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files

[Carl Eugen Hoyos]

Am Di., 13. Dez. 2022 um 16:02 Uhr schrieb Andreas Rheinhardt
<andreas.rheinhardt@outlook.com>:
>
> Andreas Rheinhardt:
> > Should fix ticket #9909, fixing a regression since
> > bfb28b5ce89f3e950214b67ea95b45e3355c2caf.
> >
> > Thanks to Carl Eugen Hoyos for analyzing the issue.
> >
> > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> > ---
> > This would be my solution. What do you think of it?
> >
> >  libavcodec/x86/Makefile | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile
> > index 4e448623af..41ca864849 100644
> > --- a/libavcodec/x86/Makefile
> > +++ b/libavcodec/x86/Makefile
> > @@ -140,8 +140,11 @@ X86ASM-OBJS-$(CONFIG_QPELDSP)          += x86/qpeldsp.o                 \
> >  X86ASM-OBJS-$(CONFIG_RV34DSP)          += x86/rv34dsp.o
> >  X86ASM-OBJS-$(CONFIG_VC1DSP)           += x86/vc1dsp_loopfilter.o       \
> >                                            x86/vc1dsp_mc.o
> > -X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o           \
> > -                                          x86/simple_idct.o
> > +ifdef ARCH_X86_64
> > +X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o
> > +else
> > +X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct.o
> > +endif
> >  X86ASM-OBJS-$(CONFIG_VIDEODSP)         += x86/videodsp.o
> >  X86ASM-OBJS-$(CONFIG_VP3DSP)           += x86/vp3dsp.o
> >  X86ASM-OBJS-$(CONFIG_VP8DSP)           += x86/vp8dsp.o                  \
>
> It seems like that there are linkers out there that complain about empty
> object files like x86/simple_idct.o ("ranlib: file:
> libavcodec/libavcodec.a(simple_idct.o) has no symbols" as reported by
> BBB); the above patch is still needed to fix this. I will therefore
> apply it tonight (with an updated commit message) unless there are
> objections.

(Three hours is not a lot)

Which toolchain broke?

Thank you, Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files

[Andreas Rheinhardt]

Carl Eugen Hoyos:
> Am Di., 13. Dez. 2022 um 16:02 Uhr schrieb Andreas Rheinhardt
> <andreas.rheinhardt@outlook.com>:
>>
>> Andreas Rheinhardt:
>>> Should fix ticket #9909, fixing a regression since
>>> bfb28b5ce89f3e950214b67ea95b45e3355c2caf.
>>>
>>> Thanks to Carl Eugen Hoyos for analyzing the issue.
>>>
>>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>>> ---
>>> This would be my solution. What do you think of it?
>>>
>>>  libavcodec/x86/Makefile | 7 +++++--
>>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile
>>> index 4e448623af..41ca864849 100644
>>> --- a/libavcodec/x86/Makefile
>>> +++ b/libavcodec/x86/Makefile
>>> @@ -140,8 +140,11 @@ X86ASM-OBJS-$(CONFIG_QPELDSP)          += x86/qpeldsp.o                 \
>>>  X86ASM-OBJS-$(CONFIG_RV34DSP)          += x86/rv34dsp.o
>>>  X86ASM-OBJS-$(CONFIG_VC1DSP)           += x86/vc1dsp_loopfilter.o       \
>>>                                            x86/vc1dsp_mc.o
>>> -X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o           \
>>> -                                          x86/simple_idct.o
>>> +ifdef ARCH_X86_64
>>> +X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o
>>> +else
>>> +X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct.o
>>> +endif
>>>  X86ASM-OBJS-$(CONFIG_VIDEODSP)         += x86/videodsp.o
>>>  X86ASM-OBJS-$(CONFIG_VP3DSP)           += x86/vp3dsp.o
>>>  X86ASM-OBJS-$(CONFIG_VP8DSP)           += x86/vp8dsp.o                  \
>>
>> It seems like that there are linkers out there that complain about empty
>> object files like x86/simple_idct.o ("ranlib: file:
>> libavcodec/libavcodec.a(simple_idct.o) has no symbols" as reported by
>> BBB); the above patch is still needed to fix this. I will therefore
>> apply it tonight (with an updated commit message) unless there are
>> objections.
> 
> (Three hours is not a lot)
> 
> Which toolchain broke?
> 

"Broke" is the wrong word; Xcode emits warnings for empty object files.
Said Ronald. I haven't reproduced it myself.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files

[Carl Eugen Hoyos]

Am Di., 13. Dez. 2022 um 20:03 Uhr schrieb Andreas Rheinhardt
<andreas.rheinhardt@outlook.com>:
>
> Carl Eugen Hoyos:
> > Am Di., 13. Dez. 2022 um 16:02 Uhr schrieb Andreas Rheinhardt
> > <andreas.rheinhardt@outlook.com>:
> >>
> >> Andreas Rheinhardt:
> >>> Should fix ticket #9909, fixing a regression since
> >>> bfb28b5ce89f3e950214b67ea95b45e3355c2caf.
> >>>
> >>> Thanks to Carl Eugen Hoyos for analyzing the issue.
> >>>
> >>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> >>> ---
> >>> This would be my solution. What do you think of it?
> >>>
> >>>  libavcodec/x86/Makefile | 7 +++++--
> >>>  1 file changed, 5 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile
> >>> index 4e448623af..41ca864849 100644
> >>> --- a/libavcodec/x86/Makefile
> >>> +++ b/libavcodec/x86/Makefile
> >>> @@ -140,8 +140,11 @@ X86ASM-OBJS-$(CONFIG_QPELDSP)          += x86/qpeldsp.o                 \
> >>>  X86ASM-OBJS-$(CONFIG_RV34DSP)          += x86/rv34dsp.o
> >>>  X86ASM-OBJS-$(CONFIG_VC1DSP)           += x86/vc1dsp_loopfilter.o       \
> >>>                                            x86/vc1dsp_mc.o
> >>> -X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o           \
> >>> -                                          x86/simple_idct.o
> >>> +ifdef ARCH_X86_64
> >>> +X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct10.o
> >>> +else
> >>> +X86ASM-OBJS-$(CONFIG_IDCTDSP)          += x86/simple_idct.o
> >>> +endif
> >>>  X86ASM-OBJS-$(CONFIG_VIDEODSP)         += x86/videodsp.o
> >>>  X86ASM-OBJS-$(CONFIG_VP3DSP)           += x86/vp3dsp.o
> >>>  X86ASM-OBJS-$(CONFIG_VP8DSP)           += x86/vp8dsp.o                  \
> >>
> >> It seems like that there are linkers out there that complain about empty
> >> object files like x86/simple_idct.o ("ranlib: file:
> >> libavcodec/libavcodec.a(simple_idct.o) has no symbols" as reported by
> >> BBB); the above patch is still needed to fix this. I will therefore
> >> apply it tonight (with an updated commit message) unless there are
> >> objections.
> >
> > (Three hours is not a lot)
> >
> > Which toolchain broke?
>
> "Broke" is the wrong word; Xcode emits warnings for empty object files.

It does.
(I did not consider this an issue when I saw it.)

I consider this unmaintainable, an argument that in the past was
used to object significantly more important patches (in cases
where maintenance was imo no problem).

Anyway: No objection.

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files

[Ronald S. Bultje]

Hi,

On Tue, Dec 13, 2022 at 2:12 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:

> It does.
> (I did not consider this an issue when I saw it.)
>
> I consider this unmaintainable, an argument that in the past was
> used to object significantly more important patches (in cases
> where maintenance was imo no problem).
>
> Anyway: No objection.
>

It's not that it's a big deal, just that it's mildly annoying and there
doesn't appear to be an obvious downside to fixing it.

Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".