From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8614248747 for ; Sat, 16 Dec 2023 12:20:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A310C68D0FD; Sat, 16 Dec 2023 14:20:26 +0200 (EET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E53C968D12C for ; Sat, 16 Dec 2023 14:20:19 +0200 (EET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d3536cd414so12529895ad.2 for ; Sat, 16 Dec 2023 04:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702729217; x=1703334017; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=5/aYTtt3rs7mNBZE49eZ2e3w+hyWuRN6qgcUUH67ZjM=; b=Krlauks/faujlTo5YzQV+Dut9U+PN5epnouEqWU/A/T1vAkQam9FcRjXm0KJhAxKQ0 u71FY67iyqpajUqrOStwDmvw3zzEQ9G6ApMi6X2L5bkElwrCweoNEf7TZCMJ5ftDil6d NzfTocKCRRtmoD70rAF8Saeqji4dtqYxNy8iZpLauKRVxBFrudPEZdOoMffsQ5lzALC4 k9JXEC4orUNNRPf6wMbog640Q0zTKnaUmjn11ZpFrcEHwG45Lh81/cCMN8IPAyLuzDiF qF3e4ymOAb9om4dBwrqXroy7UkrzLaTxzFPPaQdu+z1SFZ1rGGnW6ZhkNq3ogP/UOBgd h+/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702729217; x=1703334017; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5/aYTtt3rs7mNBZE49eZ2e3w+hyWuRN6qgcUUH67ZjM=; b=TTPFBDvN3Ox6clzavcyl9YrEqV6WspsDent8B/d32CgtPA/zReTXyvb8qyGdnL6fjp TcfsiPGvrBYQskPKfhhDATQ8+a1pPu6sm6X3rdvkrBF71Shg+HuSgLoWiqnDHpjnmtkH q35hApP999BK9neub7xX8VaMLeo7pUyPYBIYY+YIN60HortnDG9VfQOFUkEw/5M9zBDJ f27iZ0uv6/Y8Uq0J479iauXus6NTOPKZioCG9kRhLLN6TgqtPoIu2ggifpliy3pcOAEf hNE3+A6BGfmI7Sjot6VBbkRN6XWv+SuIAfcCMssWXtCnYo7uDga+mO05qBnCv8l72zlR X9/Q== X-Gm-Message-State: AOJu0YwTkIYcr1UttnsqGU/PpxTY7L4CzPIvu2PXiQ0ChQtXpUnoBoet SAjPvazaoxb6JAYKwe+uXONRJWNTg+A= X-Google-Smtp-Source: AGHT+IH7r3KA9NcWTxWa7kXUfbS5ZMnLcbKoaEL9t+RGtJ02qQ2yWnLMso9I1nRgqC57P6Vc8Ykt2A== X-Received: by 2002:a17:902:7ecf:b0:1d3:3c35:81b5 with SMTP id p15-20020a1709027ecf00b001d33c3581b5mr6470668plb.46.1702729217436; Sat, 16 Dec 2023 04:20:17 -0800 (PST) Received: from [192.168.0.13] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id u9-20020a170902e80900b001cf8546335fsm15800675plg.5.2023.12.16.04.20.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Dec 2023 04:20:16 -0800 (PST) Message-ID: <67b46620-8a26-472b-93b9-29b51928464b@gmail.com> Date: Sat, 16 Dec 2023 09:20:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231216121619.19436-1-michael@niedermayer.cc> <20231216121619.19436-2-michael@niedermayer.cc> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20231216121619.19436-2-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs_vp8: Do not use assert to check for end X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/16/2023 9:16 AM, Michael Niedermayer wrote: > Fixes: abort() > Fixes: 64232/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/cbs_vp8.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c > index 01d4b9cefef..b76cde98517 100644 > --- a/libavcodec/cbs_vp8.c > +++ b/libavcodec/cbs_vp8.c > @@ -329,7 +329,9 @@ static int cbs_vp8_read_unit(CodedBitstreamContext *ctx, > > pos = get_bits_count(&gbc); > pos /= 8; > - av_assert0(pos <= unit->data_size); > + > + if (pos > unit->data_size) > + return AVERROR_INVALIDDATA; Wouldn't this be hiding a bug in the parsing code? The assert is there to ensure no overread happened. > > frame->data_ref = av_buffer_ref(unit->data_ref); > if (!frame->data_ref) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".