From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B47A45C13 for ; Tue, 25 Apr 2023 07:41:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A8C9268BE18; Tue, 25 Apr 2023 10:41:02 +0300 (EEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EA8E668A8D2 for ; Tue, 25 Apr 2023 10:40:56 +0300 (EEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1a6817adde4so58723475ad.0 for ; Tue, 25 Apr 2023 00:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682408455; x=1685000455; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=KZFxTbz7b28Z79gPy6aE2Z9A3hHuiC4ImeKQT6m7LfY=; b=TFbgRi0B6NxM2HoZVwlqEatH/qxbIf4Xnyr5xn6s5st50F/PLpQjZVy1p9C10ohgGH 4khEXnUFHUs5gG9C3/UEEltDqDILGWuxYUMK4pv73AqhT264RM3Krgg/mncgAenEDwaw xoXoLkXnUyqwX7no48P76fO14C8rvd9xwI9bc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682408455; x=1685000455; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KZFxTbz7b28Z79gPy6aE2Z9A3hHuiC4ImeKQT6m7LfY=; b=R2WujzRKRWXqxGzOvjRd/m1+gWrkp1dynpGmIGyxZAe3n4byQ0jpECPt0t4QhbRTxF ZcrvZ1f63GGNd9zvbknKX+ILrrG+sN7s/XSzswooUHLpgGt5an/GTPnqxO5/P53g3UU3 OaYpk7b+gN7L+xCU5OvoTBXJSc9HUrasLkwVpgQJtv+RXnayXyDs6QY4Lv0myyVZQTd4 jIVVyYtmVyOpRXPcX8WrQ882wAFHI9iYOPLHCz3Z+gsVhHwdJlyjQe85/UlQls7IeV44 N2NoNK94OoDtlT2lVpM3FHzxVhHvKqG2FBhFtQlxpXhoZkkvUGHwCfd9cIauS0PwHZMF bwHw== X-Gm-Message-State: AAQBX9crYyLd7r//+1VUd3dhWSnJILGJKUlDkrpvkE0e4B1W2bhiftBe LTfFBsbUd7QV0mpjwOMIet3ZNC/DqrgugIZ+QXg/LQ== X-Google-Smtp-Source: AKy350YfxjWOBYN6gVULRyPHDiSz4NNl8vXWDHIDhHUUqEF5b6899PkVnEk2f/WkGGiA1nR5bMJsGQ== X-Received: by 2002:a17:903:187:b0:1a9:3393:edcd with SMTP id z7-20020a170903018700b001a93393edcdmr20253997plg.54.1682408454756; Tue, 25 Apr 2023 00:40:54 -0700 (PDT) Received: from ?IPV6:2401:fa00:1:17:f70c:381c:c754:ee? ([2401:fa00:1:17:f70c:381c:c754:ee]) by smtp.gmail.com with ESMTPSA id 12-20020a170902c24c00b001a69d1bc32csm7655863plg.238.2023.04.25.00.40.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 00:40:54 -0700 (PDT) Message-ID: <677780cf-a7ac-d0bd-54e5-7587984deb04@chromium.org> Date: Tue, 25 Apr 2023 15:40:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 From: Jeremy Wu To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacenc: add strict bit rate control mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thanks for the feedback! I was also looking at whether there is a less intrusive way to enable the code path. I have uploaded a v2 patch that looks at `bit_rate_tolerance`, with minor changes to the option table as it was ignored in the context of audio. I'm only looking at the Bluetooth streaming use case as of now, and the issue cannot be bypassed without this (common implementations use libfdk that supports a similar option). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".