From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A5C364995C for ; Fri, 23 Feb 2024 19:12:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6178668C5E7; Fri, 23 Feb 2024 21:11:57 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D1E268C57B for ; Fri, 23 Feb 2024 21:11:51 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 61580E97DC for ; Fri, 23 Feb 2024 20:11:51 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Adq9voE-Wh2k for ; Fri, 23 Feb 2024 20:11:49 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 2F252E97CD for ; Fri, 23 Feb 2024 20:11:49 +0100 (CET) Date: Fri, 23 Feb 2024 20:11:49 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20240223143115.16521-24-anton@khirnov.net> Message-ID: <672363a2-e650-a8d6-834c-2e39f01f4390@passwd.hu> References: <20240223143115.16521-1-anton@khirnov.net> <20240223143115.16521-24-anton@khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 23/38] avcodec/hevcdec: respect side data preference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 23 Feb 2024, Anton Khirnov wrote: > From: Niklas Haas > > If the time code side data is overridden by the packet level, we also > make sure not to update `out->metadata` to a mismatched timecode. > > For HDR side data, we unfortunately need to omit a return check because > the new function does not distinguish between OOM and overridden side > data. I don't think this is acceptable. If the API is not capable of differentiating between OOM and overridden side data, then the API should be fixed. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".