Re: [FFmpeg-devel] [PATCH 1/5] avformat/mxfdec: Avoid some redundant writing to tables in mxf_compute_ptses_fake_index()

From: "Tomas Härdin" <tjoppen@acc.umu.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avformat/mxfdec: Avoid some redundant writing to tables in mxf_compute_ptses_fake_index()
Date: Tue, 20 Sep 2022 13:12:44 +0200
Message-ID: <668f68e10246f876066b8930bb4b3a1174f14b33.camel@acc.umu.se> (raw)
In-Reply-To: <20220911142721.30812-1-michael@niedermayer.cc>

sön 2022-09-11 klockan 16:27 +0200 skrev Michael Niedermayer:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/mxfdec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index e63e803aa56..4ceb6cf672f 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -1939,10 +1939,10 @@ static int
> mxf_compute_ptses_fake_index(MXFContext *mxf, MXFIndexTable *index_ta
>      if (index_table->nb_ptses <= 0)
>          return 0;
>  
> -    if (!(index_table->ptses      = av_calloc(index_table->nb_ptses,
> sizeof(int64_t))) ||
> +    if (!(index_table->ptses      = av_malloc_array(index_table-
> >nb_ptses, sizeof(int64_t))) ||
>          !(index_table->fake_index = av_calloc(index_table->nb_ptses,
> sizeof(AVIndexEntry))) ||
>          !(index_table->offsets    = av_calloc(index_table->nb_ptses,
> sizeof(int8_t))) ||
> -        !(flags                   = av_calloc(index_table->nb_ptses,
> sizeof(uint8_t)))) {
> +        !(flags                   = av_malloc_array(index_table-
> >nb_ptses, sizeof(uint8_t)))) {

Looks OK. Seems like the same thing can be done with offsets

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".