From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A4A694C545 for ; Mon, 29 Jul 2024 03:46:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CCF4268D47C; Mon, 29 Jul 2024 06:46:09 +0300 (EEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E74BC68CFAF for ; Mon, 29 Jul 2024 06:46:02 +0300 (EEST) X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.11.12] ([95.33.106.8]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4z6q-1s71dW0gTs-00wv7I for ; Mon, 29 Jul 2024 05:46:02 +0200 Content-Type: multipart/mixed; boundary="------------2Bc0WdZpk25uLPOj0KtD0fHy" Message-ID: <6631e5bf-b3af-437e-a00c-27d07d7bcc44@gmx.net> Date: Mon, 29 Jul 2024 05:46:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <33cb91e2-a4d3-47c5-8f15-d0ccb1107eaa@gmx.net> Content-Language: de-DE, en-US In-Reply-To: X-Provags-ID: V03:K1:yz3ld7UYgPOVqsKg08B3ZtNZ0rRFffs9f60x4HUnVwqMa1ALOp4 inhKlg9Ri8MG+aF6a4cxEWwB0yekZCgdCwAaIsnO1k/bIyetzhXp0bqAcPFE44gjz9FFvwa Dcjx5HsDkS/DaZMVksiUmecWrpPo5f+ON5iCzyVL20YIB4U0pFnlCUJ8gyY7Cea3Crv0sZK Mzf3G7l5l/H9/Vk8BpL9A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:2IGqEvuEs0I=;K5NOUVg51TYOG9Zp+UUJB10sWrQ +2VaP6kCfvZpPngVkYQgIyKUJkja/J5K1az7OeXfKEVndgyKZH0dyU+jGsYXwR1ODiSYgA1UB Xaz7rFDM6gOW15XJk23j/hHfo6gm0YDLPKJIiTfFTionHu6f3SMZRXYp2aUqLbtrKx5RqjV4k QbP6rcC2nB74t8hOHFSdrUGs433sNfWgJ8owgaLTJPvFRCKx55stE+PRfMIbm6jZ7MHZfwRZu lek53pn6MADCxgRmCR9BTVzly2CvFhTH1h+8JMrkzuziIKtUlT28BIY92QqKuEvy7T5WOtHta D1d7ZAH/OV/EWuwhlmHZewYzyXn0LLWkCZF5Aws5y5zfDGO9wTTjtkKMvVNtS/7wE9b192gjI lBSs1bcdGX/gEEt6xIixtMBykJfha+tKLHxZUBQDsKzz7z+ZWJKaTsynnb/oHbuHUxVlzMqfY GgYO8Su/RpPtS8MGosArZSJtT81zouYYUl7r7wWVO0gSA6M0XcuWGksWy0A26OOlM4YsgoTqT NFtZBlIqV7VOcpBGrC6aCO+Jlcdr7C0PO4be8pZtE3thXEBhKj7DZCRzQrtFMCuwSMbhUgLhL 9bB4EDtOpHrF26tykfWmW7mrNQICQuRCMvdsWetO4n6d/iua99JgCoPwQpG3dZKTxtC2Jzn/v rrYotYbCZKM406TY8JihKok0cFpLIVjCtt4XPgeoGa4kx3K58vhFxbge0+jejUwlfFnaMqR1O iykVO4quOo3Y7ga4FMc9ZuYOvTUwNpoAli/0A5LLUzYMhPG85Ep/JdmCnv7k8uddRfhFwtC8A 34MWWntY/wlZLWaMC7r4IVpA== Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Stefan Oltmanns via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Stefan Oltmanns Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a multi-part message in MIME format. --------------2Bc0WdZpk25uLPOj0KtD0fHy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Am 28.07.24 um 15:15 schrieb Ramiro Polla: >> +=C2=A0=C2=A0=C2=A0 void *vslibrary =3D NULL; >> +#ifdef _WIN32 >> +=C2=A0=C2=A0=C2=A0 const HKEY hkeys[] =3D {HKEY_CURRENT_USER, HKEY_LOC= AL_MACHINE}; >> +=C2=A0=C2=A0=C2=A0 LONG r; >> +=C2=A0=C2=A0=C2=A0 WCHAR vss_path[512]; >> +=C2=A0=C2=A0=C2=A0 DWORD buf_size =3D sizeof(vss_path) - 2; >> +=C2=A0=C2=A0=C2=A0 char *vss_path_utf8; >> +=C2=A0=C2=A0=C2=A0 int i; >> + >> +=C2=A0=C2=A0=C2=A0 for (i =3D 0; i < sizeof(hkeys); i++) { > > FF_ARRAY_ELEMS(hkeys) fixed > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ((r =3D RegGetValueW(hke= ys[i], L"SOFTWARE\\VapourSynth", >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 L"VSScriptDLL", = RRF_RT_REG_SZ, NULL, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &vss_path, &buf_= size)) =3D=3D ERROR_SUCCESS) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bre= ak; >> +=C2=A0=C2=A0=C2=A0 } >> +=C2=A0=C2=A0=C2=A0 if (r =3D=3D ERROR_SUCCESS && wchartoutf8(vss_path,= &vss_path_utf8) >> =3D=3D 0) { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vslibrary =3D dlopen(vss_pa= th_utf8, RTLD_NOW | RTLD_GLOBAL); > > I think calling win32_dlopen() with a full path will be problematic for > systems without KB2533623. win32_dlopen() might need to be fixed in a > separate patch. > Yes, win32_dlopen would need to check if a full path is already given and if yes skip all the stuff to determine it's own and system32 path, but instead just use the given parameter directly. To check if it's a full path it should be enough to check if it either starts with "\??\" (NT-style path) or if the second character is ":" (win32 style path). But is this really is needed for an operating system that reached support end over 4 years ago and does not have a security patch applied released over 13 years ago? I don't know what ffmpeg's exact policy is in this case, just asking. Best regards Stefan --------------2Bc0WdZpk25uLPOj0KtD0fHy Content-Type: text/x-patch; charset=UTF-8; name="0002-avformat-vapoursynth-load-library-at-runtime.patch" Content-Disposition: attachment; filename="0002-avformat-vapoursynth-load-library-at-runtime.patch" Content-Transfer-Encoding: base64 RnJvbSBkYzM5NjcxMWQwNTBjMTEyYjJlZjZjMzdmZGI2N2M0ZWM1OWMxNmExIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gT2x0bWFubnMgPHN0ZWZhbi1vbHRtYW5u c0BnbXgubmV0PgpEYXRlOiBNb24sIDI5IEp1bCAyMDI0IDA1OjEyOjMxICswMjAwClN1Ympl Y3Q6IFtQQVRDSCAyLzJdIGF2Zm9ybWF0L3ZhcG91cnN5bnRoOiBsb2FkIGxpYnJhcnkgYXQg cnVudGltZQoKU2lnbmVkLW9mZi1ieTogU3RlZmFuIE9sdG1hbm5zIDxzdGVmYW4tb2x0bWFu bnNAZ214Lm5ldD4KLS0tCiBjb25maWd1cmUgICAgICAgICAgICAgICAgIHwgIDIgKy0KIGxp YmF2Zm9ybWF0L3ZhcG91cnN5bnRoLmMgfCA2NSArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgNjQgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9jb25maWd1cmUgYi9jb25maWd1cmUKaW5kZXgg YzUwYjVhZDRiNC4uMWI2NjcwNTA1YSAxMDA3NTUKLS0tIGEvY29uZmlndXJlCisrKyBiL2Nv bmZpZ3VyZQpAQCAtNzA4NSw3ICs3MDg1LDcgQEAgZW5hYmxlZCBya21wcCAgICAgICAgICAg ICAmJiB7IHJlcXVpcmVfcGtnX2NvbmZpZyBya21wcCByb2NrY2hpcF9tcHAgIHJvY2tjaGlw L3IKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB7IGVuYWJsZWQgbGliZHJtIHx8 CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaWUgIkVSUk9SOiBya21wcCBy ZXF1aXJlcyAtLWVuYWJsZS1saWJkcm0iOyB9CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIH0KLWVuYWJsZWQgdmFwb3Vyc3ludGggICAgICAgJiYgcmVxdWlyZV9wa2dfY29uZmln IHZhcG91cnN5bnRoICJ2YXBvdXJzeW50aC1zY3JpcHQgPj0gNTUiIFZTU2NyaXB0NC5oIGdl dFZTU2NyaXB0QVBJCitlbmFibGVkIHZhcG91cnN5bnRoICAgICAgICYmIHJlcXVpcmVfaGVh ZGVycyAidmFwb3Vyc3ludGgvVlNTY3JpcHQ0LmggdmFwb3Vyc3ludGgvVmFwb3VyU3ludGg0 LmgiCiAKIAogaWYgZW5hYmxlZCBnY3J5cHQ7IHRoZW4KZGlmZiAtLWdpdCBhL2xpYmF2Zm9y bWF0L3ZhcG91cnN5bnRoLmMgYi9saWJhdmZvcm1hdC92YXBvdXJzeW50aC5jCmluZGV4IDI2 Yzk5ODYxMzguLjBmYTVhZmZhNjMgMTAwNjQ0Ci0tLSBhL2xpYmF2Zm9ybWF0L3ZhcG91cnN5 bnRoLmMKKysrIGIvbGliYXZmb3JtYXQvdmFwb3Vyc3ludGguYwpAQCAtMjUsNyArMjUsNyBA QAogCiAjaW5jbHVkZSA8bGltaXRzLmg+CiAKLSNpbmNsdWRlIDxWU1NjcmlwdDQuaD4KKyNp bmNsdWRlIDx2YXBvdXJzeW50aC9WU1NjcmlwdDQuaD4KIAogI2luY2x1ZGUgImxpYmF2dXRp bC9hdmFzc2VydC5oIgogI2luY2x1ZGUgImxpYmF2dXRpbC9hdnN0cmluZy5oIgpAQCAtMzks MTEgKzM5LDI2IEBACiAjaW5jbHVkZSAiZGVtdXguaCIKICNpbmNsdWRlICJpbnRlcm5hbC5o IgogCisvKiBQbGF0Zm9ybS1zcGVjaWZpYyBkaXJlY3RpdmVzLiAqLworI2lmZGVmIF9XSU4z MgorICAjaW5jbHVkZSA8d2luZG93cy5oPgorICAjaW5jbHVkZSAiY29tcGF0L3czMmRsZmNu LmgiCisgICNpbmNsdWRlICJsaWJhdnV0aWwvd2NoYXJfZmlsZW5hbWUuaCIKKyAgI3VuZGVm IEVYVEVSTl9DCisgICNkZWZpbmUgVlNTQ1JJUFRfTElCICJWU1NjcmlwdC5kbGwiCisjZWxz ZQorICAjaW5jbHVkZSA8ZGxmY24uaD4KKyAgI2RlZmluZSBWU1NDUklQVF9OQU1FICJsaWJ2 YXBvdXJzeW50aC1zY3JpcHQiCisgICNkZWZpbmUgVlNTQ1JJUFRfTElCIFZTU0NSSVBUX05B TUUgU0xJQlNVRgorI2VuZGlmCisKIHN0cnVjdCBWU1N0YXRlIHsKICAgICBjb25zdCBWU1ND UklQVEFQSSAqdnNzYXBpOwogICAgIFZTU2NyaXB0ICp2c3M7CiB9OwogCit0eXBlZGVmIGNv bnN0IFZTU0NSSVBUQVBJICooKlZTU2NyaXB0R2V0QVBJRnVuYykoaW50IHZlcnNpb24pOwor CiB0eXBlZGVmIHN0cnVjdCBWU0NvbnRleHQgewogICAgIGNvbnN0IEFWQ2xhc3MgKmNsYXNz OwogCkBAIC01MSw2ICs2Niw3IEBAIHR5cGVkZWYgc3RydWN0IFZTQ29udGV4dCB7CiAKICAg ICBjb25zdCBWU1NDUklQVEFQSSAqdnNzYXBpOwogICAgIGNvbnN0IFZTQVBJICp2c2FwaTsK KyAgICB2b2lkICp2c2xpYnJhcnk7CiAKICAgICBWU05vZGUgKm91dG5vZGU7CiAgICAgaW50 IGlzX2NmcjsKQEAgLTcwLDYgKzg2LDQwIEBAIHN0YXRpYyBjb25zdCBBVk9wdGlvbiBvcHRp b25zW10gPSB7CiAgICAge05VTEx9CiB9OwogCitzdGF0aWMgYXZfY29sZCB2b2lkKiB2c19s b2FkX2xpYnJhcnkoVlNTY3JpcHRHZXRBUElGdW5jICpnZXRfdnNzYXBpKQoreworICAgIHZv aWQgKnZzbGlicmFyeSA9IE5VTEw7CisjaWZkZWYgX1dJTjMyCisgICAgY29uc3QgSEtFWSBo a2V5c1tdID0ge0hLRVlfQ1VSUkVOVF9VU0VSLCBIS0VZX0xPQ0FMX01BQ0hJTkV9OworICAg IExPTkcgcjsKKyAgICBXQ0hBUiB2c3NfcGF0aFs1MTJdOworICAgIERXT1JEIGJ1Zl9zaXpl ID0gc2l6ZW9mKHZzc19wYXRoKSAtIDI7CisgICAgY2hhciAqdnNzX3BhdGhfdXRmODsKKyAg ICBpbnQgaTsKKworICAgIGZvciAoaSA9IDA7IGkgPCBGRl9BUlJBWV9FTEVNUyhoa2V5cyk7 IGkrKykgeworICAgICAgICBpZiAoKHIgPSBSZWdHZXRWYWx1ZVcoaGtleXNbaV0sIEwiU09G VFdBUkVcXFZhcG91clN5bnRoIiwKKyAgICAgICAgICAgICAgICAgICAgICBMIlZTU2NyaXB0 RExMIiwgUlJGX1JUX1JFR19TWiwgTlVMTCwKKyAgICAgICAgICAgICAgICAgICAgICAmdnNz X3BhdGgsICZidWZfc2l6ZSkpID09IEVSUk9SX1NVQ0NFU1MpCisgICAgICAgICAgICBicmVh azsKKyAgICB9CisgICAgaWYgKHIgPT0gRVJST1JfU1VDQ0VTUyAmJiB3Y2hhcnRvdXRmOCh2 c3NfcGF0aCwgJnZzc19wYXRoX3V0ZjgpID09IDApIHsKKyAgICAgICAgdnNsaWJyYXJ5ID0g ZGxvcGVuKHZzc19wYXRoX3V0ZjgsIFJUTERfTk9XIHwgUlRMRF9HTE9CQUwpOworICAgICAg ICBhdl9mcmVlKHZzc19wYXRoX3V0ZjgpOworICAgIH0KKyAgICBlbHNlCisjZW5kaWYKKyAg ICB2c2xpYnJhcnkgPSBkbG9wZW4oVlNTQ1JJUFRfTElCLCBSVExEX05PVyB8IFJUTERfR0xP QkFMKTsKKworICAgIGlmICh2c2xpYnJhcnkgIT0gTlVMTCkgeworICAgICAgICBpZiAoISgq Z2V0X3Zzc2FwaSA9IChWU1NjcmlwdEdldEFQSUZ1bmMpZGxzeW0odnNsaWJyYXJ5LCAiZ2V0 VlNTY3JpcHRBUEkiKSkpIHsKKyAgICAgICAgICAgIGRsY2xvc2UodnNsaWJyYXJ5KTsKKyAg ICAgICAgICAgIHJldHVybiBOVUxMOworICAgICAgICB9CisgICAgfQorICAgIHJldHVybiB2 c2xpYnJhcnk7Cit9CisKIHN0YXRpYyB2b2lkIGZyZWVfdnNzX3N0YXRlKHZvaWQgKm9wYXF1 ZSwgdWludDhfdCAqZGF0YSkKIHsKICAgICBzdHJ1Y3QgVlNTdGF0ZSAqdnNzID0gb3BhcXVl OwpAQCAtOTEsNiArMTQxLDkgQEAgc3RhdGljIGF2X2NvbGQgaW50IHJlYWRfY2xvc2VfdnMo QVZGb3JtYXRDb250ZXh0ICpzKQogICAgIHZzLT52c2FwaSA9IE5VTEw7CiAgICAgdnMtPm91 dG5vZGUgPSBOVUxMOwogCisgICAgaWYgKHZzLT52c2xpYnJhcnkpCisgICAgICAgIGRsY2xv c2UodnMtPnZzbGlicmFyeSk7CisKICAgICByZXR1cm4gMDsKIH0KIApAQCAtMTcwLDYgKzIy Myw3IEBAIHN0YXRpYyBhdl9jb2xkIGludCByZWFkX2hlYWRlcl92cyhBVkZvcm1hdENvbnRl eHQgKnMpCiAgICAgQVZTdHJlYW0gKnN0OwogICAgIEFWSU9Db250ZXh0ICpwYiA9IHMtPnBi OwogICAgIFZTQ29udGV4dCAqdnMgPSBzLT5wcml2X2RhdGE7CisgICAgVlNTY3JpcHRHZXRB UElGdW5jIGdldF92c3NhcGk7CiAgICAgaW50NjRfdCBzeiA9IGF2aW9fc2l6ZShwYik7CiAg ICAgY2hhciAqYnVmID0gTlVMTDsKICAgICBjaGFyIGR1bW15OwpAQCAtMTc4LDcgKzIzMiwx NCBAQCBzdGF0aWMgYXZfY29sZCBpbnQgcmVhZF9oZWFkZXJfdnMoQVZGb3JtYXRDb250ZXh0 ICpzKQogICAgIHN0cnVjdCBWU1N0YXRlICp2c3Nfc3RhdGU7CiAgICAgaW50IGVyciA9IDA7 CiAKLSAgICBpZiAoISh2cy0+dnNzYXBpID0gZ2V0VlNTY3JpcHRBUEkoVlNTQ1JJUFRfQVBJ X1ZFUlNJT04pKSkgeworICAgIGlmICghKHZzLT52c2xpYnJhcnkgPSB2c19sb2FkX2xpYnJh cnkoJmdldF92c3NhcGkpKSkgeworICAgICAgICBhdl9sb2cocywgQVZfTE9HX0VSUk9SLCAi Q291bGQgbm90IG9wZW4gIiBWU1NDUklQVF9MSUIgIi4gIgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiQ2hlY2sgVmFwb3VyU3ludGggaW5zdGFsbGF0aW9uLlxuIik7Cisg ICAgICAgIGVyciA9IEFWRVJST1JfRVhURVJOQUw7CisgICAgICAgIGdvdG8gZG9uZTsKKyAg ICB9CisKKyAgICBpZiAoISh2cy0+dnNzYXBpID0gZ2V0X3Zzc2FwaShWU1NDUklQVF9BUElf VkVSU0lPTikpKSB7CiAgICAgICAgIGF2X2xvZyhzLCBBVl9MT0dfRVJST1IsICJGYWlsZWQg dG8gaW5pdGlhbGl6ZSBWU1NjcmlwdCAocG9zc2libHkgUFlUSE9OUEFUSCBub3Qgc2V0KS5c biIpOwogICAgICAgICBlcnIgPSBBVkVSUk9SX0VYVEVSTkFMOwogICAgICAgICBnb3RvIGRv bmU7Ci0tIAoyLjM0LjEKCg== --------------2Bc0WdZpk25uLPOj0KtD0fHy Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------2Bc0WdZpk25uLPOj0KtD0fHy--