Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct
Date: Fri, 17 Feb 2023 14:08:53 -0300
Message-ID: <66307ef3-b214-47f6-6d4e-fbcc439f2004@gmail.com> (raw)
In-Reply-To: <NOVI8Wy--3-9@lynne.ee>

On 2/17/2023 1:54 PM, Lynne wrote:
> This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62.
> 
> All filters and all codecs (except wmavoice) have been ported for the
> lavu/tx API.
> 
> The noise should be minimal.

It isn't. I'm getting more than two thousand lines of warnings after 
applying this patch from

libavfilter/vf_spp.c
libavfilter/x86/vf_spp.c
libavcodec/asvenc.c
libavcodec/avdct.c
libavcodec/avfft.c
libavcodec/dct.c
libavcodec/fdctdsp.c
libavcodec/fft_float.c
libavcodec/fft_init_table.c
libavcodec/idctdsp.c
libavcodec/jfdctfst.c
libavcodec/jfdctint.c
libavcodec/jrevdct.c
libavcodec/mpegaudiodsp.c
libavcodec/mpegvideo_enc.c
libavcodec/rdft.c
libavcodec/wmavoice.c
libavcodec/x86/dct_init.c
libavcodec/x86/fft_init.c
libavcodec/x86/mpegvideoenc.c

It's not just wmavoice, there's also mpeg and jpeg stuff, and one 
filter. For the actual fft/dct/rdft/mdct source files, you should use 
the deprecation warning pragmas to silence them, but the other modules 
need to be ported.
This patch is also missing the schedule FF_API deprecation wrapper.

> 
> Patch attached.
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".