From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavc/vvc: Clamp shift RHS
Date: Fri, 26 Jan 2024 15:51:01 -0300
Message-ID: <65fce6e8-e9cf-43df-ad2d-21be8b063688@gmail.com> (raw)
In-Reply-To: <20240126091313.85991-1-post@frankplowman.com>
On 1/26/2024 6:13 AM, post@frankplowman.com wrote:
> From: Frank Plowman <post@frankplowman.com>
>
> Resolves the following undefined behavior sanitiser error:
> runtime error: shift exponent 32 is too large for 32-bit type 'int'
>
> Signed-off-by: Frank Plowman <post@frankplowman.com>
> ---
> libavcodec/vvc/vvc_intra_template.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vvc/vvc_intra_template.c b/libavcodec/vvc/vvc_intra_template.c
> index 9fb47549d5..a078885266 100644
> --- a/libavcodec/vvc/vvc_intra_template.c
> +++ b/libavcodec/vvc/vvc_intra_template.c
> @@ -969,7 +969,7 @@ static void FUNC(pred_angular_h)(uint8_t *_src, const uint8_t *_top, const uint8
> int pos = (1 + ref_idx) * intra_pred_angle;
> int wt;
> if (need_pdpc)
> - wt = (32 >> ((y * 2) >> nscale));
> + wt = (32 >> FFMIN(31, (y * 2) >> nscale));
>
> for (int x = 0; x < w; x++) {
> const int idx = (pos >> 5) + ref_idx;
Applied, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-01-26 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 9:13 post
2024-01-26 18:51 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65fce6e8-e9cf-43df-ad2d-21be8b063688@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git