From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E25C44B6E8 for ; Tue, 11 Jun 2024 18:42:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A1E7368D8A7; Tue, 11 Jun 2024 21:42:48 +0300 (EEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8EC8F68D7BB for ; Tue, 11 Jun 2024 21:42:42 +0300 (EEST) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-705b9a89e08so311994b3a.1 for ; Tue, 11 Jun 2024 11:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718131360; x=1718736160; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=0f0m9/IeB0gqxNJkBu/35qYPS6yZTPjCw48a/NxZLow=; b=JCI8/yJl2cqBVv3yoWf01g9Ywhxvg0czkuq7SB7g9ev2OxQqkpe4+gM9yUi+KKovEv JMDOb+XMS19pGyFBDQGTCG/VfpB/FQQMaVV8pJGC2I9SQTXWfw3DzeiXJzHobdrP9azD 9ZHt5kFMTI7fbJy1ECtDvvbv4xnfMwsEZ+dUSNRZaGWNaFtfp7ox8tePBNsuH8HNUUHg CarokqyXYw73Qiud/Hh88s88HzOa2dp5dUC8wzLdqug3RpilS2Vegiz/FGJWbGFzfqal nPCo0475XQiJDE6+YGyuko7/0/K1pJ/JJDvCSAlPGbAI8SCyAwjuHLrpNKneisO8DGqZ dTcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718131360; x=1718736160; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0f0m9/IeB0gqxNJkBu/35qYPS6yZTPjCw48a/NxZLow=; b=CO6mMbxcKLhMt3FqoMoMTQZ788NL5pTb5uR7HJSAyNQa/npDTN5HxPCxB/V8vWhO2l NFJIsDzQwTCKKQl9vB9OFwKDDHQcc9iiLfAh/u2aOPVnc9wrAtVXuVogxgr5GCxcCfDW WZ8kAlFTA+zmPuzTszPjIieTXJNk7l/xTDXmOvn8c1F7q2wWR7EpSY2U4bCgKqy71mWq MsaNltAEGZJAiOx0H5QEEFiqlcRQMEzKOt6Mb4nn/bOJMraejir70ctml8Bqa3kzuAF8 277Pf/e/E5UddmrRq3im7r4T649SMfA81xsBUuAAOu0aOEjzxijV6S/ZekTWOL0s8BQ2 j2Ww== X-Gm-Message-State: AOJu0Yx/PjQT3FNparS779f+6cSx+BDh5l+c9gPP6SHb9gK/Wtj4XUSv 62q+z1JEQz/Egop1Qg1SzwkJUCHYCESuDgHQzy++kh4+G5B75E5it9evkQ== X-Google-Smtp-Source: AGHT+IEqNjLQGHxkSQb/8t7yCfHRQtmvshQjuT1XfZf/7WLjCQYsll5IS8vMZ/BCuA1XV7YHHe43TA== X-Received: by 2002:a05:6a00:b55:b0:705:9ddb:db6b with SMTP id d2e1a72fcca58-7059ddbf7f5mr6267991b3a.13.1718131359569; Tue, 11 Jun 2024 11:42:39 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7042d5dfdddsm5651850b3a.120.2024.06.11.11.42.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 11:42:39 -0700 (PDT) Message-ID: <65f67c7c-bae3-44e2-87cd-be1ac6094c7a@gmail.com> Date: Tue, 11 Jun 2024 15:43:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240611122858.196658-1-ramiro.polla@gmail.com> <20240611122858.196658-2-ramiro.polla@gmail.com> <20240611182651.GR2821752@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20240611182651.GR2821752@pb2> Subject: Re: [FFmpeg-devel] [PATCH v2 2/4] swscale/x86: add sse4 {lum, chr}ConvertRange X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/11/2024 3:26 PM, Michael Niedermayer wrote: > On Tue, Jun 11, 2024 at 02:28:56PM +0200, Ramiro Polla wrote: >> chrRangeFromJpeg_8_c: 28.7 >> chrRangeFromJpeg_8_sse4: 16.2 >> chrRangeFromJpeg_24_c: 152.7 >> chrRangeFromJpeg_24_sse4: 29.7 >> chrRangeFromJpeg_128_c: 366.5 >> chrRangeFromJpeg_128_sse4: 233.0 >> chrRangeFromJpeg_144_c: 408.0 >> chrRangeFromJpeg_144_sse4: 182.5 >> chrRangeFromJpeg_256_c: 698.7 >> chrRangeFromJpeg_256_sse4: 325.5 >> chrRangeFromJpeg_512_c: 1348.7 >> chrRangeFromJpeg_512_sse4: 660.2 >> chrRangeToJpeg_8_c: 37.7 >> chrRangeToJpeg_8_sse4: 16.2 >> chrRangeToJpeg_24_c: 115.7 >> chrRangeToJpeg_24_sse4: 36.2 >> chrRangeToJpeg_128_c: 631.2 >> chrRangeToJpeg_128_sse4: 163.7 >> chrRangeToJpeg_144_c: 710.7 >> chrRangeToJpeg_144_sse4: 183.0 >> chrRangeToJpeg_256_c: 1253.0 >> chrRangeToJpeg_256_sse4: 343.5 >> chrRangeToJpeg_512_c: 2491.2 >> chrRangeToJpeg_512_sse4: 654.2 >> lumRangeFromJpeg_8_c: 11.7 >> lumRangeFromJpeg_8_sse4: 10.5 >> lumRangeFromJpeg_24_c: 38.5 >> lumRangeFromJpeg_24_sse4: 19.0 >> lumRangeFromJpeg_128_c: 237.5 >> lumRangeFromJpeg_128_sse4: 79.2 >> lumRangeFromJpeg_144_c: 255.7 >> lumRangeFromJpeg_144_sse4: 90.5 >> lumRangeFromJpeg_256_c: 441.5 >> lumRangeFromJpeg_256_sse4: 161.7 >> lumRangeFromJpeg_512_c: 879.0 >> lumRangeFromJpeg_512_sse4: 333.2 >> lumRangeToJpeg_8_c: 20.0 >> lumRangeToJpeg_8_sse4: 11.7 >> lumRangeToJpeg_24_c: 61.5 >> lumRangeToJpeg_24_sse4: 17.7 >> lumRangeToJpeg_128_c: 357.5 >> lumRangeToJpeg_128_sse4: 80.0 >> lumRangeToJpeg_144_c: 371.5 >> lumRangeToJpeg_144_sse4: 93.2 >> lumRangeToJpeg_256_c: 651.5 >> lumRangeToJpeg_256_sse4: 164.5 >> lumRangeToJpeg_512_c: 1279.0 >> lumRangeToJpeg_512_sse4: 333.7 >> --- >> libswscale/swscale_internal.h | 1 + >> libswscale/utils.c | 2 + >> libswscale/x86/Makefile | 1 + >> libswscale/x86/range_convert.asm | 130 +++++++++++++++++++++++++++++++ >> libswscale/x86/swscale.c | 36 +++++++++ >> 5 files changed, 170 insertions(+) >> create mode 100644 libswscale/x86/range_convert.asm > > breaks x86-32 build > > LD ffmpeg_g > /usr/lib/gcc-cross/i686-linux-gnu/7/../../../../i686-linux-gnu/bin/ld: libswscale/libswscale.a(utils.o): in function `sws_setColorspaceDetails': > ffmpeg/linux32/src/libswscale/utils.c:1086: undefined reference to `ff_sws_init_range_convert_x86' > collect2: error: ld returned 1 exit status > make: *** [Makefile:139: ffmpeg_g] Error 1 > > thx The functions are wrapped in ARCH_X86_64 checks for seemingly no reason, so they should be removed in the next iteration. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".