From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6BF5E4B810 for ; Wed, 30 Apr 2025 21:15:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5BCAE68AF3B; Thu, 1 May 2025 00:15:23 +0300 (EEST) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 866DF687C4C for ; Thu, 1 May 2025 00:15:16 +0300 (EEST) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39c30d9085aso180743f8f.1 for ; Wed, 30 Apr 2025 14:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1746047716; x=1746652516; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=doPRiU3F0rPM1y7DIZ03whf4kG/LB8aUnFJgAx+2Ti0=; b=Zdb+1f0jfqmvWQ1kNPcvFv7+41y8FPe7ULirph5smE5rUgH+dimuGccYNFP1zk/DNZ odWW1ygq7t6XRs5NVZWG3aHdxYpkts7eqnXjnODFYfI4N4eKNz227lwgfu9MfOJ5cYQV 9tF7lWkJRZkbJZoTfkVHybCWlJFlwWsrKpLjC9C+4oQpdsYhM+CpqYn7bNEJFTX/7odO dPXt1qjKs0l5GSC1IP04T65CUIngOd6Y2C6zB0NEj+zk8KeIWQFWVxByb8cK9UvyH+hq TGz3HsM/oDvIJH+GEREXDuj9ysrJx3c7rGvVUA//XnDe0D9N9sBLVpfhPTLKGfKOL7m9 OByA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746047716; x=1746652516; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=doPRiU3F0rPM1y7DIZ03whf4kG/LB8aUnFJgAx+2Ti0=; b=Zp7btxjZtFmdUQ5Cuk3FOzhI7FYsUXcizFkEVvywfyZprdBxsoPJ7H67wo4e+lZBwr EUBu22+P8UJPFeTX7/vuLjgAQUju0qir9bVkh7XPjNdoKIV4+GHRtflFmNiVODCKQL8L osVJbhGEdrQlGJF7nmLV88rpSXO4PGKqcggLVAIl63GzCAuDJLh5BrO+Z99yt/BSgs9o IEd6ZExtFpYCDhREBDKeaMJx5nr8FOp7uGqT+mVjK68851ZbKFLxda/VcnhpZjfb1qoP vMhSq6UoLI9sH3Kf4MeNO9AC3TGwsrfu+PPyuUq2tOnlk/FMbHE94iyikdadjXgRkmQZ zH8A== X-Gm-Message-State: AOJu0YzKOzi/nDSAHoiJhDvdkgos+cZ3iDbnM7BF3mTx6JU18mr/OIuT KQbAEPpauA5Sf9XKd7IG6L30d8Ry/h3jlpp3Ojyt+wxWUsZfm/v49VXGEISoKwCozXV3wiZ2IBM MK5GB1Q== X-Gm-Gg: ASbGncsOYQ4PYO3N3e8ICOEhPkFRxTzLZyGybOXmjh8vKXpJSHV+S5ahkjJ8v9O/xU8 s+nvknFfF5HV+GZrHKkoISoofDjsA8ghTuIbL4lMq0fvVY9G2p+Qr8hvv52Aq+dBXPFh/puX0xD x/RoBXUfs0i9/zopSt2NOn9AqW9WhOQB5yWs+gvOMM9YVdyzLsXr+8nNeBdEOiR2XG7ZEZ2RJJD I7LYU4kzRowI8nv937420MFcwmPndUs2MbWEigMiQ3ZA41S97VpsTHry169ZX7jknXU3JsE5Mz/ zib4iofgh0TIeuwhi6ypwKFx2gv67y4A1wAKDyCArYCNUNzgjVWw8SYuvjbuzZ/oVXLsdToZlWE 1ssZ2BwecRlSU5Q== X-Google-Smtp-Source: AGHT+IEvgvzKfUvcOIHSGlCFyvGq74+EBsMOKk4AMza9NgAKZvvp5ORKRW4c4vo4XpzyHeEBJI6Lwg== X-Received: by 2002:a05:6000:178a:b0:39e:e217:28d0 with SMTP id ffacd0b85a97d-3a093030728mr459328f8f.4.1746047715740; Wed, 30 Apr 2025 14:15:15 -0700 (PDT) Received: from [192.168.0.15] (cpc92320-cmbg19-2-0-cust719.5-4.cable.virginm.net. [82.13.66.208]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073cc180bsm18230777f8f.53.2025.04.30.14.15.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 14:15:15 -0700 (PDT) Message-ID: <65deee43-c9e9-4386-b3b3-2b7d7cf17fc3@jkqxz.net> Date: Wed, 30 Apr 2025 22:15:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Mark Thompson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/5] avformat/apvdec: Use ffio_read_size() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 28/04/2025 10:39, Andreas Rheinhardt wrote: > Patches attached. > > - Andreas > > [PATCH 1/5] avformat/apvdec: Use ffio_read_size() LGTM. > [PATCH 2/5] avformat/apvdec: Check before access LGTM. > pkt->flags = AV_PKT_FLAG_KEY; Not sure where the funny alignment on this line came from (setting some other field there?) but suggest fixing it at the same time as this patch since you edit the previous line and it's not really worth its own patch. > [PATCH 3/5] avformat/apvdec: Fix seeking This makes more sense, thank you. LGTM. > [PATCH 4/5] avformat/apvdec: Remove inappropriate INIT_CLEANUP flag Sure. > [PATCH 5/5] avcodec/apv_entropy: Remove ff_apv_read_vlc() See patch sent a few minutes ago - suggestions for nicer answer welcome. (Copy/paste is not a nicer answer.) Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".