From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1781A46ADA for ; Mon, 2 Oct 2023 19:42:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6B41968CBED; Mon, 2 Oct 2023 22:42:43 +0300 (EEST) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D743768CBDD for ; Mon, 2 Oct 2023 22:42:36 +0300 (EEST) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-325e9cd483eso151021f8f.2 for ; Mon, 02 Oct 2023 12:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1696275756; x=1696880556; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jB0638UbtAENW5OSd1nKWaXJdgyEakU/o18RH+B7x3c=; b=TKgcxoZYxzWlzGPQHuPflonLk8fRVtM4oVohxxuGiHHKgNu/MlD/w0CoTcR2L6mEIq x6whWpUOcxnmlXwMIbLhkycs3lkC/jtqr2HKKXq2nrHZA6I9oCOuoZlayIJGr0N+Wj7t hjXNMKxbfFcGjDc+ejDD3F+PRgUXQQdMVEEwHrd/j2Fkg5k558eLptGYTLAIy4wjqPbz HlqcEkfSC0RTvdRMEwcPQUmSTDypn+ywbZowp19UVTYR1Pmvr5DX7uO0LcUZq7cYeHvR Tko5JBrurRf4sTeD521g0dOQuY2uYoR4O9IQxNFaO5XhnroufxJSxzQjDQqZXzw3Mn0q oWkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696275756; x=1696880556; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jB0638UbtAENW5OSd1nKWaXJdgyEakU/o18RH+B7x3c=; b=hjyd9RQkyxxLPn8jRE8bfKQEQrgUlXHHTIaWQt+WqEg8QDDXlUBGcX+7zf/D9Uvl9L JVt4KG4iJgenpDjyEE3sVYEoIAxqK/x083a7s7McfLnWnsNv4xaQ5qeAgxFYV5rM2OYi TaYkwJlp1zQeHk+50fEbGPw2Dgp7lepirWI9hNQ5FHATxuTy5j/v7AVpSKBd6+HN2JMQ nHhgOxZPaDga6o2j5dTw34VwBbozvaeOBr6l/xClkrJDZLw5conwq/hPi39v7rYP/Y7R 1dkRrUAB9wcRgqT9T0x+oYpQfGra2QVUqUUa9HUrTIdnqAFEo/3vrxxeHshZe5JbLCMC xwaQ== X-Gm-Message-State: AOJu0Yzpy8aITQ/Utl5UoRAm3s/lAtTfPZEu4OSMvUYNRq1ikR/ueNH0 imfpvoS8lrnourv7nrzOZpub1ynbV4kjduOcfvg= X-Google-Smtp-Source: AGHT+IGcWAsJkQLPG4Arz9vdhxYSUUOAabePIuCDI0oMtBd6c7wLzRu206XJp9JW3IFi5DwkFQSTxA== X-Received: by 2002:a5d:5604:0:b0:319:841c:ae7a with SMTP id l4-20020a5d5604000000b00319841cae7amr10621268wrv.41.1696275755796; Mon, 02 Oct 2023 12:42:35 -0700 (PDT) Received: from [192.168.0.15] (cpc92320-cmbg19-2-0-cust383.5-4.cable.virginm.net. [82.13.65.128]) by smtp.gmail.com with ESMTPSA id t10-20020adff60a000000b0031c5e9c2ed7sm28707882wrp.92.2023.10.02.12.42.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 12:42:35 -0700 (PDT) Message-ID: <65d6fda5-261d-a44e-68d9-51b7989cec21@jkqxz.net> Date: Mon, 2 Oct 2023 20:42:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <82270518-8c7a-d360-ba1a-e2ceca913302@jkqxz.net> <013e7b6892980fd764dcf83e6972173f55296358.camel@intel.com> From: Mark Thompson In-Reply-To: <013e7b6892980fd764dcf83e6972173f55296358.camel@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v2] cbs_av1: Make fake OBU size length field a write option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 27/09/2023 03:16, Wang, Fei W wrote: > On Tue, 2023-09-26 at 21:30 +0100, Mark Thompson wrote: >> This is an option to modify the behaviour of the writer, not a syntax >> field. >> --- >> On 26/09/2023 03:34, Wang, Fei W wrote: >>> On Mon, 2023-09-25 at 14:53 +0100, Mark Thompson wrote: >>>> ... >>>> diff --git a/libavcodec/vaapi_encode_av1.c >>>> b/libavcodec/vaapi_encode_av1.c >>>> index 3ff1c47b53..861bf4a13b 100644 >>>> --- a/libavcodec/vaapi_encode_av1.c >>>> +++ b/libavcodec/vaapi_encode_av1.c >>>> @@ -133,6 +133,9 @@ static av_cold int >>>> vaapi_encode_av1_configure(AVCodecContext *avctx) >>>> priv->cbc->trace_context = ctx; >>>> priv->cbc->trace_write_callback = >>>> vaapi_encode_av1_trace_write_log; >>>> >>>> + av_opt_set_int(priv->cbc->priv_data, >>>> "fixed_obu_size_length", >>>> + priv->attr_ext2.bits.obu_size_bytes_minus1 + >>>> 1, >>>> 0); >>>> + >>> >>> This should be put after querying priv.attr_ext2 in >>> vaapi_encode_av1_init(). >> >> Ah, true - I got my init and configure mixed up, but don't have >> convenient hardware to test. Fixed in this version. > > LGTM for this version. Applied. Thank you for the review! - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".