From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id E9DD443D3A
	for <ffmpegdev@gitmailbox.com>; Mon,  8 Aug 2022 22:59:20 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7BD8568B743;
	Tue,  9 Aug 2022 01:59:17 +0300 (EEST)
Received: from btbn.de (btbn.de [136.243.74.85])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F1D9668B586
 for <ffmpeg-devel@ffmpeg.org>; Tue,  9 Aug 2022 01:59:11 +0300 (EEST)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 9EB3135C3D5
 for <ffmpeg-devel@ffmpeg.org>; Tue,  9 Aug 2022 00:59:11 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1659999551;
 bh=S9WVAorgcwSEspU+3IdoN1cPUwfDD43P/7LGmzaFan8=;
 h=Date:Subject:To:References:From:In-Reply-To;
 b=lqmiJIS/CE/u6rekmz4+RSJ+QD5wGRXt5up6vEIFDHvxm6BI3CcAAqn23GRdQ+rVz
 5mF1Qm47Nwwb2H2WDE9YWzm/k7I6pgsRV94//NUjdIG01gv5A9TXnq6eXGhx3jiwau
 bA472KlzJrLS9VgBfHQtOeob27u+bsLsJxCySHmSbEmWAP5k42mLn83dighf3GpKrv
 9izwW5g4OklA6yNZHVb1ZYxsusWYEpMRdD71u/0/Ack8uSzkaMmLrvIFuXOXmCIs0y
 edKyJgQTtLyO93XvAGZ5hrdHY8CQUOqjfL7fw2c6w9nhV4B/W7SybeWpXVhfnOttfi
 HjeJClAtEs3uA==
Message-ID: <659c3391-e8af-e83d-9d6b-ce9b3df0bdc9@rothenpieler.org>
Date: Tue, 9 Aug 2022 00:59:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.1
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <20220808182358.24264-1-timo@rothenpieler.org>
 <CA+anCRmwy6C-SS+ynM593y8nMgditqRd61J6XEHa86m8fqhaYg@mail.gmail.com>
 <7a75c699-5050-534f-d7e9-127207b66d59@rothenpieler.org>
 <CA+anCRme61uOiqqDeo5uv6BRuw-hjYzv6z4n-LG9Hms37cWRSg@mail.gmail.com>
 <2dac775f-5076-14c2-8afd-a50bbef5531f@rothenpieler.org>
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <2dac775f-5076-14c2-8afd-a50bbef5531f@rothenpieler.org>
Subject: Re: [FFmpeg-devel] [PATCH] swscale/input: add rgbaf16 input support
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/659c3391-e8af-e83d-9d6b-ce9b3df0bdc9@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 09.08.2022 00:37, Timo Rothenpieler wrote:
> The entire support for the format is removed from swscale in this case, 
> so the function ending up empty doesn't matter.
> 
> I'll see if it can be added to half2float, but I can't even tell if it 
> implements ieee floats, or something else.

Did a very straight forward implementation with unions:

> static uint32_t half2float(uint16_t h, const uint32_t *mantissatable, const uint32_t *exponenttable,
>                            const uint16_t *offsettable)
> {
> #if HAVE_FLOAT16
>     union {
>         uint16_t i;
>         _Float16 f;
>     } u16;
>     union {
>         uint32_t i;
>         float f;
>     } u32;
>     u16.i = h;
>     u32.f = u16.f;
>     return u32.i;
> #else
>     uint32_t f;
> 
>     f = mantissatable[offsettable[h >> 10] + (h & 0x3ff)] + exponenttable[h >> 10];
> 
>     return f;
> #endif
> }

Unfortunately, this makes all exr fate tests fail with differing output 
checksums.
At least the checksums match between f16c SIMD version and fallback sse2 
implementation.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".