From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24
Date: Fri, 01 Dec 2023 20:38:37 +0200
Message-ID: <6596049.xiiJylZ7dE@basile.remlab.net> (raw)
In-Reply-To: <1963722.FVt6nWukC3@basile.remlab.net>
Le perjantaina 1. joulukuuta 2023, 20.35.10 EET Rémi Denis-Courmont a écrit :
> Le perjantaina 24. marraskuuta 2023, 0.39.39 EET flow gg a écrit :
> > Okay, changed
>
> src/libavcodec/riscv/ac3dsp_init.c: In function ‘ff_ac3dsp_init_riscv’:
> src/libavcodec/riscv/ac3dsp_init.c:39:33: warning: assignment to ‘void (*)
> (int32_t *, const float *, size_t)’ {aka ‘void (*)(int *, const float *,
> long unsigned int)’} from incompatible pointer type ‘void (*)(int32_t *,
> const float *, unsigned int)’ {aka ‘void (*)(int *, const float *, unsigned
> int)’} [- Wincompatible-pointer-types]
> 39 | c->float_to_fixed24 = ff_float_to_fixed24_rvv;
>
> | ^
>
> Also the Makefile precondition is inaccurate.
Oh, and on C908, LMUL=8 is actually faster than LMUL=4. Generally speaking,
you should maximise the LMUL unless there is a *specific* reason not to.
--
レミ・デニ-クールモン
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-01 18:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 12:00 flow gg
2023-11-22 13:40 ` Rémi Denis-Courmont
2023-11-22 14:30 ` flow gg
2023-11-22 14:35 ` flow gg
2023-11-22 14:51 ` Rémi Denis-Courmont
2023-11-22 16:37 ` flow gg
2023-11-22 16:49 ` James Almer
2023-11-22 23:17 ` flow gg
2023-11-23 17:08 ` Rémi Denis-Courmont
2023-11-23 22:39 ` flow gg
2023-12-01 18:35 ` Rémi Denis-Courmont
2023-12-01 18:38 ` Rémi Denis-Courmont [this message]
2023-12-01 19:50 ` flow gg
2023-12-01 20:16 ` flow gg
2023-11-22 17:18 ` James Almer
2023-11-22 17:34 ` flow gg
2023-11-23 7:11 ` flow gg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6596049.xiiJylZ7dE@basile.remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git